Hi Mickael, Thank you very much for your feedback and direction.
I have added the documentation to the "Public Interfaces" chapter (formatted in a table as I've seen in other KIPs) and I'll put this KIP to a vote next week as per your suggestion. Regards, Julien Le mer. 12 janv. 2022 à 18:19, Mickael Maison <mickael.mai...@gmail.com> a écrit : > > Hi Julien, > > Thanks for the KIP. I looks like a useful improvement to the > TimestampConverter SMT. > > I'd suggest adding the documentation for the new setting to the KIP. > I've had to go check your PR to fully understand how you want to use > it, both for input and output. > Apart from that, if you don't get any further feedback, feel free to > start a vote. > > Thanks, > Mickael > > On Tue, Dec 21, 2021 at 2:19 PM Julien Chanaud <chanaud.jul...@gmail.com> > wrote: > > > > Hi everyone, > > > > Bumping this KIP discussion. > > It's a small change, entirely backward compatible and I'd love your > > feedback on it. > > Thanks, > > Julien > > > > > > Le jeu. 9 déc. 2021 à 21:56, Julien Chanaud <chanaud.jul...@gmail.com> a > > écrit : > > > > > > Hi everyone, > > > > > > I would like to start a discussion for KIP-808 > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-808%3A+Add+support+for+unix+epoch+precision+in+TimestampConverter+SMT > > > > > > This seems like a simple change but I suspect there are several things to > > > consider, most notably regarding the java.util.Date object, which is at > > > the heart of the conversions. > > > > > > Let me know what you think. > > > > > > Julien > > >
