Thanks John!
PS. vote thread started
https://lists.apache.org/thread.html/r5863299712063d4cb4be139ce4ab0533ce66efe04c1f7e993666b09c%40%3Cdev.kafka.apache.org%3E
On Sat, Sep 19, 2020 at 2:46 AM John Roesler wrote:
> Thanks for the KIP, Jorge!
>
> Sorry it took me so long. I just reviewed the KIP
Thanks for the KIP, Jorge!
Sorry it took me so long. I just reviewed the KIP, and it looks good to me.
Thanks,
John
On Tue, Sep 1, 2020, at 12:35, Jorge Esteban Quilcate Otoya wrote:
> Thanks Sophie!
>
> > one nit: you missed updating the startTime long to Instant in both
> appearances of the
Thanks Sophie!
> one nit: you missed updating the startTime long to Instant in both
appearances of the fetchSession(key, startTime, sessionEndTime) method.
Agreed. I'm fixing this on the KIP.
> Also, I think by "startTime" you actually meant "earliestSessionEndTime".
Given the implementation us
Thanks for bringing the IQ API into alignment -- the proposal looks good,
although
one nit: you missed updating the startTime long to Instant in both
appearances of
the fetchSession(key, startTime, sessionEndTime) method. Also, I think by
"startTime"
you actually meant "earliestSessionEndTime".
On
Hi everyone,
I'd like to discuss the following proposal to align IQ Session Store API
with the Window Store one.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-666%3A+Add+Instant-based+methods+to+ReadOnlySessionStore
Looking forward to your feedback.
Cheers,
Jorge.
