Thanks for bringing the IQ API into alignment -- the proposal looks good, although one nit: you missed updating the startTime long to Instant in both appearances of the fetchSession(key, startTime, sessionEndTime) method. Also, I think by "startTime" you actually meant "earliestSessionEndTime".
One question I do have is whether we really need to provide a default implementation that throws UnsupportedOperationException? Actually I'm wondering if we shouldn't do something similar to the WindowStore methods, and provide a default implementation on the SessionStore interface which then just calls the corresponding long-based method. WDYT? -Sophie On Fri, Aug 28, 2020 at 11:31 AM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi everyone, > > I'd like to discuss the following proposal to align IQ Session Store API > with the Window Store one. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-666%3A+Add+Instant-based+methods+to+ReadOnlySessionStore > > Looking forward to your feedback. > > Cheers, > Jorge. >
