Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-25 Thread Bruno Cadonna
Hi Guozhang, Thank you for pointing this out. I added the package to the KIP. Best, Bruno On 24.08.20 20:55, Guozhang Wang wrote: Hello Bruno, Thanks for the KIP, it sounds good to me as well. Just a minor comment: we would include which package the new "MissingSourceTopicException" class bel

Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-24 Thread Guozhang Wang
Hello Bruno, Thanks for the KIP, it sounds good to me as well. Just a minor comment: we would include which package the new "MissingSourceTopicException" class belongs to. Guozhang On Fri, Aug 21, 2020 at 11:53 AM John Roesler wrote: > Thanks for the KIP, Bruno! > > Your proposal sounds goo

Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-21 Thread John Roesler
Thanks for the KIP, Bruno! Your proposal sounds good to me. -John On Fri, 2020-08-21 at 11:18 -0700, Sophie Blee-Goldman wrote: > Thanks for the KIP! I'm totally in favor of this approach and to be honest, > have > always wondered why we just silently shut down instead of throwing an > exception

Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-21 Thread Sophie Blee-Goldman
Thanks for the KIP! I'm totally in favor of this approach and to be honest, have always wondered why we just silently shut down instead of throwing an exception. This has definitely been a source of confusion for users in my personal experience. I was originally hesitant to extend StreamsException

[DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-21 Thread Bruno Cadonna
Hi, I would like to propose the following KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted Best, Bruno