Thanks for the KIP, Bruno! Your proposal sounds good to me.
-John On Fri, 2020-08-21 at 11:18 -0700, Sophie Blee-Goldman wrote: > Thanks for the KIP! I'm totally in favor of this approach and to be honest, > have > always wondered why we just silently shut down instead of throwing an > exception. > This has definitely been a source of confusion for users in my personal > experience. > > I was originally hesitant to extend StreamsException since I always thought > that anything > extending from KafkaException was supposed to "indicate Streams internal > errors" > -- a phrase I'm quoting from Streams logs directly -- but I now see that > we're actually > somewhat inconsistent here. Perhaps "Streams internal errors" does not in > fact mean > internal to Streams itself but just any error that occurs during Stream > processing? > > Anyways, I'm looking forward to cleaning up the exception hierarchy so we > get a clear > division of user vs "internal" error, but within the current framework this > SGTM > > On Fri, Aug 21, 2020 at 8:06 AM Bruno Cadonna <br...@confluent.io> wrote: > > > Hi, > > > > I would like to propose the following KIP: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted > > > > Best, > > Bruno > >
