Re: [DISCUSS] KIP-586: Deprecate commit records without record metadata

2020-04-03 Thread Mario Molina
Hi, I've updated the comment in the KIP (even though it was already included in the PR). Thanks! Mario On Fri, 3 Apr 2020 at 09:01, Randall Hauch wrote: > Hi, Mario. > > Thanks for creating this small but useful KIP! The only suggestion I have > is to include the JavaDoc for the method we want

Re: [DISCUSS] KIP-586: Deprecate commit records without record metadata

2020-04-03 Thread Randall Hauch
Hi, Mario. Thanks for creating this small but useful KIP! The only suggestion I have is to include the JavaDoc for the method we want to deprecate so that we can include the line: * @deprecated Use {@link #commitRecord(SourceRecord, RecordMetadata)} This will make it more clear that there are t

[DISCUSS] KIP-586: Deprecate commit records without record metadata

2020-04-01 Thread Mario Molina
Hi all, I'd like to use this thread to discuss KIP-586. You can see the detail at: https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata Best, Mario