Hi, Mario.

Thanks for creating this small but useful KIP! The only suggestion I have
is to include the JavaDoc for the method we want to deprecate so that we
can include the line:

* @deprecated Use {@link #commitRecord(SourceRecord, RecordMetadata)}


This will make it more clear that there are two methods with the same name
and we're deprecating only one of them.

Best regards,

Randall

On Wed, Apr 1, 2020 at 8:07 PM Mario Molina <mmoli...@gmail.com> wrote:

> Hi all,
>
> I'd like to use this thread to discuss KIP-586.
> You can see the detail at:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata
>
> Best,
> Mario
>

Reply via email to