Hi all,
During the implementation of KIP-460, we discovered that we had to make
some minor changes to the design. I have updated the KIP wiki[1]. You can
see the difference here[2].
At a high-level we made the following changes:
1. Added a top level ErrorCode to the response for errors that a
On Sun, May 5, 2019 at 12:35 PM Stanislav Kozlovski
wrote:
> Hey there Jose, thanks for the KIP!
>
> I have one small nit regarding the `kafka-leader-election.sh` tool. I agree
> with Jason that it is probably better to force users be explicit in their
> desired election type. I was wondering whe
Hey there Jose, thanks for the KIP!
I have one small nit regarding the `kafka-leader-election.sh` tool. I agree
with Jason that it is probably better to force users be explicit in their
desired election type. I was wondering whether it makes sense to support
only "preferred" and "unclean" for the
On Tue, Apr 30, 2019 at 11:39 AM Jason Gustafson wrote:
> Thanks for the updates, Jose. The proposal looks good to me. Just one minor
> question I had is whether we should even have a default --election-type in
> kafka-leader-election.sh. I am wondering if it is reasonable to make the
> user be e
Thanks for the updates, Jose. The proposal looks good to me. Just one minor
question I had is whether we should even have a default --election-type in
kafka-leader-election.sh. I am wondering if it is reasonable to make the
user be explicit about what they are trying to do?
-Jason
On Fri, Apr 26,
Hi all,
Jason, Colin and I discuss this KIP offline and decided to make the
following changes.
1. Change the ElectLeadersRequest RPC so that only one election type can
be specified and it applies to all of the topic partitions enumerated. We
think that this makes the API easier to use wh
On Thu, Apr 25, 2019 at 11:47 AM Jason Gustafson wrote:
>
> Hi Jose,
>
> This looks useful. One comment I had is whether we can improve the leader
> election tool. Needing to provide a json file is a bit annoying. Could we
> have a way to specify partitions directly through the command line? Often
Hi Jose,
This looks useful. One comment I had is whether we can improve the leader
election tool. Needing to provide a json file is a bit annoying. Could we
have a way to specify partitions directly through the command line? Often
when we need to enable unclean leader election, it is just one or a
On Thu, Apr 25, 2019 at 8:22 AM Colin McCabe wrote:
>
> On Wed, Apr 24, 2019, at 21:04, Jose Armando Garcia Sancio wrote:
> > Thanks for the reply. Comments below.
> >
> > On Wed, Apr 24, 2019 at 6:07 PM Colin McCabe wrote:
> > > What's the rationale for using an int8 rather than just having a bo
On Wed, Apr 24, 2019, at 21:04, Jose Armando Garcia Sancio wrote:
> Thanks for the reply. Comments below.
>
> On Wed, Apr 24, 2019 at 6:07 PM Colin McCabe wrote:
>
> > Hi Jose,
> >
> > Thanks for the KIP, looks valuable.
> >
> > If I use a PreferredLeaderElection RPC to specifically request an u
Thanks for the reply. Comments below.
On Wed, Apr 24, 2019 at 6:07 PM Colin McCabe wrote:
> Hi Jose,
>
> Thanks for the KIP, looks valuable.
>
> If I use a PreferredLeaderElection RPC to specifically request an unclean
> leader election, will this take effect even if unclean leader elections are
Hi Jose,
Thanks for the KIP, looks valuable.
If I use a PreferredLeaderElection RPC to specifically request an unclean
leader election, will this take effect even if unclean leader elections are
disabled on the topic involved? I assume that the answer is yes, but it would
be good to clarify t
Hi all,
We would like to extend the "preferred leader election" RPC for the admin
client to also support unclean leader elections.
The KIP can be found here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC
Thanks!
-Jose
13 matches
Mail list logo
