Hey there Jose, thanks for the KIP! I have one small nit regarding the `kafka-leader-election.sh` tool. I agree with Jason that it is probably better to force users be explicit in their desired election type. I was wondering whether it makes sense to support only "preferred" and "unclean" for the "--election-type" flag, not the numeric values. While 0 and 1 are what the RPC uses, I think it might be simpler if we abstracted that detail away from users and stick to terms they are familiar with.
On Wed, May 1, 2019 at 12:35 AM Jose Armando Garcia Sancio < jsan...@confluent.io> wrote: > On Tue, Apr 30, 2019 at 11:39 AM Jason Gustafson <ja...@confluent.io> > wrote: > > > Thanks for the updates, Jose. The proposal looks good to me. Just one > minor > > question I had is whether we should even have a default --election-type > in > > kafka-leader-election.sh. I am wondering if it is reasonable to make the > > user be explicit about what they are trying to do? > > > > This change sounds good to me. We can always add a default to > --election-type in the future without breaking backwards compatibility. > > Thanks! > -- Best, Stanislav
