Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hey everybody, Just wanted to say that I plan on starting a voting thread tomorrow if there aren't any further comments. Thanks for the discussion so far! On Wed, Oct 24, 2018 at 11:27 AM Stanislav Kozlovski wrote: > Hi Kevin, > > Thanks for providing context. > > I've edited the KIP to use `N

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hi Kevin, Thanks for providing context. I've edited the KIP to use `NaN` for all three metric types. Here is the updated link: KIP-386: Standardize on Min/Avg/Max metrics' default value On Tue, Oct 23, 2018 at 7:30 PM Ke

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hi Stanislav, Thanks for the KIP! Standardizing this would be extremely helpful. We have been publishing client-side metrics to a time-series database using metrics reporter since 0.8, and we had to do explicit checks like "!Double.isNaN(metricValue)", "metricValue != Double.NEGATIVE_INFINITY", a

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hey John, I think NaN would be the better option semantically. If we were to use that, maybe it makes sense to change `Avg()`'s default value from 0.0 to NaN as well. I am a bit more concerned with backwards compatibility if we were to use NaN since we would change three types of metrics. There w

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hi Stanislav, Thanks for this KIP. I coincidentally just noticed these strange initial values while doing some performance measurements. Since the metric type is a double, could we consider NaN instead? It seems like +Inf is somewhat arbitrary for Max, so it might as well be an arbitrary value tha

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hi Suman, Thanks for taking a look at this. Yeah, it's very minor but it changes the public API (even if this is a very slight change) and as far as I know this warrants some discussion On Mon, Oct 22, 2018 at 9:28 PM Suman B N wrote: > Looks good to me. Maintains uniformity. +1 from me. > But

Re: [DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Looks good to me. Maintains uniformity. +1 from me. But its more of a bug rather than improvement proposal. Let's see what contributors got to say. On Mon, Oct 22, 2018 at 7:23 PM Stanislav Kozlovski wrote: > Hey everybody, > > I've opened up a very short KIP to make the Max and Min metrics' def

[DISCUSS] KIP-386: Make Min metrics' default value consistent with Max metrics

Hey everybody, I've opened up a very short KIP to make the Max and Min metrics' default values consistent with each other. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-386%3A+Make+Min+metrics%27+default+value+consistent+with+Max+metrics JIRA: https://issues.apache.org/jira/browse/KA