[DISCUSS] KIP-379: Multiple Consumer Group Management

2019-01-10 Thread Alex D
Hi Jason, Sorry for the late reply too. All proposed/dismissed changes done. Please review the latest PR updates: https://github.com/apache/kafka/pull/5726/ #1. Done. Backwards compatibility with old csv format is preserved. #2. Not. Considered not to omit the GROUP column for `--describe` outpu

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2019-01-10 Thread Alex D
Hi Jason, Sorry for the late reply too. All proposed/dismissed changes done. Please review the latest PR updates: https://github.com/apache/kafka/pull/5726/ #1. Done. Backwards compatibility with old csv format is preserved. #2. Not. Considered not to omit the GROUP column for `--describe` output

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-11-28 Thread Jason Gustafson
Hi Alex, Sorry for the late reply. Your message didn't get attached to the main thread and I missed it. #1. Yeah, I think we should continue to accept the old csv format. Compatibility is important for all public APIs. #2. I think this is less important from a compatibility perspective. On the on

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-11-05 Thread Alex D
Hello guys, Thank you for your suggestions! I've made a short resume of all suggestions proposed for further possible code corrections. Since not all opinions match, let's review once again and decide. #1. Support old csv format. Proposed by Jason. Yes: Jason, Vahid If backwards

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-10-20 Thread eazama001
Is there a reason for using multiple --group flags over having it accept a regex? The topics command currently accepts a regex for most operations and doesn't support using multiple topics flags. It seems like it would be better to take a more standardized approach to providing this type of inf

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-10-19 Thread Suman B N
This eases debugging metadata information of consumer groups and offsets in case of client hungs which we have been facing frequently. +1 from me. Well done Alex! -Suman On Fri, Oct 19, 2018 at 8:36 PM Vahid Hashemian wrote: > Thanks for proposing the KIP. Looks good to me overall. > > I agree

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-10-19 Thread Vahid Hashemian
Thanks for proposing the KIP. Looks good to me overall. I agree with Jason's suggestion that it would be best to keep the current output format when a single '--group' is present. Because otherwise, there would be an impact to users who rely on the current output format. Also, starting with a GROU

Re: [DISCUSS] KIP-379: Multiple Consumer Group Management

2018-10-18 Thread Jason Gustafson
Hi Alex, Thanks for the KIP. I think it makes sense, especially since most of the group apis are intended for batching anyway. The only questions I have are about compatibility. For example, the csv format for resetting offsets is changed, so will we continue to support the old format? Also, if o

[DISCUSS] KIP-379: Multiple Consumer Group Management

2018-10-03 Thread Alex D
Hello, friends! Welcome to the Multiple Consumer Group Management feature for kafka-consumer-groups utility discussion thread. KIP is available here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-379%3A+Multiple+Consumer+Group+Management Pull Request: https://github.com/apache/kafka/pull