Thanks for proposing the KIP. Looks good to me overall. I agree with Jason's suggestion that it would be best to keep the current output format when a single '--group' is present. Because otherwise, there would be an impact to users who rely on the current output format. Also, starting with a GROUP column makes more sense to me.
Also, and for my own info, is there a valid scenario where we would want to delete all consumer groups? It sounds to me like a potentially dangerous feature. I would imagine that it would help more with dev/test environments, where we normally have a few groups (for which the repeating '--group' option should work). Regards! --Vahid On Thu, Oct 18, 2018 at 11:28 PM Jason Gustafson <ja...@confluent.io> wrote: > Hi Alex, > > Thanks for the KIP. I think it makes sense, especially since most of the > group apis are intended for batching anyway. > > The only questions I have are about compatibility. For example, the csv > format for resetting offsets is changed, so will we continue to support the > old format? Also, if only one `--group` option is passed, do you think it's > worth leaving it the group column out of the `--describe` output? That > would keep the describe output consistent with the current implementation > for the current usage. Finally, and this is just a nitpick, but do you > think it makes sense to put the group column first in the describe output? > > Thanks, > Jason > > > On Wed, Oct 3, 2018 at 7:11 AM, Alex D <a.a.dunayev...@gmail.com> wrote: > > > Hello, friends! > > > > Welcome to the Multiple Consumer Group Management feature for > > kafka-consumer-groups utility discussion thread. > > > > KIP is available here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-379% > > 3A+Multiple+Consumer+Group+Management > > > > Pull Request: https://github.com/apache/kafka/pull/5726 > > > > JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-7471 > > > > What do you think? > > > > Thanks, > > Alexander Dunayevsky > > >
