Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi All, Colin, thanks for the heads-up. I'll rethink this metadata protocol thing as in a global sense there might be other options as you mentioned and start separate a discussion. I'll start a vote soon as the KIP itself is relatively simple. Viktor On Tue, Oct 23, 2018 at 3:33 AM Kevin Lu w

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Viktor, +1 to this KIP. I would very much like to see AdminClient in TopicCommand. This would also allow us to efficiently implement new features like the "--under-min-isr" option I proposed in KIP-351

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Viktor, Sounds good. If you want to propose a way of improving the metadata protocol so that "[deleted]" could be supported, you could probably create that KIP in parallel. The last KIP in that area that I can remember is KIP-142, which didn't get adopted (yet?) https://cwiki.apache.org/c

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Colin, Thanks, it makes sense and simplifies this KIP tremendously. I'll move this section to the rejected alternatives with a note that KIP-142 will have this feature. On a similar note: is there a KIP for describe topics protocol or have you been thinking about it? I guess there it's the same

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Viktor, Thanks for bumping this thread. I think we should just focus on transitioning the TopicCommand to use AdminClient, and talk about protocol changes in a separate KIP. Protocol changes often involve a lot of discussion. This does mean that we couldn't implement the "list topics unde

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi All, Would like to bump this as the conversation sank a little bit, but more importantly I'd like to validate my plans/ideas on extending the Metadata protocol. I was thinking about two other alternatives, namely: 1. Create a ListTopicUnderDeletion protocol. This however would be unnecessary: i

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi All, I made an update to the KIP. Just in short: Currently KafkaAdminClient.describeTopics() and KafkaAdminClient.listTopics() uses the Metadata protocol to acquire topic information. The returned response however won't contain the topics that are under deletion but couldn't complete yet (for i

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Mickael, Thanks for the feedback, I also think that many customers wanted this for a long time. Cheers, Viktor On Fri, Sep 28, 2018 at 11:45 AM Mickael Maison wrote: > Hi Viktor, > Thanks for taking this task! > This is a very nice change as it will allow users to use this tool in > many Cl

Re: [DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi Viktor, Thanks for taking this task! This is a very nice change as it will allow users to use this tool in many Cloud environments where direct zookeeper access is not available. On Thu, Sep 27, 2018 at 10:34 AM Viktor Somogyi-Vass wrote: > > Hi All, > > This is the continuation of the old KI

[DISCUSS] KIP-377: TopicCommand to use AdminClient

Hi All, This is the continuation of the old KIP-375 with the same title: https://lists.apache.org/thread.html/dc71d08de8cd2f082765be22c9f88bc9f8b39bb8e0929a3a4394e9da@%3Cdev.kafka.apache.org%3E The problem there was that two KIPs were created around the same time and I chose to reorganize mine a