Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-27 Thread Dongjin Lee
No problem. Thanks! - Dongjin On Thu, Sep 27, 2018 at 7:28 PM Viktor Somogyi-Vass wrote: > Hi All, > > A technical update: around the time I created this KIP, another one got > created with the same number and therefore to avoid collisions in KIP > numbers I chose to increment my KIP's number,

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-27 Thread Viktor Somogyi-Vass
Hi All, A technical update: around the time I created this KIP, another one got created with the same number and therefore to avoid collisions in KIP numbers I chose to increment my KIP's number, so the new URL where it is available is: https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-26 Thread Viktor Somogyi-Vass
Hi Manikumar, Thanks for raising this to my attention. I must have missed this in the AdminClient, so you're right, we don't need this new protocol at all. I've moved it to the rejected alternatives section. Thanks, Viktor On Wed, Sep 26, 2018 at 8:24 AM Manikumar wrote: > Hi Viktor, > > We al

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-25 Thread Manikumar
Hi Viktor, We already have API (AdminClient.createPartitions, CreatePartitionsRequest/Response ) to increase the number of partitions of the topics. So, we may not need the protocol changes proposed in the KIP. Let me know, If I am missing anything. Thanks, On Tue, Sep 25, 2018 at 2:45 PM Vikt

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-25 Thread Viktor Somogyi-Vass
Hi Eno, Thanks for the question. Basically KAFKA-5561 aims for a bigger task: not to add functionality to the existing TopicCommand but rewrite it in the tools module in Java. KIP-375 only aims for extending the existing TopicCommand's capability, so it is a smaller and backward compatible step in

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-25 Thread Eno Thereska
This would be very useful. Could you clarify a bit the difference to https://issues.apache.org/jira/browse/KAFKA-5561 since I didn't get it from the JIRA notes. It's fine if you pick up that work but wanted to make sure we're not duplicating efforts. Thanks Eno On Mon, Sep 24, 2018 at 8:26 PM, Vi

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-24 Thread Viktor Somogyi-Vass
Hi Gwen, Thanks for your feedback. It is the latter, so passing extra connection properties for the admin client. I'll try to make that clearer in the KIP. The same option name is used in the ConfigCommand, so that's why I named it "command-config". Cheers, Viktor On Mon, Sep 24, 2018 at 8:18 P

Re: [DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-24 Thread Gwen Shapira
The "use admin client" part is amazing and thank you. I'm confused about "commandConfig" - is this a list of configurations for use with --config option? Or a list of properties for connecting to brokers (like SSL and such)? If the former, it seems unrelated. On Mon, Sep 24, 2018 at 7:25 AM Vikto

[DISCUSS] KIP-375: TopicCommand to use AdminClient

2018-09-24 Thread Viktor Somogyi-Vass
Hi All, I wrote up a relatively simple KIP about improving the Kafka protocol and the TopicCommand tool to support the new Java based AdminClient and hopefully to deprecate the Zookeeper side of it. I would be happy to receive some opinions about this. In general I think this would be an importan