Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-10-29 Thread xiongqi wu
Thanks Dong. I have updated the KIP. Instead of using a configure to specify the timeout, I switch it to use internal timer. User doesn't need a new configuration to use this feature. Xiongqi (Wesley) Wu On Mon, Oct 29, 2018 at 4:40 PM xiongqi wu wrote: > Dong, > > Thanks for the comments. >

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-10-29 Thread xiongqi wu
Dong, Thanks for the comments. 1) With KIP-380, in theory we don't need the timeout phase. However, once orphan partitions are removed, they cannot be recovered. The question is should we rely on the fact that the first leaderandISR always contains correct information. For retention enabled topi

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-10-28 Thread Dong Lin
Hey Xiongqi, Thanks for the KIP. Here are some comments: 1) KIP provides two motivation for the timeout/correction phase. One motivation is to handle outdated requests. Would this still be an issue after KIP-380? The second motivation seems to be mainly for performance optimization when there is

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-09-20 Thread xiongqi wu
Colin, Thanks for the comment. 1) auto.orphan.partition.removal.delay.ms refers to timeout since the first leader and ISR request was received. The idea is we want to wait enough time to receive up-to-dated leaderandISR request and any old or new partitions reassignment requests. 2) Is there any

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-09-20 Thread Colin McCabe
Hi Xiongqi, Thanks for the KIP. Can you be a bit more clear what the timeout auto.orphan.partition.removal.delay.ms refers to? Is the timeout measured since the partition was supposed to be on the broker? Or is the timeout measured since the broker started up? Is there any logic to remove t

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-09-19 Thread xiongqi wu
Any comments? Xiongqi (Wesley) Wu On Mon, Sep 10, 2018 at 3:04 PM xiongqi wu wrote: > Here is the implementation for the KIP 370. > > > https://github.com/xiowu0/kafka/commit/f1bd3085639f41a7af02567550a8e3018cfac3e9 > > > The purpose is to do one time cleanup (after a configured delay) of orph

Re: [DISCUSS] KIP-370: Remove Orphan Partitions

2018-09-10 Thread xiongqi wu
Here is the implementation for the KIP 370. https://github.com/xiowu0/kafka/commit/f1bd3085639f41a7af02567550a8e3018cfac3e9 The purpose is to do one time cleanup (after a configured delay) of orphan partitions when a broker starts up. Xiongqi (Wesley) Wu On Wed, Sep 5, 2018 at 10:51 AM xiong

[DISCUSS] KIP-370: Remove Orphan Partitions

2018-09-05 Thread xiongqi wu
This KIP enables broker to remove orphan partitions automatically. https://cwiki.apache.org/confluence/display/KAFKA/KIP-370%3A+Remove+Orphan+Partitions Xiongqi (Wesley) Wu