Colin, Thanks for the comment. 1) auto.orphan.partition.removal.delay.ms refers to timeout since the first leader and ISR request was received. The idea is we want to wait enough time to receive up-to-dated leaderandISR request and any old or new partitions reassignment requests.
2) Is there any logic to remove the partition folders on disk? I can only find references to removing older log segments, but not the folder, in the KIP. ==> yes, the plan is to remove partition folders as well. I will update the KIP to make it more clear. Xiongqi (Wesley) Wu On Thu, Sep 20, 2018 at 5:02 PM Colin McCabe <cmcc...@apache.org> wrote: > Hi Xiongqi, > > Thanks for the KIP. > > Can you be a bit more clear what the timeout > auto.orphan.partition.removal.delay.ms refers to? Is the timeout > measured since the partition was supposed to be on the broker? Or is the > timeout measured since the broker started up? > > Is there any logic to remove the partition folders on disk? I can only > find references to removing older log segments, but not the folder, in the > KIP. > > best, > Colin > > On Wed, Sep 19, 2018, at 10:53, xiongqi wu wrote: > > Any comments? > > > > Xiongqi (Wesley) Wu > > > > > > On Mon, Sep 10, 2018 at 3:04 PM xiongqi wu <xiongq...@gmail.com> wrote: > > > > > Here is the implementation for the KIP 370. > > > > > > > > > > https://github.com/xiowu0/kafka/commit/f1bd3085639f41a7af02567550a8e3018cfac3e9 > > > > > > > > > The purpose is to do one time cleanup (after a configured delay) of > orphan > > > partitions when a broker starts up. > > > > > > > > > Xiongqi (Wesley) Wu > > > > > > > > > On Wed, Sep 5, 2018 at 10:51 AM xiongqi wu <xiongq...@gmail.com> > wrote: > > > > > >> > > >> This KIP enables broker to remove orphan partitions automatically. > > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-370%3A+Remove+Orphan+Partitions > > >> > > >> > > >> Xiongqi (Wesley) Wu > > >> > > > >
