Thanks, Chia-Ping. Looks good to me.
regards,
Colin
On Sat, Aug 4, 2018, at 01:17, Chia-Ping Tsai wrote:
> hi Colin
>
> Thanks for the reviews! You are totally right. The description of
> KIP-348 is not accurate. The purpose of KIP-348 is to encourage
> connector user to substitute empty list
hi Colin
Thanks for the reviews! You are totally right. The description of KIP-348 is
not accurate. The purpose of KIP-348 is to encourage connector user to
substitute empty list to null value, but at the same time returning null still
work.
I will update the KIP-348 ASAP.
cheers,
Chia-Ping
"No changes to public interface" doesn't seem accurate here. SourceTask#poll
is a public interface, right? Kafka connectors that are out-of-tree would
certainly break if we disallowed returning null from this method.
However, reading the KIP more closely, it seems like both null and the empty
hi all,
Please take a look at the KIP-348[1] if you have free cycel. It bring a little
change to the usage of SourceTask#poll()
[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89065853&moved=true#KIP-348EliminatenullfromSourceTask#poll()-Status
Cheers,
Chia-Ping
