"No changes to public interface" doesn't seem accurate here. SourceTask#poll is a public interface, right? Kafka connectors that are out-of-tree would certainly break if we disallowed returning null from this method.
However, reading the KIP more closely, it seems like both null and the empty list will be supported. Perhaps you should discuss this in the compatibility section? Also, the KIP should probably be renamed "deprecate null" rather than "eliminate null" since it will still be possible to return null here, right? best, Colin On Tue, Jul 31, 2018, at 01:10, Chia-Ping Tsai wrote: > hi all, > > Please take a look at the KIP-348[1] if you have free cycel. It bring a > little change to the usage of SourceTask#poll() > > > [1] > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89065853&moved=true#KIP-348EliminatenullfromSourceTask#poll()- > Status > > Cheers, > Chia-Ping
