Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-02-20 Thread Boyang Chen
Great, thank you Matthias! From: Matthias J. Sax Sent: Thursday, February 21, 2019 10:55 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder Thanks. LGTM. -Matthias On 1/20/19 8:39 PM, Boyang Chen wrote: >

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-02-20 Thread Matthias J. Sax
iff 😊 > > Boyang > > > From: Matthias J. Sax > Sent: Saturday, January 19, 2019 3:16 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder > > Thank Boyang! > >>> I think it should be good to just exten

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-20 Thread Boyang Chen
@kafka.apache.org Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder Thank Boyang! >> I think it should be good to just extend ConsumedInternal and >> MaterializedInternal with window size, and keep >> external API clean. Just so you know it would be even more mess

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-18 Thread Matthias J. Sax
ypo, and I already fixed it. > > I will let you know when the KIP updates are done. > > Best, > Boyang > ________________ > From: Matthias J. Sax > Sent: Thursday, January 17, 2019 7:52 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-300

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-18 Thread Boyang Chen
one. Best, Boyang From: Matthias J. Sax Sent: Thursday, January 17, 2019 7:52 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder Couple of follow up comment on the KIP: It seems that `windowSize` is a mandatory argument f

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-16 Thread Matthias J. Sax
Boyang > > From: Matthias J. Sax > Sent: Sunday, January 13, 2019 10:53 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder > > Do you want to get this into 2.2 release? KIP deadline is 1/24, so q

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-12 Thread Boyang Chen
ementation timeline until we agree on the updated high level APIs first. Does that make sense? Best, Boyang From: Matthias J. Sax Sent: Sunday, January 13, 2019 10:53 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder D

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-12 Thread Matthias J. Sax
Do you want to get this into 2.2 release? KIP deadline is 1/24, so quite soon. Overall, the KIP is very useful. I can review again in more details if you aim for 2.2 -- did you address all previous comment about the KIP already? -Matthias On 1/8/19 2:50 PM, Boyang Chen wrote: > Hey folks, >

[DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-08 Thread Boyang Chen
Hey folks, I would like to start a discussion thread on adding new time/session windowed KTable APIs for KStream: https://cwiki.apache.org/confluence/display/KAFKA/KIP-300%3A+Add+Windowed+KTable+API+in+StreamsBuilder We have been working on this thread around 7 months ago, and it is successfully