: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Thanks Ewen and Matthias for the explanation. I'm also in favor of the
current proposal, and my rationale are basically 1) inheritance hierarchy
is simple for users to understand (Matthias has ex
as
> has mentioned in the previous email, hope this helps!
>
>
> Best,
>
> Boyang
>
>
>
> From: Matthias J. Sax
> Sent: Thursday, April 12, 2018 8:35 AM
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfi
the previous email, hope this helps!
>
>
> Best,
>
> Boyang
>
>
>
> From: Matthias J. Sax
> Sent: Thursday, April 12, 2018 8:35 AM
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different
> consumers
>
> Thank
hope this helps!
Best,
Boyang
From: Matthias J. Sax
Sent: Thursday, April 12, 2018 8:35 AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Thanks for the explanation.
I am not sure if I follow
n
>>>> (perhaps modified) all or nothing approach to inheriting from the the
>>>> "main" consumer properties? In that mode if you override *anything*, you
>>>> should specify *everything*. But if it was just, e.g. group.id,
>> client.id,
>>>> a
hus, we
> >>>> cannot just rename the method.
> >>>>
> >>>> I think we have two options: either we keep the current name or we
> >>>> deprecate the method and introduce `getMainConsumerConfigs()` in
> >>>> parallel. The deprecat
AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Hey guys,
thanks for the discussion. One good point Matthias pointed out was that the
whole "consumer config separation" is for advanced users. In case someone wants
to set dif
e.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Hey guys,
thanks for the discussion. One good point Matthias pointed out was that the
whole "consumer config separation" is for advanced users. In case someone wants
to set different consumer configs, he
From: Matthias J. Sax
Sent: Friday, April 6, 2018 6:28 AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Ewen,
I cannot completely follow your argument. Can you elaborate a little
bit? After reading you mail, I am not sure if you
where they need it. I think
>> inheritance in these configuration setups needs to be approached very
>> carefully. Admittedly, some of the challenges in Connect don't appear here
>> (e.g. conflicts in producer/consumer config naming, since this is a
>> Consumer-only KIP), but similar problems arise.
>>
>>
gt; > On Tue, Apr 3, 2018 at 1:14 AM, Boyang Chen
> > wrote:
> > > >
> > > >> Hey friends,
> > > >>
> > > >>
> > > >> both KIP<https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > >> 2
t; getConsumerConfigs() function. Do you think we could move to a voting stage
> now?
>
>
> ____________________
> From: Guozhang Wang
> Sent: Thursday, April 5, 2018 9:52 AM
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for
.
> >>
> >>
> >>
> >> Thanks for your valuable feedback!
> >>
> >>
> >> Best,
> >>
> >> Boyang
> >>
> >>
> >> From: Boyang Chen
> >> Sent: Tuesday, Ap
>>
>> Best,
>>
>> Boyang
>>
>> ________________
>> From: Boyang Chen
>> Sent: Tuesday, April 3, 2018 11:39 AM
>> To: dev@kafka.apache.org
>> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different
>&
; Thanks for your valuable feedback!
> >>
> >>
> >> Best,
> >>
> >> Boyang
> >>
> >>
> >> From: Boyang Chen
> >> Sent: Tuesday, April 3, 2018 11:39 AM
> >> To: dev@kafka.a
t;>
>> Best,
>>
>> Boyang
>>
>> ________________
>> From: Boyang Chen
>> Sent: Tuesday, April 3, 2018 11:39 AM
>> To: dev@kafka.apache.org
>> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different
>&
ent: Tuesday, April 3, 2018 11:39 AM
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different
> consumers
>
> Thanks Matthias, Ted and Guozhang for the inputs. I shall address them in
> next round.
>
>
> _
est,
Boyang
From: Boyang Chen
Sent: Tuesday, April 3, 2018 11:39 AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Thanks Matthias, Ted and Guozhang for the inputs. I shall address them in
Thanks Matthias, Ted and Guozhang for the inputs. I shall address them in next
round.
From: Matthias J. Sax
Sent: Tuesday, April 3, 2018 4:43 AM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers
Yes, your
Yes, your examples make sense to me. That was the idea behind the proposal.
-Matthias
On 4/2/18 11:25 AM, Guozhang Wang wrote:
> @Matthias
>
> That's a good question: I think adding another config for the main consumer
> makes good tradeoffs between compatibility and new user convenience. Just
@Matthias
That's a good question: I think adding another config for the main consumer
makes good tradeoffs between compatibility and new user convenience. Just
to clarify, from user's pov on upgrade:
1) I'm already overriding some consumer configs, and now I want to override
these values differen
bq. to introduce one more prefix `main.consumer.`
Makes sense.
On Mon, Apr 2, 2018 at 11:06 AM, Matthias J. Sax
wrote:
> Boyang,
>
> thanks a lot for the KIP.
>
> Couple of questions:
>
> > (MODIFIED) public Map getRestoreConsumerConfigs(final
> String clientId);
>
> You mean that the implement
Boyang,
thanks a lot for the KIP.
Couple of questions:
> (MODIFIED) public Map getRestoreConsumerConfigs(final String
> clientId);
You mean that the implementation/semantics of this method changes, but
not the API itself? Might be good to add this as "comment style" instead
of "(MODIFIED)" pre
Thanks for the KIP Boyang, the KIP looks good to me.
For config values, we use underscore for keeping a single word; for config
keys, though, we do not use underscores or dashes. I'd suggest using dots
to be consistent with others.
Otherwise I'm +1 on the KIP.
Guozhang
On Sun, Apr 1, 2018 at
Looks good overall.
public static final String RESTORE_CONSUMER_PREFIX = "restore-consumer.";
For other constants in StreamsConfig, underscore is used instead of dash.
Cheers
On Sun, Apr 1, 2018 at 9:38 AM, Boyang Chen wrote:
> Hey friends,
>
>
> I would like to start a discussion thread for
Hey friends,
I would like to start a discussion thread for KIP 276:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-276+Add+StreamsConfig+prefix+for+different+consumers
And pull request is here:
https://github.com/apache/kafka/pull/4805
[https://avatars3.githubusercontent.com/u/5845561
26 matches
Mail list logo
