Thanks for the KIP Boyang, the KIP looks good to me. For config values, we use underscore for keeping a single word; for config keys, though, we do not use underscores or dashes. I'd suggest using dots to be consistent with others.
Otherwise I'm +1 on the KIP. Guozhang On Sun, Apr 1, 2018 at 10:56 AM, Ted Yu <yuzhih...@gmail.com> wrote: > Looks good overall. > > public static final String RESTORE_CONSUMER_PREFIX = "restore-consumer."; > > For other constants in StreamsConfig, underscore is used instead of dash. > > Cheers > > On Sun, Apr 1, 2018 at 9:38 AM, Boyang Chen <bche...@outlook.com> wrote: > > > Hey friends, > > > > > > I would like to start a discussion thread for KIP 276: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 276+Add+StreamsConfig+prefix+for+different+consumers > > > > > > And pull request is here: > > > > https://github.com/apache/kafka/pull/4805 > > > > [https://avatars3.githubusercontent.com/u/5845561?s=400&v=4]<https:// > > github.com/apache/kafka/pull/4805> > > > > KAFKA-6657: Add StreamsConfig prefix for different consumers by abbccdda > · > > Pull Request #4805 · apache/kafka<https://github. > > com/apache/kafka/pull/4805> > > github.com > > This pull request is for jira 6657. The KIP proposal is here Added unit > > tests for new getGlobalConsumerConfigs API and make sure existing restore > > consumer tests are passing. > > > > > > > > > > > > Thanks, > > > > Boyang > > > -- -- Guozhang
