Hi all,
We want to include this KIP in the upcoming 1.1.0 release.
Please let me know if there are any other comments.
If there are no more comments, I'd like to start vote on this KIP.
Thanks,
On Wed, Jan 17, 2018 at 8:20 AM, Manikumar
wrote:
> Hi, Jun,
>
> Thanks for the review.
>
> 1. Yes
Hi, Jun,
Thanks for the review.
1. Yes, We can pass hmac as byte[]. Updated the KIP
2. Yes, describeDelegationToken() returns all the user owned tokens and
tokens where user have Describe permission.
Added a comment to KIP.
3. updated the KIP with possible exceptions.
Thanks,
On We
Hi Ted,
Thanks for the review.
1. default value for maxLifeTimeMs is -1. with this, token MaxLifeTime
will default to a server side
config value (delegation.token.max.lifetime.ms). Added a comment to the
KIP.
2. Yes, DelegationTokenOwnerMismatchException will be thrown, updated the
KIP with
Hi, Mani,
Thanks for the KIP. Looks good to me overhead. Just a couple of minor
comments below.
1. Should hmac be of type ByteBuffer? We return hmac as byte[] in
DelegationToken.
So, it seems it's more consistent to pass in hmac as byte[] too.
2. Does describeDelegationToken() return all tokens?
Looks like DelegationTokenOwnerMismatchException would be thrown if token
expiration is issued by non-owner.
On Tue, Jan 16, 2018 at 11:16 AM, Ted Yu wrote:
> For createDelegationToken, what's the default value for maxLifeTimeMs ?
>
> For expireDelegationToken, what exception would be thrown if
For createDelegationToken, what's the default value for maxLifeTimeMs ?
For expireDelegationToken, what exception would be thrown if the operation
is not permitted ?
Thanks
On Tue, Jan 16, 2018 at 10:03 AM, Manikumar
wrote:
> Hi all,
>
> I have created a KIP to add delegation token operations
Hi all,
I have created a KIP to add delegation token operations to Java Admin
Client.
This KIP proposes new API additions to admin client. There are no new wire
protocol changes.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-249%3A+Add+Delegation+Token+Operations+to+KafkaAdminClient
Fee
