Hi Ted, Thanks for the review.
1. default value for maxLifeTimeMs is -1. with this, token MaxLifeTime will default to a server side config value (delegation.token.max.lifetime.ms). Added a comment to the KIP. 2. Yes, DelegationTokenOwnerMismatchException will be thrown, updated the KIP with possible exceptions. Thanks On Wed, Jan 17, 2018 at 6:45 AM, Jun Rao <j...@confluent.io> wrote: > Hi, Mani, > > Thanks for the KIP. Looks good to me overhead. Just a couple of minor > comments below. > > 1. Should hmac be of type ByteBuffer? We return hmac as byte[] in > DelegationToken. > So, it seems it's more consistent to pass in hmac as byte[] too. > 2. Does describeDelegationToken() return all tokens? > 3. As Ted mentioned, it would be useful to include the exceptions that can > be thrown in the new apis. > > Jun > > On Tue, Jan 16, 2018 at 10:03 AM, Manikumar <manikumar.re...@gmail.com> > wrote: > > > Hi all, > > > > I have created a KIP to add delegation token operations to Java Admin > > Client. > > This KIP proposes new API additions to admin client. There are no new > wire > > protocol changes. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 249%3A+Add+Delegation+Token+Operations+to+KafkaAdminClient > > > > > > Feedback and suggestions are welcome. > > > > Thanks > > Manikumar > > >
