Benz,
> so when replace the old api usage
>> with the new one we don’t have any kind of auto renaming so the backup
>> topic name will be inconsistent.
Yes.
Note, that for global state stores, there won't be any internally
created changelog topics because the original input topic can be used
for
Hi Matthias,
I am not sure weather I understand the impact correctly. With the old api
user have to specify name for state store and the name is used for auto
generated topics for fault tolerance, so when replace the old api usage
with the new one we don’t have any kind of auto renaming so the back
I couldn’t find this thread in mailing list. this reply is just to trigger
it up so I can include it in KIP
On Thu, 28 Dec 2560 at 03:07 Matthias J. Sax wrote:
> @Matthias: just wanted to follow up on your question:
>
> I wanted to double check. If I understand the proposal, it would
> repl
@Matthias: just wanted to follow up on your question:
I wanted to double check. If I understand the proposal, it would replace
the explicit name with a name that is dynamically generated using the
AtomicInteger index. Would this affect the naming of any internally
generated top
Hi all,
I would like to start the vote thread tomorrow, feel free to ask if there
is any concern.
Thank you
On Thu, 7 Dec 2560 at 19:22 Panuwat Anawatmongkhon <
panuwat.anawatmongk...@gmail.com> wrote:
>
> Yes, Matthias.
> The object will be used togerther with function table and function stream.
Yes, Matthias.
The object will be used togerther with function table and function stream.
I didn’t see how this will affect other part but if you do, please explain
more on how this will affect generated topic name.
Thank you
Panuwat
On Thu, 7 Dec 2560 at 00:01 Matthias Margush
wrote:
> Hi.
>
>
Hi.
I wanted to double check. If I understand the proposal, it would replace
the explicit name with a name that is dynamically generated using the
AtomicInteger index. Would this affect the naming of any internally
generated topics?
On Wed, Dec 6, 2017 at 7:59 AM Panuwat Anawatmongkhon <
panuwat.
Thanks Bill.
I can't think of reason to keep the old method too so if there is no
further discussion by tomorrow, I would like to start the vote thread.
On Tue, Dec 5, 2017 at 10:38 PM, Bill Bejeck wrote:
> Hi Panuwat,
>
> Thanks for the KIP, overall looks good to me.
>
> I want to play the dev
Hi Panuwat,
Thanks for the KIP, overall looks good to me.
I want to play the devil's advocate for a second and ask do we want to keep
the older method with the extra parameters vs. deprecation?
Although ATM I can't think of a good reason to keep the old method with the
extra parameters.
Thanks,
Fine by me.
On Tue, Dec 5, 2017 at 2:45 AM, Panuwat Anawatmongkhon <
panuwat.anawatmongk...@gmail.com> wrote:
> Thank you, Matthias.
>
> Ted,
> How about this.
>
> String globalTopicName = "testGlobalTopic";
> String globalStoreName = "testAddGlobalStore";
> final StreamsBuilder builder = new Str
Thank you, Matthias.
Ted,
How about this.
String globalTopicName = "testGlobalTopic";
String globalStoreName = "testAddGlobalStore";
final StreamsBuilder builder = new StreamsBuilder();
final KeyValueStoreBuilder globalStoreBuilder =
EasyMock.createNiceMock(KeyValueStoreBuilder.class);
EasyMock.e
Panuwat,
Thanks a lot for the KIP!
Just one nit: `does not follow provide a good` -> spelling: remove
`follow` ?
Otherwise, looks good to me.
-Matthias
On 12/4/17 10:49 AM, Ted Yu wrote:
> Looks like you're implying logic similar to this:
>
> public synchronized GlobalKTable globalTab
Looks like you're implying logic similar to this:
public synchronized GlobalKTable globalTable(final String
topic,
final
Consumed consumed) {
StreamsBuilder is returned instead of GlobalKTable.
Can you add code snippet showing
What i am thinking right now is using the same approach as
org.apache.kafka.streams.kstream.internals.InternalStreamsBuilder#globalTable
On Mon, 4 Dec 2560 at 23:10 Ted Yu wrote:
> Can you describe how sourceName is inferred based on the new API ?
>
> Please fill out JIRA number.
>
> BTW here is
Can you describe how sourceName is inferred based on the new API ?
Please fill out JIRA number.
BTW here is the URL for the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+StreamsBuilder%23addGlobalStore
On Mon, Dec 4, 2017 at 7:39 AM, Panuwat Anawatmongkhon <
panuwat.
Hi all,
I created a KIP.
https://cwiki.apache.org/confluence/display/KAFKA/KIP233%3A+Simplify+StreamsBuilder%23addGlobalStore
Cheers,
Benz
16 matches
Mail list logo
