Panuwat, Thanks a lot for the KIP!
Just one nit: `does not follow provide a good` -> spelling: remove
`follow` ?
Otherwise, looks good to me.
-Matthias
On 12/4/17 10:49 AM, Ted Yu wrote:
> Looks like you're implying logic similar to this:
>
> public synchronized <K, V> GlobalKTable<K, V> globalTable(final String
> topic,
>
> final
> Consumed<K, V> consumed) {
>
>
> StreamsBuilder is returned instead of GlobalKTable.
>
>
> Can you add code snippet showing how the new API is used ?
>
>
> On Mon, Dec 4, 2017 at 10:09 AM, Panuwat Anawatmongkhon <
> panuwat.anawatmongk...@gmail.com> wrote:
>
>> What i am thinking right now is using the same approach as
>> org.apache.kafka.streams.kstream.internals.InternalStreamsBuilder#
>> globalTable
>>
>> On Mon, 4 Dec 2560 at 23:10 Ted Yu <yuzhih...@gmail.com> wrote:
>>
>>> Can you describe how sourceName is inferred based on the new API ?
>>>
>>> Please fill out JIRA number.
>>>
>>> BTW here is the URL for the KIP:
>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+
>> StreamsBuilder%23addGlobalStore
>>>
>>> On Mon, Dec 4, 2017 at 7:39 AM, Panuwat Anawatmongkhon <
>>> panuwat.anawatmongk...@gmail.com> wrote:
>>>
>>>> Hi all,
>>>> I created a KIP.
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP233%3A+Simplify+
>>>> StreamsBuilder%23addGlobalStore
>>>>
>>>> Cheers,
>>>> Benz
>>>>
>>>
>>
>
signature.asc
Description: OpenPGP digital signature
