Re: [DISCUSS] KIP-172 Add regular-expression topic support for sink connector

2017-07-10 Thread Ewen Cheslack-Postava
Kenji, This looks great. I'd probably make a couple of minor changes for clarity: 1. In public interfaces section, I'd either round it out with client configuration via REST proxy or just simplify to "Adds an optional field to sink connector configuration" 2. Maybe clarify that if you specify bot

Re: [DISCUSS] KIP-172 Add regular-expression topic support for sink connector

2017-06-27 Thread 郭健
Great idea! We have similar demands so I have implemented this function in a MySQL source connector, see: https://github.com/Aegeaner/kafka-connector-mysql/blob/master/src/main/java/org/apache/kafka/connect/mysql/EventRecordFactory.java#L347 Thanks, Aegeaner On 6/27/17, 11:45, "Kenji Hayashida"

[DISCUSS] KIP-172 Add regular-expression topic support for sink connector

2017-06-26 Thread Kenji Hayashida
Hi all, I have raised a new KIP at https://cwiki.apache.org/confluence/display/KAFKA/KIP+172%3A+Add+regular-expression+topic+support+for+sink+connector The corresponding JIRA is at https://issues.apache.org/jira/browse/KAFKA-3073 I look forward to your feedback. Thanks, Kenji Hayashida