Kenji, This looks great. I'd probably make a couple of minor changes for clarity:
1. In public interfaces section, I'd either round it out with client configuration via REST proxy or just simplify to "Adds an optional field to sink connector configuration" 2. Maybe clarify that if you specify both you'll throw a ConfigException. 3. For proposed changes part #4, maybe specify that this just gets passed to the underlying consumer. This basically passes any details that should be specified around the performance of the feature, how fast it sees new topics, etc, can be passed off to the consumer docs. 4. Fill out the compatibility section, which should basically just say that since this is only adding a new config, there are no compatibility concerns. (Technically there's is a risk if some connector uses topic.regex already, but I highly doubt that will be an issue. These are all pretty minor details just to clean up and finalize this, from my perspective this is probably ready for vote after these tweaks since this should be a pretty uncontroversial KIP. -Ewen On Tue, Jun 27, 2017 at 12:57 AM, 郭健 <guo.j...@immomo.com> wrote: > Great idea! We have similar demands so I have implemented this function in > a MySQL source connector, see: > https://github.com/Aegeaner/kafka-connector-mysql/blob/ > master/src/main/java/org/apache/kafka/connect/mysql/ > EventRecordFactory.java#L347 > > Thanks, > Aegeaner > > > On 6/27/17, 11:45, "Kenji Hayashida" <kenji12...@gmail.com> wrote: > > Hi all, > > I have raised a new KIP at > https://cwiki.apache.org/confluence/display/KAFKA/KIP+ > 172%3A+Add+regular-expression+topic+support+for+sink+connector > > The corresponding JIRA is at https://issues.apache.org/ > jira/browse/KAFKA-3073 > > I look forward to your feedback. > > Thanks, > Kenji Hayashida > > >
