Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-23 Thread Chia-Ping Tsai
hi Bruno > My assumption was that public APIs are about how to use Kafka, not about how to build it. I've seen many CI pipelines for Kafka-related systems relying on Kafka's Gradle commands, so I'm hesitant to break the build command abruptly. This is also why we didn't remove ./gradlewAll ( http

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-23 Thread Bruno Cadonna
Hi Chia-Ping, I have a question regarding the following comment: > CP1: Gradle commands are part of the public API, so in which Kafka version should we announce the deprecation of Gradle commands? It is the first time I hear that Gradle commands are part of the public API. Could you elabora

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Vince Rose
Also worth mentioning - Develocity does have support for caching and build analysis with Bazel - https://gradle.com/gradle-enterprise-solutions/bazel-build-system/ I don't know about Gradle's partnership with ASF, Are they requiring Kafka to use Gradle to get the cache and analysis UI? On Fri, Nov

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Farid Zakaria
On Fri, Nov 22, 2024 at 10:47 AM David Arthur wrote: > > Thanks for the KIP, Vince and Farid! > > A few comments on the KIP > > DA1: The motivation mentioned historical build times in Apache Kafka, but > we should really just consider the current situation. I would like to see > the motivation/bac

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread David Arthur
Thanks for the KIP, Vince and Farid! A few comments on the KIP DA1: The motivation mentioned historical build times in Apache Kafka, but we should really just consider the current situation. I would like to see the motivation/background make a clearer distinction between trunk builds (no caching)

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Vince Rose
Bringing fzaka...@confluent.io into the discussion. On Fri, Nov 22, 2024 at 10:01 AM Viktor Somogyi-Vass wrote: > Hi Vincent > > I would also like to say that I'm not an expert in Bazel either. Generally > I think it's good to reduce build and test times in every infra. While > reading up on Baz

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Farid Zakaria
Hi! I'm one of the co-authors of the KIP. Let me answer a few questions (the thread is a bit long so I won't opt for inline). * Many of the comments touch on the aspect that having multiple BUILD files looks like to be higher cognitive requirement than what is currently required by Gradle which s

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Vince Rose
On Fri, Nov 22, 2024 at 10:01 AM Viktor Somogyi-Vass wrote: > Hi Vincent > > I would also like to say that I'm not an expert in Bazel either. Generally > I think it's good to reduce build and test times in every infra. While > reading up on Bazel, it seems like it's most useful in monolithic code

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Viktor Somogyi-Vass
Hi Vincent I would also like to say that I'm not an expert in Bazel either. Generally I think it's good to reduce build and test times in every infra. While reading up on Bazel, it seems like it's most useful in monolithic code bases, such as Confluent as you mentioned in the KIP (so it's not a co

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-22 Thread Gaurav Narula
Thanks for the KIP Vince and Farid! Glad to see Bazel being considered for Kafka and really impressive work on the demo repository! From the benchmarks, I'd imagine the build would only get faster once BUILD.bazel files don't glob the entire source/test set for a module but are more fine grain

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-21 Thread Chia-Ping Tsai
hi Vince Thanks for introducing this interesting KIP! I'm not an expert in Bazel, so please be patient with my potentially odd questions: CP0: Can Bazel help simplify build.gradle (currently around 3826 lines)? CP1: Gradle commands are part of the public API, so in which Kafka version should w

[DISCUSS] KIP-1115: Bazel Builds

2024-11-21 Thread Vince Rose
Hey devs, I want to start a discussion about introducing Bazel as a build system for Apache Kafka. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1115%3A+Bazel+Builds -Vince