t. There will not be
>> > > that many instances I'm sure, so if the consensus is to deprecate the
>> > > old constructor, that's fine with me.
>> > >
>> > >
>> > > From: Sophie Blee-Goldman
>
a fair point. There will not be
> > > that many instances I'm sure, so if the consensus is to deprecate the
> > > old constructor, that's fine with me.
> > >
> > > ____________
> > > From: Sophie Blee-Goldman
>
> > From: Sophie Blee-Goldman
> > Sent: 28 September 2024 22:56
> > To: dev@kafka.apache.org
> > Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with
> > nextOffsets to ConsumerRecords
> >
> > @Andrew do
s. But you make a fair point. There will not be
> > that many instances I'm sure, so if the consensus is to deprecate the
> > old constructor, that's fine with me.
> >
> > ________________________
> > From: Sophie Blee-Goldman
> &g
nt: 28 September 2024 22:56
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with
> nextOffsets to ConsumerRecords
>
> @Andrew do you mean user tests might create ConsumerRecords, or are you
> concerned about AK tests?
>
> I guess Ali
56
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets
to ConsumerRecords
@Andrew do you mean user tests might create ConsumerRecords, or are you
concerned about AK tests?
I guess Alieh would be the one to implement this, so I'll leave it up to
her to
's making work.
Thanks,
Andrew
From: Matthias J. Sax
Sent: 27 September 2024 18:36
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with
nextOffsets to ConsumerRecords
Thanks for the KIP Alieh.
Deprecating the existing constructo
the tests, but it's making work.
>
> Thanks,
> Andrew
>
>
> From: Matthias J. Sax
> Sent: 27 September 2024 18:36
> To: dev@kafka.apache.org
> Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with
> nextOffsets
ias J. Sax
Sent: 27 September 2024 18:36
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets
to ConsumerRecords
Thanks for the KIP Alieh.
Deprecating the existing constructor won't break anybody atm, right? We
don't remove the constru
constructor too.
Thanks,
Andrew
From: Alieh Saeedi
Sent: 27 September 2024 09:09
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets
to ConsumerRecords
Thank you, Bill and Sophie.
@Bill: You are right. I
Hi Alieh,
Thanks for the KIP. Looks like a nice addition to me. I prefer not deprecating
the existing
constructor too.
Thanks,
Andrew
From: Alieh Saeedi
Sent: 27 September 2024 09:09
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-1094 Add a new
Thank you, Bill and Sophie.
@Bill: You are right. I updated the KIP.
@Sophie: Yes, it was also our concern, but we thought we should keep the
current constructor in order to not break the user's code who has called
this constructor in their code.
Thanks,
Alieh
On Fri, Sep 27, 2024 at 1:07 AM Sop
Should we deprecate the old constructor to make sure that all info gets
passed in when creating a ConsumerRecords instance?
On Thu, Sep 26, 2024 at 3:37 PM Bill Bejeck wrote:
> Hi Alieh,
>
> Thanks for the KIP, it will be very useful to Kafka Streams.
> I have one comment. In the "Proposed Chan
Hi Alieh,
Thanks for the KIP, it will be very useful to Kafka Streams.
I have one comment. In the "Proposed Changes" section, you mention the
"The `nextOffsets` object contains the next offset and the last leader
epoch per partition".
If understand the KIP correctly, it should be something along
Hi all,
I would like to open a discussion for KIP-1094: Add a new constructor
method with `nextOffsets` to `ConsumerRecords`.
You can find the detailed proposal here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1094%3A+Add+a+new+constructor+method+with+nextOffsets+to+ConsumerRecords
I
15 matches
Mail list logo
