Hi Alieh, Thanks for the KIP, it will be very useful to Kafka Streams. I have one comment. In the "Proposed Changes" section, you mention the "The `nextOffsets` object contains the next offset and the last leader epoch per partition". If understand the KIP correctly, it should be something along the lines of "The `nextOffsets` method returns a map of `TopicPartition` to `OffsetAndMetadata` objects and `OffsetAndMetadata` contains the next offset and the last leader epoch per partition"
Other than that, the KIP LGTM. Thanks, Bill On Wed, Sep 25, 2024 at 7:43 AM Alieh Saeedi <asae...@confluent.io.invalid> wrote: > Hi all, > > I would like to open a discussion for KIP-1094: Add a new constructor > method with `nextOffsets` to `ConsumerRecords`. > > You can find the detailed proposal here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1094%3A+Add+a+new+constructor+method+with+nextOffsets+to+ConsumerRecords > > I look forward to your feedback and suggestions. > > Thanks, > Alieh >
