Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-20 Thread Jun Rao
Hi, Andrew, Thanks for the reply. LGTM. Jun On Sat, Nov 18, 2023 at 12:28 AM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi Jun, > This is an example of inconsistency between the tools. I do agree that > it would be nice to have `--list` on the `kafka-client-metrics.sh` tool.

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-18 Thread Andrew Schofield
Hi Jun, This is an example of inconsistency between the tools. I do agree that it would be nice to have `--list` on the `kafka-client-metrics.sh` tool. However, `kafka-config.sh` has the convention that `--describe` with no entity name supplied first gets a list of all the entities, and then descri

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-17 Thread Jun Rao
Hi, Andrew, Thanks for the reply. KIP-714 proposes to use the following command for listing metric subscriptions. kafka-client-metrics.sh --bootstrap-server $BROKERS --describe kafka-configs.sh --bootstrap-server $BROKERS --describe --entity-type client-metrics Should we use --list instead to be

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-17 Thread Andrew Schofield
Hi Jason, Thanks for your comments. 1) Any broker can handle this API, so admin clients will choose a node randomly. 2) I was following the RPCs for configs which support controller and broker. However, looking at all of the List… and Describe… RPCs, I see that the majority are broker-only. I ha

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Andrew Schofield
Hi Jun, KIP-714 includes `kafka-client-metrics.sh` which provides an easier way to work with client metrics config than the general-purpose `kafka-configs.sh`. So, this new RPC will actually be used in the `kafka-client-metrics.sh` tool. Thanks, Andrew > On 16 Nov 2023, at 18:00, Jun Rao wrote

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Jason Gustafson
Hey Andrew, Thanks for the KIP. Just clarifying a couple small details. 1. I assume any broker can handle this API, so admin clients will choose a node randomly? 2. Does the controller need to support this API? If not, we can drop "controller" from "listeners." Thanks, Jason On Thu, Nov 16, 202

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Jun Rao
Hi, Andrew, Thanks for the KIP. Just one comment. Should we extend ConfigCommand or add a new tool to list client metrics? Thanks, Jun On Tue, Nov 7, 2023 at 9:42 AM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I would like to start discussion of a small KIP which fill

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-07 Thread Adam Bellemare
Let's take this moment to celebrate the creation of KIP-1000! On Tue, Nov 7, 2023 at 3:49 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I would like to start discussion of a small KIP which fills a gap in the > administration of client metrics configuration. > > > https:

[DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-07 Thread Andrew Schofield
Hi, I would like to start discussion of a small KIP which fills a gap in the administration of client metrics configuration. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1000%3A+List+Client+Metrics+Configuration+Resources Thanks, Andrew