Hi Jun, This is an example of inconsistency between the tools. I do agree that it would be nice to have `--list` on the `kafka-client-metrics.sh` tool. However, `kafka-config.sh` has the convention that `--describe` with no entity name supplied first gets a list of all the entities, and then describes them all (ConfigCommand.scala/describeResourceConfig). `kafka-topics.sh` also describes all topics if you use `—describe` with no topic name.
So, I have added a new `--list` option to `kafka-client-metrics.sh` in this KIP. The `--describe` option remains as before - if you supply a name, it describes just that resource, and if you do not, it describes all resources. Thanks, Andrew > On 17 Nov 2023, at 22:13, Jun Rao <j...@confluent.io.INVALID> wrote: > > Hi, Andrew, > > Thanks for the reply. KIP-714 proposes to use the following command for > listing metric subscriptions. > > kafka-client-metrics.sh --bootstrap-server $BROKERS --describe > kafka-configs.sh --bootstrap-server $BROKERS --describe --entity-type > client-metrics > > Should we use --list instead to be more consistent with other tools like > (kafka-topics)? > > Thanks, > > Jun > > On Thu, Nov 16, 2023 at 10:23 AM Andrew Schofield < > andrew_schofield_j...@outlook.com> wrote: > >> Hi Jun, >> KIP-714 includes `kafka-client-metrics.sh` which provides an easier way to >> work with client metrics config >> than the general-purpose `kafka-configs.sh`. So, this new RPC will >> actually be used in the >> `kafka-client-metrics.sh` tool. >> >> Thanks, >> Andrew >> >>> On 16 Nov 2023, at 18:00, Jun Rao <j...@confluent.io.INVALID> wrote: >>> >>> Hi, Andrew, >>> >>> Thanks for the KIP. Just one comment. >>> >>> Should we extend ConfigCommand or add a new tool to list client metrics? >>> >>> Thanks, >>> >>> Jun >>> >>> On Tue, Nov 7, 2023 at 9:42 AM Andrew Schofield < >>> andrew_schofield_j...@outlook.com> wrote: >>> >>>> Hi, >>>> I would like to start discussion of a small KIP which fills a gap in the >>>> administration of client metrics configuration. >>>> >>>> >>>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1000%3A+List+Client+Metrics+Configuration+Resources >>>> >>>> Thanks, >>>> Andrew >> >>
