Thanks for taking the time to explain David! That makes sense
I also saw your KIP about using the merge queue so it sounds like we have a
plan here
On Wed, Jan 22, 2025 at 6:07 PM David Arthur wrote:
> It's a good question, Sophie. The answer is not entirely obvious.
>
> The build cache basical
It's a good question, Sophie. The answer is not entirely obvious.
The build cache basically just loads the latest cache produced by the trunk
builds. However, there are un-built commits on trunk quite frequently.
These are commits which are being built by the current CI run, or are
waiting for the
>
> This change will help with test time since it will increase cache hits for
> the Gradle test tasks. For example, if your PR only changes streams code
> you should ideally not see other modules get re-tested (unless they are
> downstream dependencies of :streams).
Ok thanks for clarifying. But
This change will help with test time since it will increase cache hits for
the Gradle test tasks. For example, if your PR only changes streams code
you should ideally not see other modules get re-tested (unless they are
downstream dependencies of :streams).
I've learned from ASF Infra that merge q
David, just to make sure I understand, are you saying this will help with
the actual test runtime, or only the compile time of the build? Just
wondering because I've personally never found the compile times to be a
roadblock, since the test times are so long. If this change only speeds up
compiling
Thanks for raising the correctness aspect, José. We currently have a
compromise solution since PRs are not required to be up-to-date with trunk
before merging. Basically, as long as a PR does not have conflicts and has
passing tests, it can be merged. That's the situation today. We rely on the
trun
Thanks David.
On Fri, Jan 17, 2025 at 11:55 AM David Arthur wrote:
>
> I have a simple patch which changes our PRs to build the HEAD of the PR
> rather than the merge ref.
>
> https://github.com/apache/kafka/pull/18449
We shouldn't sacrifice correctness for performance. The tests need to
run aga
Hey folks, I have a PR up that changes which commit we build in our PRs.
Currently, our PRs are building a synthetic "merge" commit which does not
actually exist in the repo. This is done by taking the base branch and
merging the PR into it. The benefit of this approach is that you will see
the re
