Thanks David.

On Fri, Jan 17, 2025 at 11:55 AM David Arthur <mum...@gmail.com> wrote:
>
> I have a simple patch which changes our PRs to build the HEAD of the PR
> rather than the merge ref.
>
> https://github.com/apache/kafka/pull/18449

We shouldn't sacrifice correctness for performance. The tests need to
run against what has been committed to the trunk branch. Otherwise the
onus is on the contributor and committer to make sure that the PR
branch is up to date enough.

I never found that the limiting factor in merging a PR to Apache Kafka
is the build times. The limiting factor is committer review time.

Thanks,
-- 
-José

Reply via email to