.java#L62
> into 2 parts and check tasks.get(keyTaskId) separately. If it is null,
> we can throw an InvalidPartitionException. WDYS?
> >
> > Thanks,
> > Navinder
> >
> >
> > On Saturday, 22 February, 2020, 06:22:14 am IST, Vito Jeng
> wrote:
> >
&
>
>
> On Wednesday, February 5, 2020, 12:17 AM, Matthias J. Sax <
> mj...@apache.org> wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Thanks Vito!
>
> That makes sense to me.
>
>
> On 2/1/20 11:29 PM, Vito Jeng wrote:
> > Hi, f
welcome.
Thanks Matthias for the reminder.
---
Vito
On Thu, Jan 23, 2020 at 2:13 PM Vito Jeng wrote:
> Got it, thanks Matthias.
>
> ---
> Vito
>
>
> On Thu, Jan 23, 2020 at 1:31 PM Matthias J. Sax
> wrote:
>
>> Thanks Vito.
>>
>> I am also ok with e
>>
> >> On Tue, Jan 14, 2020 at 9:41 AM Navinder Brar
> >> wrote:
> >>
> >>> +1 (non-binding) With a small comment which was mentioned by Vinoth as
> >>> well. Did we fix on the flag for StreamsRebalancingException, I don't
Got it, thanks Matthias.
---
Vito
On Thu, Jan 23, 2020 at 1:31 PM Matthias J. Sax
wrote:
> Thanks Vito.
>
> I am also ok with either name. Just a personal slight preference, but
> not a important.
>
>
> -Matthias
>
> On 1/21/20 6:52 PM, Vito Jeng wrote:
> > Th
ateStoreNotAvailableException`, because this exception is thrown if
> Streams is in state PENDING_SHUTDOWN / NOT_RUNNING / ERROR ?
>
>
>
> -Matthias
>
> On 1/17/20 9:56 PM, John Roesler wrote:
> > Thanks, Vito. I've just cast my vote.
> > -John
> >
> >
Hi, folks,
Just update the KIP, please take a look.
Thanks!
---
Vito
On Fri, Jan 17, 2020 at 9:12 AM Vito Jeng wrote:
> Thanks Bill, John and Matthias. Glad you guys joined this discussion.
> I got a lot out of the discussion.
>
> I would like to update KIP-216 base on John
tion app. On the other
> >> hand, considering the exception fatal has a good chance of avoiding a
> >> frustrating debug session if you just forgot to call start.
> >>
> >> Nevertheless, if we omit the categorization, it’s moot.
> >>
> >> It would be easy t
--
It looks reasonable. I'm fine with omitting the categorization but not very
sure it is a good choice.
Does any other folks provide opinion?
Hi, folks,
Just update the KIP-216, please take a look.
---
Vito
On Thu, Jan 16, 2020 at 6:35 AM Vito Jeng wrote:
>
> Hi, folks,
>
> Tha
> > >
> > > For both cased, the state is `PENDING_SHUTDOWN / NOT_RUNNING / ERROR`
> > > and thus, for a user point of view, why does it matter if the store is
> > > closed on not? I don't understand why/how this information would be
> > > useful? Do
Hi, all,
I would like to start the vote for KIP-216.
Currently, IQ throws InvalidStateStoreException for any types of error.
With this KIP, user can distinguish different types of error.
KIP is here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-216%3A+IQ+should+throw+different+exception
if the
> > state store is closed on not -- I can't query it anyway? Maybe I miss
> > something thought?
> >
> >
> > -Matthias
> >
> >
> > On 11/3/19 6:07 PM, Vito Jeng wrote:
> > > Sorry for the late reply, thanks for the review.
> > >
&
ference
> > to `StreamThreadRebalancingException` that allows for "blind" retries
> > that either resolve (if the store is still on the same instance after
> > rebalancing finishes, or changes to `StateStoreMigratedException` if the
> > store was migrated away d
My bad. The short link `https://shorturl.at/CDNT9`
<https://shorturl.at/CDNT9> seems incorrect.
Please use the following instead: https://shorturl.at/bkKQU
---
Vito
On Fri, Aug 9, 2019 at 10:53 AM Vito Jeng wrote:
> Thanks, Matthias!
>
> > About `StreamThreadNotStartedExc
; > check if the store name is valid or not.
> >
> >
> >
> >> Should we remove `StreamThreadNotRunningException` and throw
> >> `FatalStateStoreException` directly ?
> >
> > I would keep both, because `FatalStateStoreException` is not very
> > descrip
Hi, Mattias,
Just completed the modification of KIP, please take a look when you are
available.
---
Vito
On Wed, Jul 3, 2019 at 9:07 PM Vito Jeng wrote:
> Hi, Matthias,
>
> This is second part.
>
> > For the internal exceptions:
> >
> > `StateStoreClosedExceptio
xception` directly?
>
>
> Last point: Why do we need to add?
>
> > QueryableStoreType#setStreams(KafkaStreams streams);
>
> John asked this question already and you replied to it. But I am not
> sure what your answer means. Can you explain it in more detail?
gt;
>
> Last point: Why do we need to add?
>
> > QueryableStoreType#setStreams(KafkaStreams streams);
>
> John asked this question already and you replied to it. But I am not
> sure what your answer means. Can you explain it in more detail?
>
>
>
> Thanks for your pat
migrated or an
unknown state store.
Any thoughts?
---
Vito
On Sun, Nov 11, 2018 at 5:31 PM Vito Jeng wrote:
> Hi, Matthias,
>
> Sorry for the late reply.
>
> > I am wondering what the semantic impact/change is, if we introduce
> > `RetryableStateStoreException` and
ue?
> >
> >> will be wrapped to StateStoreMigratedException or
> StateStoreNotAvailableException later.
> >
> > Also, can you clarify the cases (ie, when will it be wrapped with the
> > one or the other)?
> >
> >
> > I am also wondering, if we should introduc
Just open a PR for further discussion:
https://github.com/apache/kafka/pull/5814
Any suggestion is welcome.
Thanks!
---
Vito
On Thu, Oct 11, 2018 at 12:14 AM vito jeng wrote:
> Hi John,
>
> Thanks for reviewing the KIP.
>
> > I didn't follow the addition
gt; > >>>>
> > > >>>> StreamThreadStateStoreProvider#stores() will throw
> > > >>>> StreamThreadNotRunningException when StreamThread state is not
> > > >> RUNNING. The
> > > >>>> user can retry until Kafk
> The last one is tricky and could also be merged into one of the first
> two, depending if you want to argue that it's retryable or not. (Just
> food for though -- not sure what others think.)
>
>
>
> -Matthias
>
> On 6/22/18 8:06 AM, vito jeng wrote:
> > Ma
+1
---
Vito
On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee wrote:
> +1. (Non-binding)
>
> On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax
> wrote:
>
> > Thanks a lot for the KIP.
> >
> > +1 (binding)
> >
> >
> > -Matthias
> >
> >
> > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > Hi All,
> >
Thanks for the KIP!
+1(non-binding)
---
Vito
On Sat, Jul 7, 2018 at 11:29 AM, Chia-Ping Tsai wrote:
> hi Ismael
>
> > I think we should be thinking about
> > https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
>
> you are right. KAFKA-6923 and KAFKA-6161 are the keys to compl
a retryable
> error?
>
> One more nits: ReadOnlyWindowStore got a new method #fetch(K key, long
> time); that should be added
>
>
> Overall I like the KIP but some details are still unclear. Maybe it
> might help if you open an PR in parallel?
>
>
> -Matthias
>
&g
> This will gently encourage callers to migrate to the new exception and
> > open
> > > the possibility of removing InvalidStateStoreException entirely in a
> > future
> > > release.
> > >
> > > Thanks,
> > > -John
> > &g
r 19, 2018 at 8:58 AM, Matthias J. Sax
> wrote:
>
> > Thanks for clarification! That makes sense to me.
> >
> > Can you update the KIP to make those suggestions explicit?
> >
> >
> > -Matthias
> >
> > On 4/18/18 2:19 PM, vito jeng wrote:
> >
gt;
> -Matthias
>
> On 4/18/18 2:19 PM, vito jeng wrote:
> > Matthias,
> >
> > Thanks for the feedback!
> >
> >> It's up to you to keep the details part in the KIP or not.
> >
> > Got it!
> >
> >> The (incomplete) question was, if
; Can you explain the purpose of the "internal exceptions". It's unclear
> to me atm why they are introduced.
>
>
> -Matthias
>
> On 4/10/18 12:33 AM, vito jeng wrote:
> > Matthias,
> >
> > Thanks for the review.
> > I reply separately in
toreClosed` a fatal or retryable exception ?
>
>
I apologize for not well written parts. I tried to modify some code in the
recent period and modify the KIP.
The modification is now complete. Please look again.
>
>
> -Matthias
>
>
> On 2/21/18 5:15 PM, vito jeng wrote:
&g
Matthias,
Sorry for not response these days.
I just finished it. Please have a look. :)
---
Vito
On Wed, Feb 14, 2018 at 5:45 AM, Matthias J. Sax
wrote:
> Is there any update on this KIP?
>
> -Matthias
>
> On 1/3/18 12:59 AM, vito jeng wrote:
> > Matthias,
>
ase, users need to rediscover the store. For the second
> case, they need to wait until rebalance is finished.
>
> If KafkaStreams is in state ERROR, PENDING_SHUTDOWN, or NOT_RUNNING,
> uses cannot query at all and thus they cannot rediscover or retry.
>
> Does this make sense?
>
gt; And then from there we should list what are the possible internal
> > exceptions ever thrown in those APIs in the call trace, and which
> > exceptions should be wrapped to what others, and which ones should be
> > handled without re-throwing, and which ones should not be
Thank you for your attention to this KIP and assistance.
---
Vito
On Wed, Dec 6, 2017 at 2:35 PM, Matthias J. Sax
wrote:
> Thanks for the info. There is no hurry. Was just curious :)
>
> -Matthias
>
>
> On 12/5/17 7:34 PM, vito jeng wrote:
> > Matthias,
> >
&g
>
> On 11/5/17 6:11 PM, vito jeng wrote:
> > Thanks, Guozhang and Matthias. Your comments very useful for me.
> >
> > I'll update KIP and keep going on.
> >
> >
> >
> > ---
> > Vito
> >
> > On Sun, Nov 5, 2017 at 12:30 AM, Matt
ers, and which ones should be
> > handled without re-throwing, and which ones should not be wrapped at all
> > but directly thrown to user's face.
> >
> > Guozhang
> >
> >
> > On Wed, Nov 1, 2017 at 11:09 PM, vito jeng wrote:
> >
> >>
Hi,
I'd like to start discuss KIP-216:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-216%3A+IQ+should+throw+different+exceptions+for+different+errors
Please have a look.
Thanks!
---
Vito
38 matches
Mail list logo
