Re: [DISCISS] KIP-860: Add client-provided option to guard against unintentional replication factor change during partition reassignments

2022-08-08 Thread Vikas Singh
gt; appropriate?) > > > > The other option is to continue on but not actually protect replication > > factor. If we do this, at minimum we'd need to rename the flag something > > like "try to protect replication factor" to make it clear that it's > > bes

Re: [DISCISS] KIP-860: Add client-provided option to guard against unintentional replication factor change during partition reassignments

2022-08-04 Thread Vikas Singh
Thanks Stanislav for the KIP. Seems like a reasonable proposal, preventing users from accidentally altering the replica set under certain conditions. I have couple of comments: > In the case of an already-reassigning partition being reassigned again, the validation compares the targetReplicaSet s

Re: [DISCUSS] KIP-660: Pluggable ReplicaPlacer

2022-05-09 Thread Vikas Singh
Hi Mickael, It's a nice proposal. It's appealing to have a pluggable way to override default kafka placement decisions, and the motivation section lists some of them. Here are few comments: * The motivation section has "When adding brokers to a cluster, Kafka currently does not necessarily place

permission to create KIP

2022-01-26 Thread Vikas Singh
Hi, Sending this mail as per https://cwiki.apache.org/confluence/display/kafka/kafka+improvement+proposals to request permission to be able to create KIP and contribute to AK. confluence wiki id: vikasconfluent jira id: vikasconfluent Thanks, Vikas

[jira] [Created] (KAFKA-13517) Add ConfigurationKeys to ConfigResource class

2021-12-07 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-13517: --- Summary: Add ConfigurationKeys to ConfigResource class Key: KAFKA-13517 URL: https://issues.apache.org/jira/browse/KAFKA-13517 Project: Kafka Issue Type

[jira] [Created] (KAFKA-13432) ApiException should provide a way to capture stacktrace

2021-11-03 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-13432: --- Summary: ApiException should provide a way to capture stacktrace Key: KAFKA-13432 URL: https://issues.apache.org/jira/browse/KAFKA-13432 Project: Kafka Issue

[jira] [Created] (KAFKA-10531) KafkaBasedLog can sleep for negative values

2020-09-28 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-10531: --- Summary: KafkaBasedLog can sleep for negative values Key: KAFKA-10531 URL: https://issues.apache.org/jira/browse/KAFKA-10531 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-10175) MetadataCache::getCluster returns null for offline replicas

2020-06-16 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-10175: --- Summary: MetadataCache::getCluster returns null for offline replicas Key: KAFKA-10175 URL: https://issues.apache.org/jira/browse/KAFKA-10175 Project: Kafka

[jira] [Created] (KAFKA-9370) Return UNKNOWN_TOPIC_OR_PARTITION if topic deletion is in progress

2020-01-06 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-9370: -- Summary: Return UNKNOWN_TOPIC_OR_PARTITION if topic deletion is in progress Key: KAFKA-9370 URL: https://issues.apache.org/jira/browse/KAFKA-9370 Project: Kafka

[jira] [Created] (KAFKA-9330) Calling AdminClient.close in the AdminClient completion callback causes deadlock

2019-12-23 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-9330: -- Summary: Calling AdminClient.close in the AdminClient completion callback causes deadlock Key: KAFKA-9330 URL: https://issues.apache.org/jira/browse/KAFKA-9330 Project

[jira] [Created] (KAFKA-9329) KafkaController::replicasAreValid should return error

2019-12-23 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-9329: -- Summary: KafkaController::replicasAreValid should return error Key: KAFKA-9329 URL: https://issues.apache.org/jira/browse/KAFKA-9329 Project: Kafka Issue Type

[jira] [Created] (KAFKA-9265) kafka.log.Log instances are leaking on log delete

2019-12-03 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-9265: -- Summary: kafka.log.Log instances are leaking on log delete Key: KAFKA-9265 URL: https://issues.apache.org/jira/browse/KAFKA-9265 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-8988) Replace CreatePartitions request/response with automated protocol

2019-10-04 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-8988: -- Summary: Replace CreatePartitions request/response with automated protocol Key: KAFKA-8988 URL: https://issues.apache.org/jira/browse/KAFKA-8988 Project: Kafka

[jira] [Resolved] (KAFKA-8457) Remove Log dependency from Replica

2019-06-17 Thread Vikas Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Singh resolved KAFKA-8457. Resolution: Fixed Fixed in commit 57baa4079d9fc14103411f790b9a025c9f2146a4 > Remove

[jira] [Created] (KAFKA-8525) Make log in Partion non-optional

2019-06-11 Thread Vikas Singh (JIRA)
Vikas Singh created KAFKA-8525: -- Summary: Make log in Partion non-optional Key: KAFKA-8525 URL: https://issues.apache.org/jira/browse/KAFKA-8525 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-8457) Remove Log dependency from Replica

2019-05-31 Thread Vikas Singh (JIRA)
Vikas Singh created KAFKA-8457: -- Summary: Remove Log dependency from Replica Key: KAFKA-8457 URL: https://issues.apache.org/jira/browse/KAFKA-8457 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-8341) AdminClient should retry coordinator lookup after NOT_COORDINATOR error

2019-05-24 Thread Vikas Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Singh resolved KAFKA-8341. Resolution: Fixed fixed in commit 46a02f3231cd6d340c622636159b9f59b4b3cb6e > AdminClient sho

[jira] [Created] (KAFKA-8398) NPE when unmapping files after moving log directories using AlterReplicaLogDirs

2019-05-20 Thread Vikas Singh (JIRA)
Vikas Singh created KAFKA-8398: -- Summary: NPE when unmapping files after moving log directories using AlterReplicaLogDirs Key: KAFKA-8398 URL: https://issues.apache.org/jira/browse/KAFKA-8398 Project