Thanks Stanislav for the KIP. Seems like a reasonable proposal, preventing users from accidentally altering the replica set under certain conditions. I have couple of comments:
> In the case of an already-reassigning partition being reassigned again, the validation compares the targetReplicaSet size of the reassignment to the targetReplicaSet size of the new reassignment and throws if those differ. Can you add more detail to this, or clarify what is targetReplicaSet (for e.g. why not sourceReplicaSet?) and how the target replica set will be calculated? And what about the reassign partitions CLI? Do we want to expose the option there too? Cheers, Vikas On Thu, Jul 28, 2022 at 1:59 AM Stanislav Kozlovski <stanis...@confluent.io> wrote: > Hey all, > > I'd like to start a discussion on a proposal to help API users from > inadvertently increasing the replication factor of a topic through > the alter partition reassignments API. The KIP describes two fairly > easy-to-hit race conditions in which this can happen. > > The KIP itself is pretty simple, yet has a couple of alternatives that can > help solve the same problem. I would appreciate thoughts from the community > on how you think we should proceed, and whether the proposal makes sense in > the first place. > > Thanks! > > KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-860%3A+Add+client-provided+option+to+guard+against+replication+factor+change+during+partition+reassignments > JIRA: https://issues.apache.org/jira/browse/KAFKA-14121 > > -- > Best, > Stanislav >
