Re: Fault Injection

2017-08-22 Thread Timothy Chen
Hi Colin, The Kibosh code is just a README for now, is it going to be published soon? Tim On Tue, Aug 22, 2017 at 11:44 AM, Colin McCabe wrote: > Hi all, > > I've been working on a fault injector for Apache Kafka. The general > idea is to create faults such as network partitions or disk failur

[jira] [Commented] (KAFKA-2339) broker becomes unavailable if bad data is passed through the protocol

2015-07-17 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630981#comment-14630981 ] Timothy Chen commented on KAFKA-2339: - Somehow I can't produce this with kaf

[jira] [Assigned] (KAFKA-2339) broker becomes unavailable if bad data is passed through the protocol

2015-07-17 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned KAFKA-2339: --- Assignee: Timothy Chen > broker becomes unavailable if bad data is passed through

Re: Review Request 36474: Patch for KAFKA-2188

2015-07-15 Thread Timothy Chen
/HighwatermarkPersistenceTest.scala 60cd824 core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d5933 core/src/test/scala/unit/kafka/utils/TestUtils.scala 17e9fe4 Diff: https://reviews.apache.org/r/36474/diff/ Testing --- Thanks, Timothy Chen

[jira] [Commented] (KAFKA-2188) JBOD Support

2015-07-15 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627708#comment-14627708 ] Timothy Chen commented on KAFKA-2188: - Created reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-07-15 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-2188: Attachment: KAFKA-2188.patch > JBOD Support > > > Key

Review Request 36503: Patch for KAFKA-2188

2015-07-15 Thread Timothy Chen
/kafka/utils/TestUtils.scala 17e9fe4c159a29033fe9a287db6ced2fdc3fa9d1 Diff: https://reviews.apache.org/r/36503/diff/ Testing --- Thanks, Timothy Chen

[jira] [Commented] (KAFKA-2188) JBOD Support

2015-07-13 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625910#comment-14625910 ] Timothy Chen commented on KAFKA-2188: - Created reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-07-13 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-2188: Attachment: KAFKA-2188.patch > JBOD Support > > > Key

Review Request 36474: Patch for KAFKA-2188

2015-07-13 Thread Timothy Chen
/HighwatermarkPersistenceTest.scala 60cd8249e6ec03349e20bb0a7226ea9cd66e6b17 core/src/test/scala/unit/kafka/utils/TestUtils.scala 17e9fe4c159a29033fe9a287db6ced2fdc3fa9d1 Diff: https://reviews.apache.org/r/36474/diff/ Testing --- Thanks, Timothy Chen

Re: Guozhang Wang elected to Kafka PMC

2015-06-16 Thread Timothy Chen
Congrats Guozhang!! Tim On Tue, Jun 16, 2015 at 8:19 AM, Aditya Auradkar wrote: > Congrats Guozhang! > > > From: Ashish Singh [asi...@cloudera.com] > Sent: Monday, June 15, 2015 10:53 PM > To: dev@kafka.apache.org > Cc: Jun Rao > Subject: Re: Guozhang Wan

Re: [DISCUSSION] Message Metadata

2014-11-21 Thread Timothy Chen
Hi Guozhang, I don't think that is publically accessible, can you update it to the Kafka wiki? Tim On Fri, Nov 21, 2014 at 5:24 PM, Guozhang Wang wrote: > Hi all, > > I have updated the wiki page ( > https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/Kafka+Enriched+Message+Metadata) > accordin

Re: Welcome Kafka's newest committer

2014-11-19 Thread Timothy Chen
Congrats Guozhang! Tim On Wed, Nov 19, 2014 at 4:05 PM, Neha Narkhede wrote: > Hi everyone, > > I'm very happy to announce that the Kafka PMC has invited Guozhang Wang to > become a committer. Guozhang has made significant contributions to Kafka > over the past year, along with being very active

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Timothy Chen
> On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/TransactionManager.scala, line 300 > > <https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300> > > > > I'm just trying to think if there is a

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Timothy Chen
> On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/TransactionManager.scala, line 300 > > <https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300> > > > > I'm just trying to think if there is a

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
> On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/TransactionManager.scala, line 300 > > <https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300> > > > > I'm just trying to think if there is a

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
handled but just want to throw it out there. - Timothy Chen On Aug. 6, 2014, 4:25 a.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
c/main/scala/kafka/server/TransactionManager.scala <https://reviews.apache.org/r/23568/#comment86979> If the batch size changes to a smaller number does the tx Id range overlap then? - Timothy Chen On Aug. 6, 2014, 4:25 a.

Re: Issues getting IntelliJ set up

2014-08-04 Thread Timothy Chen
Hi Johnathan, Did you update your scala version before you run gradle idea? Also try cleaning up all the artifacts and try it again, as perhaps your intellij is not picking up the right version and from the right build folder. Tim On Mon, Aug 4, 2014 at 12:09 PM, Jonathan Natkins wrote: > Hi,

Re: Review Request 23702: Patch for KAFKA-1070

2014-07-20 Thread Timothy Chen
> On July 19, 2014, 11:28 p.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 64 > > <https://reviews.apache.org/r/23702/diff/2/?file=636339#file636339line64> > > > > Why reduce the range to 1000? > > > > Srih

Re: Review Request 23702: Patch for KAFKA-1070

2014-07-19 Thread Timothy Chen
tps://reviews.apache.org/r/23702/#comment84538> Why reduce the range to 1000? core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/23702/#comment84539> You can just use an Option - Timothy Chen On July 19, 2014, 11:06 p.m., Sriharsha Chinta

Re: Improving the Kafka client ecosystem

2014-07-19 Thread Timothy Chen
The certified client test suite really will benefit all the client developers, as writing a Kafka client often is not just talking protocol but to be able to handle correctly all the cases, errors and situations, but also performance. From my experience writing a C# client definitely feel that a

Re: Review Request 21272: Patch for KAFKA-1443

2014-06-05 Thread Timothy Chen
. - Timothy Chen On June 5, 2014, 3:51 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21272/ > --

[jira] [Updated] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-04 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1443: Attachment: KAFKA-1443_2014-06-04_20:51:44.patch > Add delete topic to topic commands and upd

[jira] [Commented] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-04 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018454#comment-14018454 ] Timothy Chen commented on KAFKA-1443: - Updated reviewboard https://reviews.apache

Re: Review Request 21272: Patch for KAFKA-1443

2014-06-04 Thread Timothy Chen
/main/scala/kafka/admin/TopicCommand.scala bdc72eaa9052b6f46bac510ab53c57d3283cdc25 Diff: https://reviews.apache.org/r/21272/diff/ Testing --- Thanks, Timothy Chen

Re: deleting topics

2014-06-04 Thread Timothy Chen
On the same note, perhaps someone can review my patch for the delete topic command? https://reviews.apache.org/r/21272/ Thanks! Tim On Wed, Jun 4, 2014 at 9:54 AM, Guozhang Wang wrote: > The delete topic utility should be workable in the next release 0.8.2. > > Guozhang > > > On Wed, Jun 4, 20

[jira] [Commented] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-05-15 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993760#comment-13993760 ] Timothy Chen commented on KAFKA-1443: - Created reviewboard https://reviews.apache

Review Request 21272: Patch for KAFKA-1443

2014-05-15 Thread Timothy Chen
bdc72eaa9052b6f46bac510ab53c57d3283cdc25 Diff: https://reviews.apache.org/r/21272/diff/ Testing --- Thanks, Timothy Chen

Re: Failed to build Kafka using IntelliJ

2014-05-15 Thread Timothy Chen
It seems like that you generated your idea files you were on a different scala version than what you configured it to be. Can you try to set your scala version to 2.9.2 in your gradle.properties, and do a ./gradlew clean idea, and try again? Tim On Tue, May 13, 2014 at 11:26 PM, Sheng Wang wro

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-14 Thread Timothy Chen
/Sender.java <https://reviews.apache.org/r/21398/#comment76966> Got it! - Timothy Chen On May 13, 2014, 6:25 p.m., Guozhang Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: How can I step through the Kafka code using a debugger

2014-05-14 Thread Timothy Chen
Hi Sheng Wang, If you look at the Kafka website there is already a IDE setup page you can follow. Once your IDE is setup you can simply run Kafka via the Kafka main method and set breakpoints in the broker. Tim On Tue, May 13, 2014 at 11:44 PM, Sheng Wang wrote: > Hi, > > I want to learn more

Re: Review Request 21398: Fix KAFKA-1445 v2

2014-05-13 Thread Timothy Chen
/Sender.java <https://reviews.apache.org/r/21398/#comment76775> Should we only call forceUpdate once if we get multiple unknown nodes? - Timothy Chen On May 13, 2014, 6:25 p.m., Guozhang Wang wrote: > > --- > This is a

[jira] [Updated] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-05-12 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1443: Attachment: KAFKA-1443.patch > Add delete topic to topic commands and update DeleteTopicComm

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-06 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991080#comment-13991080 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-06 Thread Timothy Chen
/ReplicaManagerTest.scala 41ebc7acae2efdd8a58964aa746c90fa71ac9ba4 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-06 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-06_13:21:14.patch > Log Broker st

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-05_17:14:57.patch > Log Broker st

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-05 Thread Timothy Chen
a78f7cfa025b0c5d968381b6d5dc7aec894a612b core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 41ebc7acae2efdd8a58964aa746c90fa71ac9ba4 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990123#comment-13990123 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989994#comment-13989994 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-05_14:25:25.patch > Log Broker st

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-05 Thread Timothy Chen
Fixed it in the next patch. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/#review42197 --- On May 5, 2014, 9:25 p.m., T

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-05 Thread Timothy Chen
a78f7cfa025b0c5d968381b6d5dc7aec894a612b core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 41ebc7acae2efdd8a58964aa746c90fa71ac9ba4 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-05-05_14:00:29.patch > delete topic is not work

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989968#comment-13989968 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-05 Thread Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 014e9644dba1d65142f6a9abc745858870a46230 core/src/test/scala/unit/kafka/utils/TestUtils.scala 00bfba41fe008fe72c17fb788e3cada3daf8eb30 Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-05 Thread Timothy Chen
tps://reviews.apache.org/r/20745/#comment75941> Makes sense! - Timothy Chen On May 5, 2014, 9 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-05-05_11:17:59.patch > delete topic is not work

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989793#comment-13989793 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-05 Thread Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 014e9644dba1d65142f6a9abc745858870a46230 core/src/test/scala/unit/kafka/utils/TestUtils.scala 00bfba41fe008fe72c17fb788e3cada3daf8eb30 Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-05 Thread Timothy Chen
------- On May 2, 2014, 8:38 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20745/ > ---

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-05_11:05:15.patch > Log Broker st

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-05 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989785#comment-13989785 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-05 Thread Timothy Chen
c208f83bed7fb91f07fae42f2b66892e6d46fecc core/src/main/scala/kafka/server/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-05-02 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988206#comment-13988206 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-05-02 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-05-02_13:38:02.patch > delete topic is not work

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-02 Thread Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 014e9644dba1d65142f6a9abc745858870a46230 core/src/test/scala/unit/kafka/utils/TestUtils.scala 00bfba41fe008fe72c17fb788e3cada3daf8eb30 Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-02 Thread Timothy Chen
ndSet > > on isRunning? Good point, consolidated it. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20745/#review41979 -------

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-02 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988111#comment-13988111 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-02 Thread Timothy Chen
c208f83bed7fb91f07fae42f2b66892e6d46fecc core/src/main/scala/kafka/server/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-02 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-02_12:13:24.patch > Log Broker st

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987259#comment-13987259 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-01_18:47:03.patch > Log Broker st

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-01 Thread Timothy Chen
c208f83bed7fb91f07fae42f2b66892e6d46fecc core/src/main/scala/kafka/server/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-01 Thread Timothy Chen
0718/#review41993 ------- On April 26, 2014, 7:09 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/207

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987239#comment-13987239 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-05-01_18:12:24.patch > delete topic is not work

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-01 Thread Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 014e9644dba1d65142f6a9abc745858870a46230 core/src/test/scala/unit/kafka/utils/TestUtils.scala 49c7790c995bb2e79322eb148ab80d0dcccefed4 Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987127#comment-13987127 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-05-01 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-05-01_15:53:57.patch > delete topic is not work

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-01 Thread Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad core/src/test/scala/unit/kafka/utils/TestUtils.scala 49c7790c995bb2e79322eb148ab80d0dcccefed4 Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20745: Patch for KAFKA-1397

2014-05-01 Thread Timothy Chen
s to be the same as > > testPartitionReassignmentDuringDeleteTopic(). Just the order of requests, but as well cannot gurantee what is processed first as they're just asynchronous. Will remove. - Timothy --- This is an automatic

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-04-30 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986142#comment-13986142 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-04-30 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-04-30_14:55:28.patch > delete topic is not work

Re: Review Request 20745: Patch for KAFKA-1397

2014-04-30 Thread Timothy Chen
, Timothy Chen

Re: Review Request 20745: Patch for KAFKA-1397

2014-04-30 Thread Timothy Chen
ler while the delete topic process is still in progress. Currently there is no way to gurantee that the delete topic can halt until some condition happens, so it might be not guranteed. - Timothy --- This is an automati

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-04-28 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983759#comment-13983759 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-04-28 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-04-28_17:08:49.patch > delete topic is not work

Re: Review Request 20745: Patch for KAFKA-1397

2014-04-28 Thread Timothy Chen
/unit/kafka/admin/DeleteTopicTest.scala 9c29e144bba2c9bafa91941b6ca5c263490693b3 core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy Chen

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-04-28 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397_2014-04-28_14:48:32.patch > delete topic is not work

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-04-28 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983619#comment-13983619 ] Timothy Chen commented on KAFKA-1397: - Updated reviewboard https://reviews.apache

Re: Review Request 20745: Patch for KAFKA-1397

2014-04-28 Thread Timothy Chen
/unit/kafka/admin/DeleteTopicTest.scala 9c29e144bba2c9bafa91941b6ca5c263490693b3 core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20745: Patch for KAFKA-1397

2014-04-28 Thread Timothy Chen
eing deleted the first time. I was trying to say that this is the first time the topic has been queued for deletion and not resumed to be completed or retried. I'll try to rewrite it. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2074

[jira] [Updated] (KAFKA-1397) delete topic is not working

2014-04-26 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1397: Attachment: KAFKA-1397.patch > delete topic is not work

[jira] [Commented] (KAFKA-1397) delete topic is not working

2014-04-26 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982206#comment-13982206 ] Timothy Chen commented on KAFKA-1397: - Created reviewboard https://reviews.apache

Review Request 20745: Patch for KAFKA-1397

2014-04-26 Thread Timothy Chen
9c29e144bba2c9bafa91941b6ca5c263490693b3 core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b Diff: https://reviews.apache.org/r/20745/diff/ Testing --- Thanks, Timothy Chen

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-04-26 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-04-26_00:09:56.patch > Log Broker st

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-04-26 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981909#comment-13981909 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard https://reviews.apache

Re: Review Request 20718: Patch for KAFKA-1384

2014-04-26 Thread Timothy Chen
c208f83bed7fb91f07fae42f2b66892e6d46fecc core/src/main/scala/kafka/server/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20718: Patch for KAFKA-1384

2014-04-25 Thread Timothy Chen
mponent states. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/#review41501 --- On April 25, 20

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-04-25 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384.patch > Log Broker state > - > >

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-04-25 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981275#comment-13981275 ] Timothy Chen commented on KAFKA-1384: - Created reviewboard https://reviews.apache

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-04-25 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981272#comment-13981272 ] Timothy Chen commented on KAFKA-1384: - I'm planning just to expose it via J

Review Request 20718: Patch for KAFKA-1384

2014-04-25 Thread Timothy Chen
/KafkaServerStartable.scala acda52b801714bcc182edc0ced925f0e4b493fc1 Diff: https://reviews.apache.org/r/20718/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 20713: Patch for KAFKA-1424

2014-04-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20713/#review41473 --- Ship it! Ship It! - Timothy Chen On April 25, 2014, 2:54 p.m

Re: [VOTE] Apache Kafka 0.8.1.1 Release Candidate 1

2014-04-24 Thread Timothy Chen
+1 (Non-binding). Tim On Thu, Apr 24, 2014 at 5:32 PM, Joel Koshy wrote: > +1 > > One (non-critical) issue is that I think our packaging isn't complete > for kafka-perf (we are only building for 2.8.0). > > On Tue, Apr 22, 2014 at 07:18:38PM -0400, Joe Stein wrote: >> This is the first candidate

Re: Review Request 20540: Patch for KAFKA-1410

2014-04-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41067 --- Ship it! Ship It! - Timothy Chen On April 22, 2014, 8:51 p.m

Re: Review Request 20540: Patch for KAFKA-1410

2014-04-22 Thread Timothy Chen
tps://reviews.apache.org/r/20540/#comment74401> Do we no longer need to check for offset management topic? - Timothy Chen On April 22, 2014, 4:37 p.m., Jun Rao wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/#review40968 --- Ship it! Ship It! - Timothy Chen On April 21, 2014, 9:47 p.m

  1   2   3   >