Re: [VOTE] KIP-45: Standardize KafkaConsumer API to use Collection

2016-05-09 Thread Mark Grover
completely (I don't think it does). > > > > > > It will get implicitly cast to collection with the new methods. > > >> > > > > > > That is only the case if the code is recompiled with 0.10.0.0 (i.e. > > source > > > compatibility). >

Re: [VOTE] KIP-45: Standardize KafkaConsumer API to use Collection

2016-05-07 Thread Mark Grover
te that kafka-clients 0.9 works fine with > 0.10 brokers. Supporting both 0.9 and 0.10 clients from the same JAR will > be a bit annoying, but the ugly shim code for that is straightforward to > write for advanced users that need this. > > I should make it clear that this is my position,

Re: [VOTE] KIP-45: Standardize KafkaConsumer API to use Collection

2016-05-06 Thread Mark Grover
I understand and empathize with both sides of the story here. I spend some of my time on Spark and Kafka integration and I have cc'ed Cody who's been working on new Kafka consumer API with Spark Streaming. Spark hasn't merged the new Kafka consumer API integration, the PR is up and we, as a communi

[jira] [Commented] (KAFKA-3669) Add secondary constructor for KafkaConfig with a default value for doLog

2016-05-06 Thread Mark Grover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274744#comment-15274744 ] Mark Grover commented on KAFKA-3669: Thanks [~ijuma]! > Add secondary cons

[jira] [Commented] (KAFKA-3669) Add secondary constructor for KafkaConfig with a default value for doLog

2016-05-06 Thread Mark Grover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274554#comment-15274554 ] Mark Grover commented on KAFKA-3669: https://github.com/apache/kafka/pull/1333

Re: [VOTE] 0.10.0.0 RC3

2016-05-06 Thread Mark Grover
Thanks, Gwen. I was testing RC2 with Spark Streaming and found an issue that has a minor fix. I think this issue exists with RC3 as well: https://issues.apache.org/jira/browse/KAFKA-3669 On Thu, May 5, 2016 at 1:46 PM, Gwen Shapira wrote: > Hello Kafka users, developers and client-developers, >

[jira] [Created] (KAFKA-3669) Add secondary constructor for KafkaConfig with a default value for doLog

2016-05-06 Thread Mark Grover (JIRA)
Mark Grover created KAFKA-3669: -- Summary: Add secondary constructor for KafkaConfig with a default value for doLog Key: KAFKA-3669 URL: https://issues.apache.org/jira/browse/KAFKA-3669 Project: Kafka

Re: Upgrading to Kafka 0.9.x

2016-02-26 Thread Mark Grover
is the possibility of doing forwards and > backwards compatibility in the clients. I'm not sure this would actually > make things better, that would probably depend on the details of how it > worked. > > -Jay > > > On Fri, Feb 26, 2016 at 9:46 AM, Mark Grover wrote: >

Upgrading to Kafka 0.9.x

2016-02-26 Thread Mark Grover
Hi Kafka devs, I come to you with a dilemma and a request. Based on what I understand, users of Kafka need to upgrade their brokers to Kafka 0.9.x first, before they upgrade their clients to Kafka 0.9.x. However, that presents a problem to other projects that integrate with Kafka (Spark, Flume, S

[jira] [Commented] (KAFKA-3052) broker properties get logged twice if acl is enabled

2016-02-10 Thread Mark Grover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142041#comment-15142041 ] Mark Grover commented on KAFKA-3052: Ah, thanks Ismael. My kafka code was in

[jira] [Comment Edited] (KAFKA-3052) broker properties get logged twice if acl is enabled

2016-02-10 Thread Mark Grover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142015#comment-15142015 ] Mark Grover edited comment on KAFKA-3052 at 2/11/16 12:2

[jira] [Commented] (KAFKA-3052) broker properties get logged twice if acl is enabled

2016-02-10 Thread Mark Grover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142015#comment-15142015 ] Mark Grover commented on KAFKA-3052: Hi all, this seems like a very good ch