[
https://issues.apache.org/jira/browse/KAFKA-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142015#comment-15142015
]
Mark Grover edited comment on KAFKA-3052 at 2/11/16 12:24 AM:
--------------------------------------------------------------
Hi all, this seems like a very good change, thanks for working on this.
However, this changes the public signature of the KafkaConfig class between
Apache Kafka 0.9.0.0 and Apache Kafka 0.9.0.0. For example, there's some code
in [Spark
Streaming|https://github.com/apache/spark/blob/master/external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaTestUtils.scala#L111]
which will fail to compile when Kafka version is bumped from 0.9.0.0 to
0.9.0.1 (currently Spark is still on 0.8* but we will hopefully add support for
0.9* soon).
I realize there is a companion object (KafkaConfig) and its fromProps method
should be used instead of the constructor. Then, do you think it makes sense to
make the class constructor private? If so, I can file a JIRA. I realize Spark
is doing the wrong thing by using the constructor but I wonder how much code is
out there that's going to stop compiling when they bump from 0.9.0.0 to 0.9.0.1
Thoughts?
was (Author: mgrover):
Hi all, this seems like a very good change, thanks for working on this.
However, changes the public signature of the class between Apache Kafka 0.9.0.0
and Apache Kafka 0.9.0.0. For example, there's some code in [Spark
Streaming|https://github.com/apache/spark/blob/master/external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaTestUtils.scala#L111]
which will fail to compile when Kafka version is bumped from 0.9.0.0 to
0.9.0.1 (currently Spark is still on 0.8* but we will hopefully add support for
0.9* soon).
I realize there is a companion object (KafkaConfig) and its fromProps method
should be used instead of the constructor but if so, do you think it makes
sense to make the class constructor private? If so, I can file a JIRA. I
realize Spark is doing the wrong thing by using the constructor but I wonder
how much code is out there that's going to stop compiling when they bump from
0.9.0.0 to 0.9.0.1 Thoughts?
> broker properties get logged twice if acl is enabled
> ----------------------------------------------------
>
> Key: KAFKA-3052
> URL: https://issues.apache.org/jira/browse/KAFKA-3052
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0.0
> Reporter: Jun Rao
> Assignee: Ismael Juma
> Labels: newbie, security
> Fix For: 0.9.0.1
>
>
> This is because in SimpleAclAuthorizer.configure(), there is the following
> statement which triggers the logging of all broker properties.
> val kafkaConfig = KafkaConfig.fromProps(props)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
