Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-12-07 Thread Hanyu (Peter) Zheng
t 7:06 PM Guozhang Wang > wrote: > > > > Thanks Hanyu. I made a pass on the KIP and read through the DISCUSS > > thread. Do not have any comments. +1 > > > > On Fri, Oct 13, 2023 at 9:29 AM Hanyu (Peter) Zheng > > wrote: > > > > > > Hello every

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-12-07 Thread Hanyu (Peter) Zheng
According to KIP-968, we added ResultOrder to this KIP and support withAscendingKeys() to the TimestampedRangeQuery. Sincerely, Hanyu On Wed, Nov 8, 2023 at 11:04 AM Hanyu (Peter) Zheng wrote: > Hi all, > > This voting thread has been open for over 72 hours and has received enoug

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-12-04 Thread Hanyu (Peter) Zheng
On Thu, Nov 30, 2023 at 8:34 PM Hanyu (Peter) Zheng > wrote: > > > new KIP link: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++update+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery > > > > On Wed, Nov 29,

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-30 Thread Hanyu (Peter) Zheng
new KIP link: https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++update+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery On Wed, Nov 29, 2023 at 10:12 PM Hanyu (Peter) Zheng wrote: > Thank you Bruno, > 1. Thank you for the notification. I have updated the ticke

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-29 Thread Hanyu (Peter) Zheng
use > >> the get-prefix anymore, please? That was apparently an oversight when > >> those methods were added. Although the API is marked as Evolving, I > >> think we should still deprecate the getX() methods, since it does not > >> cost us anything. > >>

[VOTE] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-17 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (21

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-08 Thread Hanyu (Peter) Zheng
wrote: > >> > >> Hi Hanyu, > >> > >> Thanks for the KIP! > >> +1 (non-binding) > >> > >> Hao > >> > >> On Thu, Nov 2, 2023 at 1:29 PM Bill Bejeck wrote: > >> > >>> Hi Hanyu, > >>> > >&

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-08 Thread Hanyu (Peter) Zheng
+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery Any suggestions are more than welcome. Many thanks, Hanyu On Wed, Nov 8, 2023 at 10:38 AM Hanyu (Peter) Zheng wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C

[DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-08 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (21

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-01 Thread Hanyu (Peter) Zheng
Hello everyone, I would like to start a vote for KIP-992: Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery. Sincerely, Hanyu On Wed, Nov 1, 2023 at 10:00 AM Hanyu (Peter) Zheng wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-

[VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-01 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A+Proposal+to+introduce+IQv2+Query+Types%3A+TimestampedKeyQuery+and+TimestampedRangeQuery -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-30 Thread Hanyu (Peter) Zheng
Hi, Hao, For TimestampedKeyQuery, it only returns the value of the key, and the value should be ValueAndTimestamp. If you want to get an iterator of `ValueAndTimestamp`, you can use TimestampedRangeQuery. Sincerely, Hanyu On Mon, Oct 30, 2023 at 1:42 PM Hanyu (Peter) Zheng wrote: >

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-30 Thread Hanyu (Peter) Zheng
t; > > (Of course, there might be an exception thrown to the user if they don't > > check `isSuccess()` flag but call `getResult()` directly.) > > > > > > -Matthias > > > > On 10/25/23 8:55 AM, Hanyu (Peter) Zheng wrote: > > > Hi, Bill, > &g

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-25 Thread Hanyu (Peter) Zheng
a exception, so TimestampedKeyQuery query can only query ts-kv-store and return ValueAndTimestamp object in the end. Sincerely, Hanyu On Wed, Oct 25, 2023 at 8:51 AM Hanyu (Peter) Zheng wrote: > Thank you Lucas, > > I will fix the capitalization. > When a user executes a times

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-25 Thread Hanyu (Peter) Zheng
it would be > > good to add those details to the KIP. > > > > Thanks, > > Bill > > > > > > > > On Fri, Oct 20, 2023 at 5:07 PM Hanyu (Peter) Zheng > > wrote: > > > > > Thank you Matthias, > > > > > > I will modi

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-20 Thread Hanyu (Peter) Zheng
Thank you Matthias, I will modify the KIP to eliminate this restriction. Sincerely, Hanyu On Fri, Oct 20, 2023 at 2:04 PM Hanyu (Peter) Zheng wrote: > Thank you Alieh, > > In these two new query types, I will remove 'get' from all getter method > names. > > Sincer

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-20 Thread Hanyu (Peter) Zheng
automatically > unwrap the value. > > > > -Matthias > > On 10/20/23 2:32 AM, Alieh Saeedi wrote: > > Hey Hanyu, > > > > Thanks for the KIP. It seems good to me. > > Just one point: AFAIK, we are going to remove "get" from the name of

Re: [DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-19 Thread Hanyu (Peter) Zheng
+TimestampedKeyQuery+and+TimestampedRangeQuery Any suggestions are more than welcome. Many thanks, Hanyu On Thu, Oct 19, 2023 at 8:17 AM Hanyu (Peter) Zheng wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A+Proposal+to+introduce+IQv2+Query+Types%3A+TimestampedKeyQue

[DISCUSS] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-10-19 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A+Proposal+to+introduce+IQv2+Query+Types%3A+TimestampedKeyQuery+and+TimestampedRangeQuery -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)

Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-17 Thread Hanyu (Peter) Zheng
gt; > On Tue, Oct 17, 2023 at 3:22 AM Lucas Brutschy > wrote: > > > +1 (binding) > > > > Thanks for the KIP! > > > > On Tue, Oct 17, 2023 at 2:31 AM Matthias J. Sax > wrote: > > > > > > +1 (binding) > > > > > > >

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
... -- this could actually be a > >>> step into the right direction and would follow the underlying idea of > >>> IQv2 to begin with: decouple semantics for the store interfaces from > the > >>> query types and semantics... > >>> > >>> &g

Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
Hello everyone, I would like to start a vote for KIP-985 that Add reverseRange and reverseAll query over kv-store in IQv2. Sincerely, Hanyu On Fri, Oct 13, 2023 at 9:15 AM Hanyu (Peter) Zheng wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-985:+Add+reverseRange+and+reve

[VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-985:+Add+reverseRange+and+reverseAll+query+over+kv-store+in+IQv2 -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)+431-7193> Follow us: [image:

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-09 Thread Hanyu (Peter) Zheng
y useful feature. > I would just make a note of the semantics in the JavaDoc and also in the > KIP. > > Thanks, > Colt McNealy > > *Founder, LittleHorse.dev* > > > On Mon, Oct 9, 2023 at 2:22 PM Hanyu (Peter) Zheng > wrote: > > > After our discussion

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-09 Thread Hanyu (Peter) Zheng
RangeQuery ultimately invoke either the range method or the reverseRange method. However, as per the JavaDoc: the order is not guaranteed, since byte lexicographical ordering may not correspond to the actual key order. Sincerely, Hanyu On Fri, Oct 6, 2023 at 10:00 AM Hanyu (Peter) Zheng wrote

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-06 Thread Hanyu (Peter) Zheng
ks. Sincerely, Hanyu On Thu, Oct 5, 2023 at 9:52 AM Hanyu (Peter) Zheng wrote: > Hi, Hao, > > In this case, it will return an empty set or list in the end. > > Sincerely, > Hanyu > > On Wed, Oct 4, 2023 at 10:29 PM Matthias J. Sax wrote: > >> Great discussion!

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-05 Thread Hanyu (Peter) Zheng
; > */ > > public static RangeQuery withRange(final K lower, > final K > > upper) { > > return new RangeQuery<>(Optional.ofNullable(lower), > > Optional.ofNullable(upper), true); > > } > > ``` > > that a `null` in lo

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-04 Thread Hanyu (Peter) Zheng
uses a TreeMap structure, which means the keys are already sorted. Sincerely, Hanyu On Wed, Oct 4, 2023 at 9:25 AM Hanyu (Peter) Zheng wrote: > Hi, Bruno > > Thank you for your suggestions, I will update them soon. > Sincerely, > > Hanyu > > On Wed, Oct 4, 2023 at 9:2

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-04 Thread Hanyu (Peter) Zheng
Hi, Bruno Thank you for your suggestions, I will update them soon. Sincerely, Hanyu On Wed, Oct 4, 2023 at 9:25 AM Hanyu (Peter) Zheng wrote: > Hi, Lucas, > > Thank you for your suggestions. > I will update the KIP and code together. > > Sincerely, > Hanyu > > On

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-04 Thread Hanyu (Peter) Zheng
Hi, Lucas, Thank you for your suggestions. I will update the KIP and code together. Sincerely, Hanyu On Tue, Oct 3, 2023 at 8:16 PM Hanyu (Peter) Zheng wrote: > If we use WithDescendingKeys() to generate a RangeQuery to do the > reveseQuery, how do we achieve the methods like wit

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
If we use WithDescendingKeys() to generate a RangeQuery to do the reveseQuery, how do we achieve the methods like withRange, withUpperBound, and withLowerBound only in this method? On Tue, Oct 3, 2023 at 8:01 PM Hanyu (Peter) Zheng wrote: > I believe there's no need to introduce a met

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
tible with the other methods, especially considering that, based on KIP 969, WithDescendingKeys() doesn't appear to take any input variables. And if withDescendingOrder() doesn't accept any input, how does it return a RangeQuery? On Tue, Oct 3, 2023 at 4:37 PM Hanyu (Peter) Zheng wrote:

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
Hi, Colt, The underlying structure of inMemoryKeyValueStore is treeMap. Sincerely, Hanyu On Tue, Oct 3, 2023 at 4:34 PM Hanyu (Peter) Zheng wrote: > Hi Bill, > 1. I will update the KIP in accordance with the PR and synchronize their > future updates. > 2. I will use that name. >

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
Hi Bill, 1. I will update the KIP in accordance with the PR and synchronize their future updates. 2. I will use that name. 3. you mean add something about ordering at the motivation section? Sincerely, Hanyu On Tue, Oct 3, 2023 at 4:29 PM Hanyu (Peter) Zheng wrote: > Hi, Walker, > >

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
seQuery is merely a term. To clear up any ambiguity, I'll make necessary adjustments to the KIP. Sincerely, Hanyu On Tue, Oct 3, 2023 at 4:09 PM Hanyu (Peter) Zheng wrote: > Ok, I will change it back to following the code, and update them together. > > On Tue, Oct 3, 2023 at 2:27 PM

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
ld > > require opening a rocksdb range scan** on multiple rocksdb instances (one > > per partition), and polling the first key of each. Whether or not this is > > ordered, could we please add that to the documentation? > > > > **(How is this implemented/guaranteed in an `i

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
"multiple partitions" in > it. > > > > > > Currently, IQv1 does not guarantee order of keys in this scenario. Does > > > IQv2 support ordering across partitions? Such an implementation would > > > require opening a rocksdb range scan** on mul

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
guess `withReverseOrder` would also work) might be > better? Would be good to align to KIP-969 proposal that suggest do use > `withDescendingKeys` methods for "reverse key-range"; if we go with > `withReverseOrder` we should change KIP-969 accordingly. > > Curious to hear wha

[DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-985%3A+Add+reverseRange+and+reverseAll+query+over+kv-store+in+IQv2 -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)+431-7193> Follow us: [image:

Re: Need generate a KIP

2023-10-02 Thread Hanyu (Peter) Zheng
Thank you, Josep. Yes I also need Jira rights. On Mon, Oct 2, 2023 at 9:05 AM Josep Prat wrote: > Hi Peter, > > You are set :) Please share if you also need Jira rights. > > Best, > > On Mon, Oct 2, 2023 at 5:59 PM Hanyu (Peter) Zheng > wrote: > > > wiki ID:

Need generate a KIP

2023-10-02 Thread Hanyu (Peter) Zheng
wiki ID: pzheng Jira ID: hanyuzheng -- [image: Confluent] <https://www.confluent.io> Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)+431-7193> Follow us: [image: Blog] <https://www.confluent.io/blog?utm_source=footer&utm_medium=email&am