Re: [VOTE] KIP-1190: Add a metric for controller thread idleness

2025-09-11 Thread Federico Valeri
Hi Mahsa, thanks for the KIP. +1 non binding On Tue, Aug 19, 2025 at 8:05 PM José Armando García Sancio wrote: > > Thanks for the KIP. +1 binding. > > On Thu, Aug 7, 2025 at 12:54 PM David Arthur wrote: > > > > Thanks for the KIP, Mahsa! > > > > Seems like a useful metric to add on the controll

Re: [DISCUSS] KIP-1127: Include push interval in ClientTelemetryReceiver context

2025-09-11 Thread Federico Valeri
Hi Mickael, the proposed changes LGTM, just a minor comment: In ClientTelemetryContext comment you should refer to ClientTelemetryExporter, not ClientTelemetryReceiver. Cheers Fede On Tue, Sep 9, 2025 at 5:53 PM Mickael Maison wrote: > > Hi, > > I'd like to start a discussion on KIP-1127: > htt

Re: [VOTE] 4.1.0 RC3

2025-09-02 Thread Federico Valeri
Hi Mickael, I've done the following: - Verified signature and checksum - Built from source using JDK 17 - Ran all unit tests - Failing (KAFKA-18912): MetadataSchemaCheckerToolTest.testVerifyEvolutionGit - Flaky (first one is mentioned in KAFKA-18834): ./gradlew connect:runtime:test --test

Re: [VOTE] 4.1.0 RC3

2025-09-01 Thread Federico Valeri
btw, I'm +1 non binding On Mon, Sep 1, 2025 at 11:53 AM Federico Valeri wrote: > > Hi Mickael, > > I've done the following: > > - Verified signature and checksum > - Built from source using JDK 17 > - Ran all uni

Re: [VOTE] 4.1.0 RC2

2025-08-20 Thread Federico Valeri
Hello Mickael, I did the following: - Build from source using JDK 17 - Ran all unit and integration tests - Ran Docker image - Ran clients from Kafka examples module - Spot checked documentation - Tested share group using staging Maven artifacts - Tested KIP-1152 - Tested KIP-1131 - Tested KIP-89

[jira] [Created] (KAFKA-19574) Improve producer and consumer config files

2025-08-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-19574: --- Summary: Improve producer and consumer config files Key: KAFKA-19574 URL: https://issues.apache.org/jira/browse/KAFKA-19574 Project: Kafka Issue Type

[jira] [Created] (KAFKA-19573) Update num.recovery.threads.per.data.dir configs

2025-08-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-19573: --- Summary: Update num.recovery.threads.per.data.dir configs Key: KAFKA-19573 URL: https://issues.apache.org/jira/browse/KAFKA-19573 Project: Kafka Issue

Re: [DISCUSS] KIP-1159: Large message reference based Serializer

2025-07-26 Thread Federico Valeri
Hi Omnia, nice design. I have few questions: FV1: Looking at PayloadStore and PayloadResponse, "id" and "path" seems to be the same thing, which is a reference to the data in the external store. If my interpretation is correct, could we converge to using one of the two terms? FV2: I think Payload

Re: [VOTE] KIP-1100: Rename org.apache.kafka.server:type=AssignmentsManager and org.apache.kafka.storage.internals.log.RemoteStorageThreadPool metrics

2025-07-26 Thread Federico Valeri
+1 non binding Thanks On Wed, Jul 23, 2025 at 1:14 PM Kamal Chandraprakash wrote: > > +1 (binding). > > On Wed, Jul 23, 2025 at 1:02 PM Luke Chen wrote: > > > +1 from me. > > Thanks for helping fix it (which caused by me... :( ) > > > > Luke > > > > On Tue, Jul 22, 2025 at 9:59 PM TengYao Chi

Re: [VOTE] KIP-1160: Enable returning supported features from a specific broker

2025-07-26 Thread Federico Valeri
+1 non binding Thanks Fede On Thu, Jul 10, 2025 at 9:43 AM TengYao Chi wrote: > > Hi PoAn, > Thanks for the KIP. Good to see this handy feature. > > +1 (binding) > Sincerely, > TengYao > > Andrew Schofield 於 2025年6月25日 週三 > 下午10:42寫道: > > > Hi, > > Thanks for the KIP. Since we are making more u

Re: [VOTE] 4.1.0 RC1

2025-07-25 Thread Federico Valeri
Hi Mickael, I can confirm that network_degrade_test.test_rate,name=rate-1000-latency-50 fails constantly with the error you reported. On Fri, Jul 25, 2025 at 5:43 PM Mickael Maison wrote: > > Hi, > > Here are the system tests results: > https://drive.google.com/file/d/1wXSuwBKNWrmq1BQzfoC7B2Qelj9

Re: [VOTE] KIP-1195: deprecate and remove org.apache.kafka.streams.errors.BrokerNotFoundException

2025-07-25 Thread Federico Valeri
+1 non binding Thanks. On Wed, Jul 23, 2025 at 9:02 PM Matthias J. Sax wrote: > > +1 (binding) > > On 7/23/25 6:59 AM, PoAn Yang wrote: > > +1 (binding) > > > > Thanks > > > >> On Jul 23, 2025, at 9:44 PM, Chia-Ping Tsai wrote: > >> > >> +1 (binding) > >> > >> Rajani Karuturi 於 2025年7月23日 週三 下

Re: [DISCUSS] KIP-1188: New ConnectorClientConfigOverridePolicy with allowlist of configurations

2025-07-25 Thread Federico Valeri
Hi Mickael, thanks for this useful KIP. Few questions from me: 1. Can you please indicate the exact major version for making this the default policy? I think you mean Kafka 5.0.0. 2. What would be the default value of connector.client.config.override.allowlist? I guess it won't be the full list of

[jira] [Created] (KAFKA-19534) Remove MX4J support

2025-07-22 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-19534: --- Summary: Remove MX4J support Key: KAFKA-19534 URL: https://issues.apache.org/jira/browse/KAFKA-19534 Project: Kafka Issue Type: Task

Re: [VOTE] KIP-1192: Add include argument to ConsumerPerformance tool

2025-07-22 Thread Federico Valeri
6:44 AM, Andrew Schofield wrote: > > >> Hi, > > >> Thanks for the KIP. > > >> > > >> +1 (binding) > > >> > > >> Andrew > > >> > > >> > > >> From: Federic

Re: [VOTE] KIP-1147: Improve consistency of command-line arguments

2025-07-21 Thread Federico Valeri
+1 non binding Thanks Fede On Mon, Jul 21, 2025 at 10:49 AM Andrew Schofield wrote: > > Hi, > I would like to start a vote for KIP-1147 which improves the consistency of > command-line arguments of the various Kafka CLI tools. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1147%3A+Imp

Re: [VOTE] KIP-1193: Deprecate MX4j support

2025-07-21 Thread Federico Valeri
; On Fri, Jul 18, 2025 at 5:53 PM TengYao Chi wrote: > >>> > >>>> Thanks for the KIP! > >>>> +1 (binding) > >>>> > >>>> Best, > >>>> TengYao > >>>> > >>>> Gaurav Narula 於 2025年7月18日

[VOTE] KIP-1193: Deprecate MX4j support

2025-07-18 Thread Federico Valeri
Hello, I would like to call a vote for KIP-1193: https://cwiki.apache.org/confluence/x/dAxJFg Thanks Fede

KIP-1193: Deprecate MX4j support

2025-07-18 Thread Federico Valeri
Hello, I would like to call a vote for KIP-1193: https://cwiki.apache.org/confluence/x/dAxJFg Thanks Fede

[VOTE] KIP-1192: Add include argument to ConsumerPerformance tool

2025-07-18 Thread Federico Valeri
Hello, I would like to call a vote for KIP-1192: https://cwiki.apache.org/confluence/x/PAxJFg Thanks Fede

Re: [DISCUSS] KIP-1147: Improve consistency of command-line arguments

2025-07-17 Thread Federico Valeri
Hi Andrew, thanks for this useful KIP. This is something that I also though while working on tools migration from Scala to Java, but that wasn't the right time. On Mon, Jul 14, 2025 at 6:18 PM Andrew Schofield wrote: > > Hi Kirk, > Thanks for your email. > > KT01: During the migration period, us

Re: [VOTE] KIP-1066: Mechanism to cordon brokers and log directories

2025-07-16 Thread Federico Valeri
+1 non binding Thanks Fede On Wed, Jul 9, 2025 at 8:58 AM Luke Chen wrote: > > Re-read the KIP after 1 year, LGTM! :) > > +1 from me. > > Thanks. > Luke > > On Tue, Jul 1, 2025 at 11:32 PM Mickael Maison > wrote: > > > Hi, > > > > I've not seen new comments in the DISCUSS thread in a while so I

Re: [VOTE] KIP-1172: Improve EndToEndLatency tool

2025-07-16 Thread Federico Valeri
+1 non binding Thanks On Tue, Jul 15, 2025 at 2:52 AM Kirk True wrote: > > +1 (non-binding) > > Thanks for the suggested improvement! > > On Thu, Jul 10, 2025, at 1:25 AM, Andrew Schofield wrote: > > Thanks for the KIP. > > > > +1 (binding) > > > > Andrew > > > >

Re: [DISCUSS] KIP-1193: Deprecate MX4j support

2025-07-15 Thread Federico Valeri
Grafana). > > A similar alternative could be Jolokia + Hawtio, but I haven't seen > this stack used much with Kafka. In both cases, a Java agent is > available, so they don't require Kafka support beyond JMX. > > > Could you please add them into the KIP? > > Best, > C

Re: [DISCUSS] KIP-1192: Add include argument to ConsumerPerformance tool

2025-07-15 Thread Federico Valeri
that's used with the > new Consumer.subscribe(SubscriptionPattern) API? That was added in KIP-848 as > part of a transition from the java.util.regex.Pattern regular expression > dialect to Google’s RE2/J. > > Thanks, > Kirk > > On Sun, Jul 13, 2025, at 11:28 PM, Feder

Re: [DISCUSS] KIP-1193: Deprecate MX4j support

2025-07-15 Thread Federico Valeri
dry to remove. > > Only one question, mostly out of curiosity: > > KT01: Is there a successor to MX4j that's would be beneficial to use in Kafka > instead? > > Thanks, > Kirk > > On Mon, Jul 14, 2025, at 8:14 AM, Federico Valeri wrote: > > Hello,

[DISCUSS] KIP-1193: Deprecate MX4j support

2025-07-14 Thread Federico Valeri
Hello, I would like to start a discussion thread about MX4j support deprecation: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1193%3A+Deprecate+MX4j+support Thanks Fede

Re: MX4j support

2025-07-14 Thread Federico Valeri
Thanks for the feedback Chia-Ping, I'll go ahead and create a KIP for this. On Mon, Jul 14, 2025 at 2:32 PM Chia-Ping Tsai wrote: > > +1 to deprecate mx4j and the project is EOL > > > Federico Valeri 於 2025年7月14日 晚上8:09 寫道: > > > > Hello devs, Kafka has suppo

[jira] [Created] (KAFKA-19503) Deprecate MX4j support.

2025-07-14 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-19503: --- Summary: Deprecate MX4j support. Key: KAFKA-19503 URL: https://issues.apache.org/jira/browse/KAFKA-19503 Project: Kafka Issue Type: Task

MX4j support

2025-07-14 Thread Federico Valeri
Hello devs, Kafka has support for MX4j, that can be used to expose JMX beans over HTTP. https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaRaftServer.scala#L91 This feature is not documented and disabled by default. To enable it, you have to pass -Dkafka_mx4jenable=t

Re: [VOTE] 4.1.0 RC0

2025-07-14 Thread Federico Valeri
Yeah, it seems we forgot to update MetadataVersion class. All 4.1 versions are listed after this comment in trunk: // // NOTE: MetadataVersions after this point are unstable and may be changed. // If users attempt to use an unstable MetadataVersion, they will get an error. // Pleas

[DISCUSS] KIP-1192: Add include argument to ConsumerPerformance tool

2025-07-13 Thread Federico Valeri
Hello everyone, I would like to propose a small improvement to the consumer performance tool that has been useful in my own tests: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1192%3A+Add+include+argument+to+ConsumerPerformance+tool Thanks Fede

Re: [DISCUSS] KIP-1181: Add include argument to ConsumerPerformance tool

2025-07-13 Thread Federico Valeri
Sorry, wrong KIP number, I'm going to create another thread. On Mon, Jul 14, 2025 at 8:23 AM Federico Valeri wrote: > > Hello everyone, I would like to propose a small improvement to the > consumer performance tool that has been useful in my own tests: > > https://cwiki.a

[DISCUSS] KIP-1181: Add include argument to ConsumerPerformance tool

2025-07-13 Thread Federico Valeri
Hello everyone, I would like to propose a small improvement to the consumer performance tool that has been useful in my own tests: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1181%3A+Add+include+argument+to+ConsumerPerformance+tool Thanks Fede

[jira] [Created] (KAFKA-19498) Add include argument to ConsumerPerformance tool

2025-07-13 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-19498: --- Summary: Add include argument to ConsumerPerformance tool Key: KAFKA-19498 URL: https://issues.apache.org/jira/browse/KAFKA-19498 Project: Kafka Issue

Re: [VOTE] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-05-14 Thread Federico Valeri
+1 non binding Thanks On Sat, Apr 26, 2025 at 4:32 PM Kirk True wrote: > > +1 (non-binding) > > Thanks! > > On Sat, Apr 26, 2025, at 3:14 AM, PoAn Yang wrote: > > +1 (non-binding) > > > > Thanks, > > PoAn > > > > > On Apr 26, 2025, at 4:10 PM, Chia-Ping Tsai wrote: > > > > > > +1 (binding) > >

Re: [VOTE] KIP-1131: Improved controller-side monitoring of broker states

2025-04-15 Thread Federico Valeri
+1 non binding Thanks On Tue, Mar 25, 2025 at 11:29 PM Kevin Wu wrote: > > Hello all, > > I am manually bumping this thread. > Any feedback or votes would be appreciated. > > Best regards, > Kevin Wu > > On Thu, Mar 13, 2025 at 1:54 PM Kevin Wu wrote: > > > Hello all, > > > > I would like to ca

Re: [VOTE] KIP-1143: Deprecated Optional and return String from public Endpoint#listenerName

2025-04-11 Thread Federico Valeri
+1 non binding Thanks On Fri, Apr 11, 2025 at 1:33 PM TengYao Chi wrote: > > Thanks for this great cleanup! > +1 (binding) > > Best, > TengYao > > On 2025/04/03 14:41:09 PoAn Yang wrote: > > Hi all, > > > > I would like to start a vote on KIP-1143. Thank you. > > > > KIP: https://cwiki.apache.or

Re: [VOTE] KIP-1123: Rack-aware partitioning for Kafka Producer

2025-04-05 Thread Federico Valeri
+1 non binding On Mon, Mar 24, 2025 at 9:51 AM Frédérik Rouleau wrote: > > +1 (non-binding) > > On Sat, Mar 22, 2025 at 12:32 PM Ivan Yurchenko wrote: > > > Hi! > > > > As there's no more comments regarding KIP-1123 [1], I'd like to put it to > > a vote. > > > > Best regards, > > Ivan > > > > [1

[jira] [Resolved] (KAFKA-17966) Controller replacement does not support scaling up before scaling down

2025-04-01 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-17966. - Resolution: Feedback Received > Controller replacement does not support scaling

Re: [DISCUSS] KIP-1131: Controller-side monitoring for broker shutdown and startup

2025-03-26 Thread Federico Valeri
Hi Kevin, thanks for the KIP. I have a couple of questions/considerations. If I understand correctly unfenced == active. In the code we always use the term active, so I think it would be better to use that for the state 0 description. You propose creating per-broker metrics indicating their state

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2025-03-25 Thread Federico Valeri
Hi Clayton, thanks for raising this point. I think it's easier to keep slf4j because it is widely adopted. Anyway, regardless of the final choice, the alternative deserves a mention in the rejected alternatives with some motivation. On Mon, Mar 24, 2025 at 9:42 PM Clayton Wohl wrote: > > Thank y

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2025-03-25 Thread Federico Valeri
Hi TengYao, this change makes sense for a major release. Some comments: - I would expand the motivation section rather than linking to the discussion - I think we should now update the `log4j2.properties` reference to `log4j2.yaml` On Mon, Mar 10, 2025 at 7:36 AM TengYao Chi wrote: > > Hi Ismael

Re: [DISCUSS] KIP-1123: Rack-aware partitioning for Kafka Producer

2025-03-25 Thread Federico Valeri
Hi, thanks for the KIP and sorry for the late reply. Should we also highlight the reduced latency in the motivation section? On Mon, Mar 10, 2025 at 9:24 PM Ivan Yurchenko wrote: > > Hi all, > > I took the pause with this KIP while Kafka 4.0 was in making to not distract > the folks. Now let's

Re: KIP-1141: Simplifying MetadataQuorumCommand by Leveraging Admin API for Controller Management

2025-03-25 Thread Federico Valeri
Hi, thanks for the KIP. This is a nice improvement IMO. Some minor notes: - the Jira link needs to be fixed - usually discussion threads starts with [DISCUSS] prefix - have you considered deprecating the old way of adding/removing controllers? On Mon, Mar 10, 2025 at 2:27 AM Kuan Po Tseng wrote

Re: [VOTE] 4.0.0 RC4

2025-03-14 Thread Federico Valeri
Hi David, I've tested the RC4 and this is what I've done: - Used the binaries to create a cluster and run clients from exampled module - Tested the upgrade issue we found in KAFKA-18979 - Tested the dynamic quorum feature (both scale up and down) - Tested group.protocol=consumer with a simple Java

Re: [VOTE] 4.0.0 RC3

2025-03-13 Thread Federico Valeri
> > > > > > > >> I've > > > > > > > >> > > >>> found: > > > > > > > >> > > >>> > > > > > > > >> > > >>> - build from src kafka-4.0.0-src.tgz with Jav

Re: [VOTE] 4.0.0 RC3

2025-03-12 Thread Federico Valeri
Hi David, in the doc menu I see the item "1.6 Differences Between KRaft mode and ZooKeeper mode", but paragraph 1.6 talks about Docker. Is this supposed to be there? On Wed, Mar 12, 2025 at 10:56 AM Luke Chen wrote: > > Hi David, > > Thanks for the analysis. > > > * kafkatest.tests.connect.connec

Re: [VOTE] 3.7.2 RC1

2024-12-08 Thread Federico Valeri
Hi, thanks for running the release. - Built from source with JDK 17 - Ran all unit and integration tests - Spot checked documentation and javadoc - Ran ZK and KRaft quickstarts - Ran Docker image +1 non binding Cheers Fede On Sun, Dec 8, 2024 at 8:57 AM TengYao Chi wrote: > > Hi Matthias, > >

Re: [VOTE] KIP-1030: Change constraints and default values for various configurations

2024-11-28 Thread Federico Valeri
+1 non binding. Thanks On Thu, Nov 28, 2024 at 3:16 AM Kamal Chandraprakash wrote: > > Hi Divij, > > +1 (Binding). Thanks for the KIP! > > Kamal > > On Thu, Nov 28, 2024, 05:37 Luke Chen wrote: > > > Hi Divij, > > > > +1 (binding) from me. > > Thanks for the KIP! > > > > Luke > > > > On Thu, No

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-19 Thread Federico Valeri
Hi Divij, the new defaults and constraints make sense to me. Thanks for raising. Maybe we can just add a note about ConfigException in the Compatibility, Deprecation, and Migration Plan section. On Tue, Nov 19, 2024 at 11:55 AM Divij Vaidya wrote: > > KT1 - That is right. We will throw a ConfigE

Re: [DISCUSS] KIP-1110: Metadata of sensitive configuration

2024-11-19 Thread Federico Valeri
Hi Luke, thanks for creating this KIP. It makes sense to me. I think using timestamp in this case is fine, as the operator only needs to know if the value changed, not when it changed (in that case clock drift could be a problem). Should we name the new DescribeConfigs field as "LastUpdateTimesta

Re: [VOTE] KIP-1058: Txn consumer exerts pressure on remote storage when reading non-txn topic

2024-11-08 Thread Federico Valeri
+1 (non binding) from me as well. Thanks. On Fri, Nov 8, 2024 at 10:42 AM Christo Lolov wrote: > > Heya, > > Apologies for the delay. You have my +1 vote as well! I am excited to see > this making it in 4.0 > > Best, > Christo > > On Wed, 6 Nov 2024 at 09:43, Kamal Chandraprakash < > kamal.chand

[jira] [Created] (KAFKA-17966) Controller disk replacement does not support scaling up before scaling down

2024-11-08 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-17966: --- Summary: Controller disk replacement does not support scaling up before scaling down Key: KAFKA-17966 URL: https://issues.apache.org/jira/browse/KAFKA-17966

Re: [VOTE] KIP-1105: Make remote log manager thread-pool configs dynamic

2024-11-07 Thread Federico Valeri
+1 (non binding) Thanks On Thu, Nov 7, 2024 at 5:46 AM Chu Cheng Li wrote: > > +1 > > On Thu, Nov 7, 2024 at 12:39 PM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > Hi all, > > > > I'd like to call for a vote on KIP-1105 > > > > https://cwiki.apache.org/confluence/display/

[jira] [Created] (KAFKA-17953) Docker image fails when setting env vars

2024-11-06 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-17953: --- Summary: Docker image fails when setting env vars Key: KAFKA-17953 URL: https://issues.apache.org/jira/browse/KAFKA-17953 Project: Kafka Issue Type

Re: [DISCUSS] KIP-1105: Make remote log manager thread-pool configs dynamic

2024-11-05 Thread Federico Valeri
of stacktrace in the KIP. > > PTAL. > > Thanks, > Kamal > > On Mon, Nov 4, 2024 at 2:37 PM Federico Valeri wrote: > > > Hi Kamal, these changes make sense to me. Thanks. > > > > In this case, I wonder if "isReady" could be a better name, instead

Re: [DISCUSS] KIP-1105: Make remote log manager thread-pool configs dynamic

2024-11-04 Thread Federico Valeri
Hi Kamal, these changes make sense to me. Thanks. In this case, I wonder if "isReady" could be a better name, instead of "isInitialized". Wdyt? Could you please add an example of the stack trace that the RLMM can raise during the initialization phase? On Sun, Nov 3, 2024 at 4:50 PM Kamal Chandra

Re: [VOTE] 3.9.0 RC5

2024-10-30 Thread Federico Valeri
Hi, I did the following tests: - Built from source - Ran all unit and integration tests - Spot checked the documentation - Tried Maven dependencies - Tested KIP-853, KIP-950, KIP-956 and KIP-1057 I also noticed that Maven artifacts were not updated. +1 (non binding) Thanks Fede On Wed, Oct 30,

Re: [VOTE] 3.8.1 RC1

2024-10-28 Thread Federico Valeri
Hi Josep, - compiled from source - ran all unit and integration tests - ran ZK and KRaft quickstarts - spot checked documentation +1 (non binding) Thanks Fede On Mon, Oct 28, 2024 at 4:31 AM Luke Chen wrote: > > Hi Josep, > > Thanks for the RC. > > I did the following > - checked the checksums

Re: [VOTE] 3.9.0 RC3

2024-10-22 Thread Federico Valeri
Hi, I did the following tests: - Ran all unit and integration tests - Spot checked the documentation - Tried out new Maven dependencies - Tested KIP-853, KIP-950, KIP-956 and KIP-1057 +1 (non binding) Thanks Fede On Mon, Oct 21, 2024 at 11:12 PM Colin McCabe wrote: > > This is the third candi

Re: [VOTE] 3.9.0 RC2

2024-10-14 Thread Federico Valeri
e.org/jira/browse/KAFKA-17031 I opened a PR to fix it: https://github.com/apache/kafka/pull/17499 > best, > Colin > > > On Sun, Oct 13, 2024, at 09:21, Federico Valeri wrote: > > Hi Colin, thanks for putting out the new RC. > > > > According to KIP-950, remote.log.man

[jira] [Reopened] (KAFKA-17031) Make configurations public

2024-10-14 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reopened KAFKA-17031: - > Make configurations public > -- > >

Re: [VOTE] 3.9.0 RC2

2024-10-13 Thread Federico Valeri
Hi Colin, thanks for putting out the new RC. According to KIP-950, remote.log.manager.thread.pool.size should be marked as deprecated and replaced by two new configurations: remote.log.manager.copier.thread.pool.size and remote.log.manager.expiration.thread.pool.size. I don't see that reflected in

[jira] [Resolved] (KAFKA-14705) Remove deprecated options and redirections

2024-10-08 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-14705. - Resolution: Fixed > Remove deprecated options and redirecti

Re: [VOTE] KIP-1089: Allow disabling heartbeats replication in MirrorSourceConnector

2024-10-02 Thread Federico Valeri
+1 non binding Thanks On Wed, Oct 2, 2024 at 3:03 PM Chris Egerton wrote: > > +1 (binding), thanks for the KIP! > > On Wed, Oct 2, 2024, 06:47 Viktor Somogyi-Vass > wrote: > > > +1 (binding) > > > > Thanks for this improvement. If you have a PR, you can ping me for review. > > > > On Fri, Sep 2

Re: [VOTE] KIP-1090 Flaky Test Management

2024-09-27 Thread Federico Valeri
+1 non binding Great work David! On Fri, Sep 27, 2024 at 10:47 AM Bruno Cadonna wrote: > > Thanks, David! > > +1 (binding) > > Best, > Bruno > > On 9/27/24 10:16 AM, Lucas Brutschy wrote: > > +1 (binding) > > > > Thanks, David, for all the hard work on this > > > > On Fri, Sep 27, 2024 at 2:21 A

Re: New release branch 3.9

2024-09-27 Thread Federico Valeri
Hello, I think I found a blocker, because the issue is related to a fairly common setup: https://issues.apache.org/jira/browse/KAFKA-17636 Let me know if you agree, or I'm missing something here. Thanks Fede On Thu, Sep 26, 2024 at 7:31 PM Greg Harris wrote: > > Hey Colin, > > KIP-1006 and the

[jira] [Created] (KAFKA-17636) StorageTool does not write SCRAM credentials when formatting disk

2024-09-27 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-17636: --- Summary: StorageTool does not write SCRAM credentials when formatting disk Key: KAFKA-17636 URL: https://issues.apache.org/jira/browse/KAFKA-17636 Project

Re: [VOTE] KIP-1073: Return fenced brokers in DescribeCluster response

2024-09-25 Thread Federico Valeri
+1 non binding Thanks Tina On Wed, Sep 25, 2024 at 5:29 AM Luke Chen wrote: > > Hi Tina, > > Thanks for the KIP. > +1 (binding) from me. > > Luke > > > On Mon, Sep 23, 2024 at 9:03 PM Gantigmaa Selenge > wrote: > > > Hi everyone, > > > > I would like to start voting for KIP-1073 that extends De

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

2024-09-18 Thread Federico Valeri
cleanup. Just one question left. I wonder > >> > how > >> > > we > >> > > >>> make sure that we don't just bring in this KIP, deprecate the arg > >> and > >> > > >>> forget about it?. First we could maybe me

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

2024-08-27 Thread Federico Valeri
+1 non binding Should we also create a Jira to track future removal? On Tue, Aug 27, 2024 at 11:02 AM Chia-Ping Tsai wrote: > > +1 (binding) > > On 2024/08/27 06:15:57 TengYao Chi wrote: > > Hi everyone, > > > > The discussion > >

[jira] [Resolved] (KAFKA-17352) Upgrade Gradle Enterprise to develocity plugin

2024-08-26 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-17352. - Resolution: Done > Upgrade Gradle Enterprise to develocity plu

Re: [VOTE] KIP-1052: Enable warmup in producer performance test

2024-08-19 Thread Federico Valeri
Hi Matt, +1 (non binding) from me. Thanks! Just a suggestion: I think that the following output line does not add much value and could be removed. "Warmup first 10 records. Steady-state results will print after the complete-test summary." On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt wrote: >

Re: [DISCUSS] Apache Kafka 3.9.0 release

2024-07-09 Thread Federico Valeri
or the KIP. I've added it to the release plan. I hope we can get it > in this week or next, since feature freeze is imminent. > > Colin > > > On Sun, Jun 30, 2024, at 23:29, Federico Valeri wrote: > > Hi Colin, is it possible to include this small KIP in the releas

Re: [VOTE] KIP-1067: Remove ReplicaVerificationTool in 4.0 (deprecate in 3.9)

2024-07-08 Thread Federico Valeri
+1 Note that we already have this tracker for tools deprecations, but I'm fine to have a dedicated one for this tool (maybe we can link them). https://issues.apache.org/jira/browse/KAFKA-14705. On Sun, Jul 7, 2024 at 3:58 PM Chia-Ping Tsai wrote: > > +1 > > Dongjin Lee 於 2024年7月7日 週日 下午9:22寫道:

Re: [DISCUSS] KIP-1052: Enable warmup in producer performance test

2024-07-03 Thread Federico Valeri
've added a description of the autopilot feature to > the Rejected Alternatives. > Fine. It's good to report them as often people find inspiration for improvements or new feature by simply reading other's KIPs. > > Just a nit, but I think we miss the --payload-file opt

Re: [DISCUSS] KIP-1052: Enable warmup in producer performance test

2024-07-01 Thread Federico Valeri
est for three cases: > (A) typical (existing) usage without invoking 'warmup-records' > (B) 'warmup-records' without using 'separated-warmup' > (C) 'warmup-records' with 'separated-warmup' > > Also, I completely agree that a

Re: [DISCUSS] Apache Kafka 3.9.0 release

2024-06-30 Thread Federico Valeri
Hi Colin, is it possible to include this small KIP in the release plan? https://cwiki.apache.org/confluence/display/KAFKA/KIP-1057%3A+Add+remote+log+metadata+flag+to+the+dump+log+tool There is already an open PR. Thanks. On Fri, Jun 28, 2024 at 7:13 AM Nelson B. wrote: > > Hi Colin, > > If you

Re: [VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-27 Thread Federico Valeri
> I have participated in the discussion and agree with the proposal. > > -- > Divij Vaidya > > > > On Thu, Jun 27, 2024 at 12:56 PM Satish Duggana > wrote: > > > Thanks Federico for the KIP. > > > > +1 > > > > ~Satish. > > > > On

Re: [VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-27 Thread Federico Valeri
> Thanks for the KIP! > > +1 from me. > > > > Luke > > > > On Fri, Jun 21, 2024 at 6:44 PM Federico Valeri > > wrote: > > > > > Hi all, I'd like to kick off a vote on KIP-1057. > > > > > > Design doc: > > >

Re: [DISCUSS] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-26 Thread Federico Valeri
face, it is still useful to have > > > > a utility that is meant for the default/inbuilt implementation based > > > > on the internal topic. We can clarify that in the help notes and user > > > > docs. > > > > > > > > Users can

Re: [DISCUSS] KIP-1052: Enable warmup in producer performance test

2024-06-21 Thread Federico Valeri
Hi Matt, I thanks for the KIP, this is a really useful feature. In public interfaces, you say that the output won't change by default, so I guess this means that --combined-summary will be false by default, otherwise we would break the producer_performance system test. Is that correct? I think a c

[VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-21 Thread Federico Valeri
Hi all, I'd like to kick off a vote on KIP-1057. Design doc: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1057%3A+Add+remote+log+metadata+flag+to+the+dump+log+tool Discussion thread: https://lists.apache.org/thread/kxx1h4qwshgcjh4d5xzqltkx5mx9qopm Thanks, Fede

Re: [DISCUSS] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-17 Thread Federico Valeri
e to use the rejected solution (which > > > requires no changes) for debugging purposes? > > > > > > > The rejected alternative will still be available, but I thought that > > having a dedicated flag would make debugging easier, as I guess most > &

Re: [VOTE] KIP-1017: A health check endpoint for Kafka Connect

2024-06-17 Thread Federico Valeri
Hi Chris, +1 (non binding) Thanks, Fede On Mon, Jun 17, 2024 at 9:57 AM Adrian Preston wrote: > > Hi Chris, > > +1 (non-binding) > > Regards, > - Adrian > > From: Edoardo Comar > Date: Sunday, 16 June 2024 at 07:57 > To: dev@kafka.apache.org > Subject: [EXTERNAL] Re: [VOTE] KIP-1017: A health

Re: [DISCUSS] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-17 Thread Federico Valeri
hat having a dedicated flag would make debugging easier, as I guess most people will use the default RLMM implementation. I would be happy to hear other opinions on this. > -- > Divij Vaidya > > > > On Sat, Jun 15, 2024 at 4:43 PM Federico Valeri > wrote: > > > Hi all

[DISCUSS] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-15 Thread Federico Valeri
Hi all, I'd like to kick off a discussion for KIP-1057, that proposes to add remote log metadata flag to the dump log tool, which is useful when debugging. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1057%3A+Add+remote+log+metadata+flag+to+the+dump+log+tool Thanks, Fede

Re: [DISCUSS] KIP-1038: Add Custom Error Handler to Producer

2024-05-15 Thread Federico Valeri
Hello Alieh, thanks for this useful KIP. There is a typo in the motivation when you talk about the UnknownTopicOrPartitionException. It's delivery.timeout.ms, not deliver.timeout.ms. In the past, I did some work to improve and clean the official Kafka examples, which I think are useful for new Ka

Re: [VOTE] KIP-1018: Introduce max remote fetch timeout config

2024-05-09 Thread Federico Valeri
+1 non binding Thanks On Thu, May 9, 2024 at 12:05 PM Luke Chen wrote: > > Hi Kamal, > > Thanks for the KIP! > +1 from me. > > Thanks. > Luke > > On Mon, May 6, 2024 at 5:03 PM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > Hi all, > > > > We would like to start a voting t

Re: [VOTE] KIP-1041: Drop `offsets.commit.required.acks` config in 4.0 (deprecate in 3.8)

2024-05-08 Thread Federico Valeri
+1 non binding Thanks On Wed, May 8, 2024 at 5:27 PM Andrew Schofield wrote: > > Hi, > Thanks for the KIP. > > +1 (non-binding) > > Thanks, > Andrew > > > On 8 May 2024, at 15:48, David Jacot wrote: > > > > Hi folks, > > > > I'd like to start a voting thread for KIP-1041: Drop > > `offsets.comm

Re: [DISCUSS] KIP-1041: Drop `offsets.commit.required.acks` config in 4.0 (deprecate in 3.8)

2024-05-03 Thread Federico Valeri
Hi David, I can't think about any valid use case where changing the default value would be useful, and your motivation is convincing. Thanks. On Fri, May 3, 2024 at 6:01 AM Andrew Schofield wrote: > > Hi David, > I think this KIP is a very good idea. It would be good to get rid of this > cruft.

Re: [VOTE] KIP-1036: Extend RecordDeserializationException exception

2024-05-03 Thread Federico Valeri
Hi Fred, this is a useful addition. +1 non binding Thanks On Fri, May 3, 2024 at 4:11 PM Andrew Schofield wrote: > > Hi Fred, > Thanks for the KIP. It’s turned out nice and elegant I think. Definitely a > worthwhile improvement. > > +1 (non-binding) > > Thanks, > Andrew > > > On 30 Apr 2024, a

Re: [VOTE] KIP-909: DNS Resolution Fallures Should Not Fail the Client

2024-04-29 Thread Federico Valeri
+1 (non binding) Thanks On Mon, Apr 29, 2024 at 10:18 AM Rajini Sivaram wrote: > > Hi Philip, > > +1 (binding). Thanks for the KIP! > > Regards, > > Rajini > > > On Tue, Apr 25, 2023 at 8:52 PM Philip Nee wrote: > > > Thanks for the vote. We've decided to make a minor change to the default > >

Re: [DISCUSS] KIP-909: Allow clients to rebootstrap DNS lookup failure

2024-04-29 Thread Federico Valeri
Hi Philip, thanks for this KIP. As other mentioned, I think it is useful in dynamic environment like Kubernetes. I was wondering if we should also update the "examples" modules with this new non-retriable exception. Wdyt? On Fri, Apr 21, 2023 at 11:13 PM Philip Nee wrote: > > Hey Jason, > > Than

Re: [DISCUSS] KIP-1018: Introduce max remote fetch timeout config

2024-04-27 Thread Federico Valeri
Hi Kamal, it looks like all TS configurations starts with "remote." prefix, so I was wondering if we should name it "remote.fetch.max.wait.ms". On Fri, Apr 26, 2024 at 7:07 PM Kamal Chandraprakash wrote: > > Hi all, > > If there are no more comments, I'll start a vote thread by tomorrow. > Please

Re: the migration of command tools

2024-04-10 Thread Federico Valeri
Hi, if a tool already has a wrapper bash script in bin and bin/windows, then there is no need to create a redirection in Scala, as users are supposed to use the script. If there is any ST left which is using the tool directly, a bash script should be created, and the ST changed to use the script wi

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-26 Thread Federico Valeri
Congrats! On Tue, Mar 26, 2024 at 2:27 PM Mickael Maison wrote: > > Congratulations Christo! > > On Tue, Mar 26, 2024 at 2:26 PM Chia-Ping Tsai wrote: > > > > Congrats Christo! > > > > Chia-Ping

Re: [VOTE] 3.7.0 RC4

2024-02-16 Thread Federico Valeri
Hi Stanislav, it's +1 (non binding) for me. - Built from source using Java 17 and Scala 2.13. - Ran all unit and integration tests. - Used the staged Maven artifacts to test some client applications against ZK and KRaft based clusters. - Tested the Cluster-wide dynamic log adjustment for Kafka Con

[jira] [Created] (KAFKA-16228) Add --remote-log-metadata-decoder to kafka-dump-log.sh

2024-02-06 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-16228: --- Summary: Add --remote-log-metadata-decoder to kafka-dump-log.sh Key: KAFKA-16228 URL: https://issues.apache.org/jira/browse/KAFKA-16228 Project: Kafka

  1   2   3   >