[jira] [Commented] (KAFKA-2920) Storage module

2015-12-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056278#comment-15056278 ] Andrii Biletskyi commented on KAFKA-2920: - The idea is to implement plug-g

[jira] [Updated] (KAFKA-2921) Plug-able implementations support

2015-12-09 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2921: Attachment: KIP-30-LE-WIP.patch > Plug-able implementations supp

[jira] [Created] (KAFKA-2922) System and Replication tools verification

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2922: --- Summary: System and Replication tools verification Key: KAFKA-2922 URL: https://issues.apache.org/jira/browse/KAFKA-2922 Project: Kafka Issue Type

[jira] [Created] (KAFKA-2921) Plug-able implementations support

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2921: --- Summary: Plug-able implementations support Key: KAFKA-2921 URL: https://issues.apache.org/jira/browse/KAFKA-2921 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2920) Storage module

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2920: --- Summary: Storage module Key: KAFKA-2920 URL: https://issues.apache.org/jira/browse/KAFKA-2920 Project: Kafka Issue Type: Sub-task Reporter

[jira] [Created] (KAFKA-2919) ListenerRegistry

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2919: --- Summary: ListenerRegistry Key: KAFKA-2919 URL: https://issues.apache.org/jira/browse/KAFKA-2919 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2917) LeaderElection module

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2917: --- Summary: LeaderElection module Key: KAFKA-2917 URL: https://issues.apache.org/jira/browse/KAFKA-2917 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2918) GroupMembership module

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2918: --- Summary: GroupMembership module Key: KAFKA-2918 URL: https://issues.apache.org/jira/browse/KAFKA-2918 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2916) KIP-30 Plug-able interface for consensus and storage sub-systems

2015-12-01 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2916: --- Summary: KIP-30 Plug-able interface for consensus and storage sub-systems Key: KAFKA-2916 URL: https://issues.apache.org/jira/browse/KAFKA-2916 Project: Kafka

[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

2015-11-02 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984933#comment-14984933 ] Andrii Biletskyi commented on KAFKA-1694: - [~granthenke], it was decided to s

[jira] [Commented] (KAFKA-2702) ConfigDef toHtmlTable() sorts in a way that is a bit confusing

2015-10-30 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982679#comment-14982679 ] Andrii Biletskyi commented on KAFKA-2702: - It's been a while, but, yes,

Re: Review Request 34766: Patch for KAFKA-2229

2015-09-19 Thread Andrii Biletskyi
> > > > > Is this needed? Should we always pass some message? (Same for the other > > exceptions added? Same as above. - Andrii --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-09-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742108#comment-14742108 ] Andrii Biletskyi commented on KAFKA-2229: - Sorry I was on vacation so didn&#x

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-09-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742109#comment-14742109 ] Andrii Biletskyi commented on KAFKA-2229: - Sorry I was on vacation so didn&#x

Re: Review Request 34766: Patch for KAFKA-2229

2015-09-12 Thread Andrii Biletskyi
s part clearer could be helpful here. - Andrii --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review95376 --- On Червень 30,

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
-------- On June 30, 2015, 1:59 p.m., Andrii Biletskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34766/ > -

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
rted. @Grant, ok, I will rebase and submit pull request tomorrow. @Ismael, thanks for the suggestion, I will try this out. - Andrii --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#rev

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review94749 ------- On June 30, 2015, 1:59 p.m., Andrii Biletskyi wrote: > > ---

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-07 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616401#comment-14616401 ] Andrii Biletskyi commented on KAFKA-2310: - [~jjkoshy] yes, it might

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.2.patch > Add config to prevent broker becoming control

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: (was: KAFKA-2310_0.8.2.patch) > Add config to prevent broker becom

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.1.patch > Add config to prevent broker becoming control

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310_0.8.2.patch > Add config to prevent broker becoming control

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Status: Patch Available (was: Open) > Add config to prevent broker becoming control

[jira] [Updated] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2310: Attachment: KAFKA-2310.patch > Add config to prevent broker becoming control

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615111#comment-14615111 ] Andrii Biletskyi commented on KAFKA-2310: - Created reviewboard h

Review Request 36203: Patch for KAFKA-2310

2015-07-06 Thread Andrii Biletskyi
, Andrii Biletskyi

[jira] [Created] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-06 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2310: --- Summary: Add config to prevent broker becoming controller Key: KAFKA-2310 URL: https://issues.apache.org/jira/browse/KAFKA-2310 Project: Kafka Issue

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-06-30 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608309#comment-14608309 ] Andrii Biletskyi commented on KAFKA-2229: - Rebased to include KAFKA-

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-06-30 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608307#comment-14608307 ] Andrii Biletskyi commented on KAFKA-2229: - Updated reviewboard h

[jira] [Updated] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-06-30 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2229: Attachment: KAFKA-2229_2015-06-30_16:59:17.patch > Phase 1: Requests and KafkaA

Re: Review Request 34766: Patch for KAFKA-2229

2015-06-30 Thread Andrii Biletskyi
://reviews.apache.org/r/34766/diff/ Testing --- Thanks, Andrii Biletskyi

Re: Review Request 34415: Patch for KAFKA-2195

2015-06-16 Thread Andrii Biletskyi
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/34415/#review88074 ------- On June 16, 2015, 7:28 p.m., Andrii Biletskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-06-16 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Attachment: KAFKA-2195_2015-06-16_22:28:19.patch > Add versionId

Re: Review Request 34415: Patch for KAFKA-2195

2015-06-16 Thread Andrii Biletskyi
, Andrii Biletskyi

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-06-16 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588607#comment-14588607 ] Andrii Biletskyi commented on KAFKA-2195: - Updated reviewboard h

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-06-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585515#comment-14585515 ] Andrii Biletskyi commented on KAFKA-2195: - Updated reviewboard h

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-06-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Attachment: KAFKA-2195_2015-06-15_09:54:53.patch > Add versionId

Re: Review Request 34415: Patch for KAFKA-2195

2015-06-14 Thread Andrii Biletskyi
/main/scala/kafka/network/RequestChannel.scala 357d8b97cb336857500213efade77950833c2096 core/src/main/scala/kafka/server/KafkaApis.scala d63bc18d795a6f0e6994538ca55a9a46f7fb8ffd Diff: https://reviews.apache.org/r/34415/diff/ Testing --- Thanks, Andrii Biletskyi

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-06-12 Thread Andrii Biletskyi
Joel, Aditya, I believe we don't need another thread to do voting since affected items are not related to the core proposed changes. I agree people can explicitly down-vote in case of concerns about the things that changed. Thanks, Andrii Biletskyi On Fri, Jun 12, 2015 at 8:24 PM, A

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-06-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584234#comment-14584234 ] Andrii Biletskyi commented on KAFKA-2195: - Yes, thanks, I'll address it

[jira] [Resolved] (KAFKA-2228) Delete me

2015-05-29 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi resolved KAFKA-2228. - Resolution: Duplicate > Delete me > - > > Key

[jira] [Resolved] (KAFKA-2227) Delete me

2015-05-29 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi resolved KAFKA-2227. - Resolution: Duplicate > Delete me > - > > Key

[jira] [Updated] (KAFKA-2227) Delete me

2015-05-29 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2227: Summary: Delete me (was: Phase 1: Requests and KafkaApis) > Delete

[jira] [Assigned] (KAFKA-2228) Delete me

2015-05-29 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi reassigned KAFKA-2228: --- Assignee: (was: Andrii Biletskyi) > Delete

[jira] [Updated] (KAFKA-2228) Delete me

2015-05-29 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2228: Summary: Delete me (was: Phase 1: Requests and KafkaApis) > Delete

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-29 Thread Andrii Biletskyi
yes - it would be good to fix ISR issue, although I didn't consider it to be a critical one (isr was part of TMR from the very beginning and almost no code relies on this piece of request). Thanks, Andrii Biletskyi On Fri, May 29, 2015 at 8:50 AM, Aditya Auradkar < aaurad...@link

[jira] [Updated] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2229: Status: Patch Available (was: Open) > Phase 1: Requests and KafkaA

[jira] [Commented] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562877#comment-14562877 ] Andrii Biletskyi commented on KAFKA-2229: - Created reviewboard h

Review Request 34766: Patch for KAFKA-2229

2015-05-28 Thread Andrii Biletskyi
, Andrii Biletskyi

[jira] [Updated] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2229: Attachment: KAFKA-2229.patch > Phase 1: Requests and KafkaA

[jira] [Created] (KAFKA-2229) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2229: --- Summary: Phase 1: Requests and KafkaApis Key: KAFKA-2229 URL: https://issues.apache.org/jira/browse/KAFKA-2229 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2228) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2228: --- Summary: Phase 1: Requests and KafkaApis Key: KAFKA-2228 URL: https://issues.apache.org/jira/browse/KAFKA-2228 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2227) Phase 1: Requests and KafkaApis

2015-05-28 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2227: --- Summary: Phase 1: Requests and KafkaApis Key: KAFKA-2227 URL: https://issues.apache.org/jira/browse/KAFKA-2227 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-24 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi reassigned KAFKA-2195: --- Assignee: Jun Rao (was: Andrii Biletskyi) > Add versionId

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-24 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Attachment: KAFKA-2195_2015-05-24_22:48:55.patch > Add versionId

Re: Review Request 34415: Patch for KAFKA-2195

2015-05-24 Thread Andrii Biletskyi
/RequestChannel.scala 1d0024c8f0c2ab0efa6d8cfca6455877a6ed8026 core/src/main/scala/kafka/server/KafkaApis.scala 387e387998fc3a6c9cb585dab02b5f77b0381fbf Diff: https://reviews.apache.org/r/34415/diff/ Testing --- Thanks, Andrii Biletskyi

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-24 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Status: Patch Available (was: In Progress) > Add versionId

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-24 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557829#comment-14557829 ] Andrii Biletskyi commented on KAFKA-2195: - Updated reviewboard h

Re: Review Request 34415: Patch for KAFKA-2195

2015-05-22 Thread Andrii Biletskyi
emove deprecation notice. - Andrii --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34415/#review84850 --- On May 19

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-19 Thread Andrii Biletskyi
Hi, Sorry I wasn't able to participate. I don't have objections about removing config changes from AlterTopic (as I understand both AddedConfig and DeletedConfig) - you are welcome to update the KIP page. Thanks, Andrii Biletskyi On Tue, May 19, 2015 at 11:40 PM, Aditya Auradka

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-19 Thread Andrii Biletskyi
ks, Andrii Biletskyi On Tue, May 19, 2015 at 12:23 AM, Andrii Biletskyi < andrii.bilets...@stealth.ly> wrote: > No worries, I think it's hard to foresee all nuances before > actually implementing/writing code. > I also have a feeling there will be some other issues > with

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-19 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Status: Patch Available (was: Open) > Add versionId to AbstractRequest.getErrorRespo

[jira] [Commented] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-19 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550682#comment-14550682 ] Andrii Biletskyi commented on KAFKA-2195: - Created reviewboard h

[jira] [Updated] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-19 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2195: Attachment: KAFKA-2195.patch > Add versionId to AbstractRequest.getErrorResponse

Review Request 34415: Patch for KAFKA-2195

2015-05-19 Thread Andrii Biletskyi
/network/RequestChannel.scala 1d0024c8f0c2ab0efa6d8cfca6455877a6ed8026 core/src/main/scala/kafka/server/KafkaApis.scala 387e387998fc3a6c9cb585dab02b5f77b0381fbf Diff: https://reviews.apache.org/r/34415/diff/ Testing --- Thanks, Andrii Biletskyi

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-18 Thread Andrii Biletskyi
sponse API, before uploading the respective patch. Thanks, Andrii Biletskyi On Tue, May 19, 2015 at 12:14 AM, Gwen Shapira wrote: > Sorry for the confusion regarding errorResponses... > > On Mon, May 18, 2015 at 9:10 PM, Andrii Biletskyi < > andrii.bilets...@stealth.ly> wrot

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-18 Thread Andrii Biletskyi
because Cluster would already encapsulate topicConfigs at that point. Thanks, Andrii Biletskyi On Mon, May 18, 2015 at 8:28 PM, Jun Rao wrote: > Andri, > > Let me clarify a bit how things work now. You can see if this fits your > need or if it can be improved. If you look at OffsetComm

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-18 Thread Andrii Biletskyi
value, we will have to change constructor without versionId, because this becomes the latest version. But would it be considered backward-compatible? Client code that uses V0 and upgrades will not compile in this case. Thoughts? Thanks, Andrii Biletskyi On Fri, May 15, 2015 at 4:31 PM, An

[jira] [Assigned] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-05-15 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi reassigned KAFKA-2073: --- Assignee: Andrii Biletskyi (was: Sriharsha Chintalapani) > Replace TopicMetad

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-05-15 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545841#comment-14545841 ] Andrii Biletskyi commented on KAFKA-2073: - [~sriharsha] is there any updat

[jira] [Created] (KAFKA-2195) Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest

2015-05-15 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2195: --- Summary: Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest Key: KAFKA-2195 URL: https://issues.apache.org/jira/browse/KAFKA-2195

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-15 Thread Andrii Biletskyi
Okay, I can pick that. I'll create sub-task under KAFKA-2044. Thanks, Andrii Biletskyi On Fri, May 15, 2015 at 4:27 PM, Gwen Shapira wrote: > Agree that you need version in getErrorResponse too (so you'll get the > correct error), which means you'll need to add version

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-15 Thread Andrii Biletskyi
ether it's the right solution. Thanks, Andrii Biletskyi On Fri, May 15, 2015 at 3:47 PM, Gwen Shapira wrote: > I agree, we currently don't handle versions correctly when de-serializing > into java objects. This will be an isssue for every req/resp we move to use > the java ob

Re: [Discussion] Using Client Requests and Responses in Server

2015-05-15 Thread Andrii Biletskyi
Gwen, I didn't find this in answers above so apologies if this was discussed. It's about the way we would like to handle request versions. As I understood from Jun's answer we generally should try using the same java object while evolving the request. I believe the only example of evolved request

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-14 Thread Andrii Biletskyi
as mentioned in KAFKA-1367. Thanks, Andrii Biletskyi On Thu, May 14, 2015 at 1:31 AM, Joel Koshy wrote: > Just had a few minor questions before I join the vote thread. > Apologies if these have been discussed: > > - Do we need DecreasePartitionsNotAllowed? i.e., can we just r

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-05-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2188: Status: Patch Available (was: Open) > JBOD Support > > >

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-05-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2188: Attachment: KAFKA-2188.patch > JBOD Support > > >

[jira] [Commented] (KAFKA-2188) JBOD Support

2015-05-12 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539777#comment-14539777 ] Andrii Biletskyi commented on KAFKA-2188: - Created reviewboard h

Review Request 34103: Patch for KAFKA-2188

2015-05-12 Thread Andrii Biletskyi
/HighwatermarkPersistenceTest.scala 60cd8249e6ec03349e20bb0a7226ea9cd66e6b17 core/src/test/scala/unit/kafka/utils/TestUtils.scala faae0e907596a16c47e8d49a82b6a3c82797c96d Diff: https://reviews.apache.org/r/34103/diff/ Testing --- Thanks, Andrii Biletskyi

[jira] [Created] (KAFKA-2188) JBOD Support

2015-05-12 Thread Andrii Biletskyi (JIRA)
Andrii Biletskyi created KAFKA-2188: --- Summary: JBOD Support Key: KAFKA-2188 URL: https://issues.apache.org/jira/browse/KAFKA-2188 Project: Kafka Issue Type: Bug Reporter

Re: [VOTE] KIP-4 Admin Commands / Phase-1

2015-05-07 Thread Andrii Biletskyi
Jun, 1. My bad, updated description, but forgot the schema itself. Fixed. 2. Okay, changed that. 3. Sure, we'll evolve TMR again once needed. Thanks, Andrii Biletskyi On Thu, May 7, 2015 at 6:16 PM, Jun Rao wrote: > Hi, Andrii, > > A few more comments. > > 1. We ne

[VOTE] KIP-4 Admin Commands / Phase-1

2015-05-05 Thread Andrii Biletskyi
Hi all, This is a voting thread for KIP-4 Phase-1. It will include Wire protocol changes and server side handling code. https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations Thanks, Andrii Biletskyi

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-05 Thread Andrii Biletskyi
st. With this we add nothing new in terms of batch requests semantics. Thanks, Andrii Biletskyi On Thu, Apr 30, 2015 at 4:31 PM, Jun Rao wrote: > The following is a description of some of my concerns on allowing the same > topic multiple times in AlterTopicRequest. > > ATP has an a

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-28 Thread Andrii Biletskyi
t again here in mailing list, and in case we implement it in final version document it well so API clients understand what exactly is not allowed and why. At the meantime I will update the KIP. After that I will start voting thread. Thanks, Andrii Biletskyi On Tue, Apr 28, 2015 at 10:33 PM, A

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-28 Thread Andrii Biletskyi
qeust will be evolved to version 1 - topic-level configuration per topic will be included and ISR field will be removed. Automatic topic-creation logic will be removed (we will use CreateTopicRequest for that). Thanks, Andrii Biletskyi On Tue, Apr 28, 2015 at 12:23 AM, Jun Rao wrote: > Yes, t

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't requir

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't requir

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't requir

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't requir

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't requir

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514762#comment-14514762 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514764#comment-14514764 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514760#comment-14514760 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514763#comment-14514763 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514761#comment-14514761 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514765#comment-14514765 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that t

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-27 Thread Andrii Biletskyi
path. I think we can consider (with a little approximation) reassignment completed if AR == RAR. If it's okay, I will remove ISR and add topic config in one change as discussed earlier. Thanks, Andrii Biletskyi On Mon, Apr 27, 2015 at 1:50 AM, Jun Rao wrote: > Andrii, > > Ano

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-26 Thread Andrii Biletskyi
s (if we implement the previous item - user will be able to specify/change all fields in one instruction) - it might be a good justification to prohibit serving such requests. Any objections? Thanks, Andrii BIletskyi On Sun, Apr 26, 2015 at 11:00 PM, Jun Rao wrote: > Andrii, > >

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-25 Thread Andrii Biletskyi
hat is possible by email. Thanks, Andrii Biletskyi On Wed, Apr 22, 2015 at 5:50 PM, Andrii Biletskyi < andrii.bilets...@stealth.ly> wrote: > As said above, I spent some time thinking about AlterTopicRequest > semantics and batching. > > Firstly, about AlterTopicRequest. Our goa

  1   2   3   >