Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

2024-11-21 Thread PoAn Yang
Hi Lianet / Jeff, Thanks for the review. LM5: The kafka-share-groups.sh also uses “—describe” to show offsets information. Change to use “—describe —state —verbose” to show group level information in kafka-share-groups.sh. LM6: Update the example. LM7: Add a description to mention “—verbose”

[jira] [Created] (KAFKA-18066) Misleading/mismatched StreamThread id in logging

2024-11-21 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-18066: -- Summary: Misleading/mismatched StreamThread id in logging Key: KAFKA-18066 URL: https://issues.apache.org/jira/browse/KAFKA-18066 Project: Kafka

[jira] [Created] (KAFKA-18065) be helpful when throwing ConcurrentModificationException out of consumers

2024-11-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18065: -- Summary: be helpful when throwing ConcurrentModificationException out of consumers Key: KAFKA-18065 URL: https://issues.apache.org/jira/browse/KAFKA-18065 Project

Re: [DISCUSS] KIP-1115: Bazel Builds

2024-11-21 Thread Chia-Ping Tsai
hi Vince Thanks for introducing this interesting KIP! I'm not an expert in Bazel, so please be patient with my potentially odd questions: CP0: Can Bazel help simplify build.gradle (currently around 3826 lines)? CP1: Gradle commands are part of the public API, so in which Kafka version should w

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.8 #113

2024-11-21 Thread Apache Jenkins Server
See

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.9 #115

2024-11-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics

2024-11-21 Thread Sophie Blee-Goldman
First off, thanks for the KIP! I think this is a great idea as it's super easy to miss naming one thing and end up with a topology that isn't upgradeable. A1. I actually had the same reaction as Almog to the name, I feel it's slightly clearer as a positive instead of a negative, though I think the

Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

2024-11-21 Thread Jeff Kim
Hi PoAn, JK2: Can we state in the KIP that we will reformat the existing classic group's `--members --verbose` as well, specifically the "ASSIGNMENT" column to include the topic name? Thanks! On 2024/11/21 14:33:37 "Lianet M." wrote: > Thanks for the updates PoAn! > > LM6. Just a nit, under th

[jira] [Resolved] (KAFKA-17917) Convert Kafka core system tests to use KRaft

2024-11-21 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu resolved KAFKA-17917. -- Fix Version/s: 4.0.0 Resolution: Fixed > Convert Kafka core system tests to use KRaft > ---

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-21 Thread Jun Rao
Hi, Divij, I am not sure if the new formula is clearly better. For example, the number of threads that each core can support may depend on whether it's a real core or hyperthreading. Suppose that we have 10 cores each supporting 1 thread, it's probably better to give 2 to network, 7 to io and the

Re: [VOTE] KIP-1112: allow custom processor wrapping

2024-11-21 Thread Sophie Blee-Goldman
Thanks for voting everyone! This KIP passes with 5 +1 (binding) votes from Bill, Lucas, Guozhang, Bruno, and myself The first PR is also ready for review if anyone has a few minutes: https://github.com/apache/kafka/pull/17892 On Wed, Nov 20, 2024 at

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Ismael Juma
Hi Greg, Comments below. On Thu, Nov 21, 2024 at 8:07 AM Greg Harris wrote: > > Greg, why can't we set the relevant system property > > automatically for the broker/connect in 3.9.x? > > The System property workaround is not effective for Java 24 This is a fair point. At the same time, where

[jira] [Resolved] (KAFKA-18063) SnapshotRegistry should not leak memory

2024-11-21 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-18063. -- Resolution: Fixed > SnapshotRegistry should not leak memory >

[DISCUSS] KIP-1115: Bazel Builds

2024-11-21 Thread Vince Rose
Hey devs, I want to start a discussion about introducing Bazel as a build system for Apache Kafka. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1115%3A+Bazel+Builds -Vince

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-21 Thread Divij Vaidya
Jun 1. Good catch. I was hasty in deriving the formula. Fixed it in the proposal below. 2. Isn't the proposed default better than the default of 1 today (for recovery threads)? For a quad core machine with a single directory, our current proposal will have 4 threads recovering instead of 1. Ideal

Re: [DISCUSS] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics

2024-11-21 Thread Matthias J. Sax
Yes, the ticket is related. Also just saw it today. Did leave a comment on the ticket for Sophie to hopefully chime in on this KIP discussion. -Matthias On 11/21/24 9:06 AM, Sebastien Viale wrote: Thank you very much for your reviews! A1 I will keep the disallow.auto.generated.topic.names

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Greg Harris
Hi Ismael, Thanks for your responses. > At the same time, where do we draw the line when it > comes to future unreleased Java versions? I don't think we need to make a determination on that at this time. We are making a one-time judgement about backporting a specific patch to a specific branch.

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.9 #114

2024-11-21 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-18038) Flaky StreamThreadTest shouldLogAndRecordSkippedRecordsForInvalidTimestamps

2024-11-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-18038. - Fix Version/s: 4.0.0 Resolution: Fixed > Flaky StreamThreadTest shouldLogAndRecor

Re: [PR] MINOR: Add alive stream threads to Kafka Streams metrics [kafka-site]

2024-11-21 Thread via GitHub
bbejeck merged PR #649: URL: https://github.com/apache/kafka-site/pull/649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-18064) SASL SCRAM should throw exception on wrap/unwrap

2024-11-21 Thread Istvan Toth (Jira)
Istvan Toth created KAFKA-18064: --- Summary: SASL SCRAM should throw exception on wrap/unwrap Key: KAFKA-18064 URL: https://issues.apache.org/jira/browse/KAFKA-18064 Project: Kafka Issue Type: Bu

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

2024-11-21 Thread Justine Olshan
Hey folks, Wanted to provide one more update for KIP-1022. There was some discussion about feature versions set by default vs features that were considered production ready. In the current implementation, those are both controlled by the metadata version mapping for each feature. After some discus

[jira] [Created] (KAFKA-18063) SnapshotRegistry should not leak memory

2024-11-21 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-18063: Summary: SnapshotRegistry should not leak memory Key: KAFKA-18063 URL: https://issues.apache.org/jira/browse/KAFKA-18063 Project: Kafka Issue Type: Bug

[PR] MINOR: Add alive stream threads to Kafka Streams metrics [kafka-site]

2024-11-21 Thread via GitHub
bbejeck opened a new pull request, #649: URL: https://github.com/apache/kafka-site/pull/649 mirror of [kafka docs PR](https://github.com/apache/kafka/pull/17868) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [DISCUSS] KIP-1111: Enforcing Explicit Naming for Kafka Streams Internal Topics

2024-11-21 Thread Sebastien Viale
Thank you very much for your reviews! A1 I will keep the disallow.auto.generated.topic.names configuration in the KIP for now while waiting for other suggestions. A2 I thought about making the implementation typesafe; it would, of course, complicate the implementation, but for me, this feature

[jira] [Created] (KAFKA-18062) Use feature version to enable ELR

2024-11-21 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-18062: -- Summary: Use feature version to enable ELR Key: KAFKA-18062 URL: https://issues.apache.org/jira/browse/KAFKA-18062 Project: Kafka Issue Type: Sub-task

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Greg Harris
Hi Ismael, Thanks for your question > Greg, why can't we set the relevant system property > automatically for the broker/connect in 3.9.x? The System property workaround is not effective for Java 24, and doesn't cover the kafka-as-a-library use-case, which is the one which is generating pain for

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Ismael Juma
We had agreed to extend _critical bug fixes_ for one year for 3.9. Something beyond that would require its own separate discuss thread, it should not be in the middle of a thread about Java 23 support in 3.9. I am personally not in favor of a LTS or 18-24 months cycle - it would divert a lot of res

Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

2024-11-21 Thread Lianet M.
Thanks for the updates PoAn! LM6. Just a nit, under the --describe --state --verbose the header is fine but the example is still missing the --state argument. LM7. Under the Proposed changes for kafka-share-groups.sh, should we clearly mention that the KIP adds a new --verbose option? I think it'

[jira] [Resolved] (KAFKA-17638) Add support for Java 23

2024-11-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17638. Fix Version/s: 4.0.0 Assignee: Chia-Ping Tsai Resolution: Fixed > Add supp

[jira] [Resolved] (KAFKA-17640) Document Java 23 support and include release note

2024-11-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17640. Fix Version/s: 4.0.0 Resolution: Fixed > Document Java 23 support and include relea

[jira] [Created] (KAFKA-18061) AddRaftVoter responds with error message "NONE" instead of null

2024-11-21 Thread Anton Agestam (Jira)
Anton Agestam created KAFKA-18061: - Summary: AddRaftVoter responds with error message "NONE" instead of null Key: KAFKA-18061 URL: https://issues.apache.org/jira/browse/KAFKA-18061 Project: Kafka

Re: [DISCUSS] KIP-1030: Change constraints and default values for various configurations

2024-11-21 Thread Kamal Chandraprakash
Hi Divij, I've updated the KIP to change the default value for configs #11 and #12. On Thu, Nov 21, 2024 at 6:25 AM Jun Rao wrote: > Hi, Divij, > > Thanks for the updated KIP. > > Regarding > num.recovery.threads.per.data.dir/num.network.threads/num.io.threads, I > have a few concerns. > 1. It

[jira] [Created] (KAFKA-18056) Minor : Fix a bug related to updating the callbacks after commitAsync.

2024-11-21 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-18056: Summary: Minor : Fix a bug related to updating the callbacks after commitAsync. Key: KAFKA-18056 URL: https://issues.apache.org/jira/browse/KAFKA-18056 Project: Kafka

[jira] [Created] (KAFKA-18060) new coordinator does not support v0-v2 TxnOffsetCommitRequest when using CONSUMER group

2024-11-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18060: -- Summary: new coordinator does not support v0-v2 TxnOffsetCommitRequest when using CONSUMER group Key: KAFKA-18060 URL: https://issues.apache.org/jira/browse/KAFKA-18060

[jira] [Created] (KAFKA-18059) kafka-metadata-quorum.sh add-controller subcommand can't recognize argument --config

2024-11-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18059: - Summary: kafka-metadata-quorum.sh add-controller subcommand can't recognize argument --config Key: KAFKA-18059 URL: https://issues.apache.org/jira/browse/KAFKA-18059 Projec

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Anton Agestam
Hello, I also think this sounds like a reasonable suggestion, also given that 3.9 was the first version to make KRaft feature complete, which means it's the first version to bring production readiness for KRaft, in many contexts. +1 from me. BR, Den tors 21 nov. 2024 kl 10:51 skrev Josep Prat :

Re: [DISCUSS] Java 23 Support for 3.9.x

2024-11-21 Thread Josep Prat
Hi all, Given 3.9 is the latest version before a major, and 4.0.0 comes with breaking changes (Zookeeper removal, Scala and Java version drops...) I think it's fair to assume that a considerable subset of Kafka users will be using 3.9 for a little longer than we usually support versions (roughly 1

[jira] [Created] (KAFKA-18058) Integrate offset cleanup algorithm with share coordinator

2024-11-21 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18058: --- Summary: Integrate offset cleanup algorithm with share coordinator Key: KAFKA-18058 URL: https://issues.apache.org/jira/browse/KAFKA-18058 Project: Kafka

[jira] [Created] (KAFKA-18057) Algorithm to calculate redundant interval of offsets for cleanup

2024-11-21 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18057: --- Summary: Algorithm to calculate redundant interval of offsets for cleanup Key: KAFKA-18057 URL: https://issues.apache.org/jira/browse/KAFKA-18057 Project: Kafka