Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

Hi Chia-Ping I think your suggestions is fair enough, I will modified the content proposal and index later. Best Regards, TengYao. Chia-Ping Tsai 於 2024年8月5日 週一 下午12:44寫道： > hi TengYao > > q0: > users will encounter config error if we remove the config `delete-config`, > and that is why we need

Re: [DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

hi TengYao q0: users will encounter config error if we remove the config `delete-config`, and that is why we need a KIP even `delete-config` is a no-op configuration. If above description is correct, could you please make motivation include it? q1: deleting the config is not critical, and hence w

[DISCUSS] KIP-1079: Deprecate `delete-config` of TopicCommand

Hello everyone, I would like to start a discussion about KIP-1079 . We plan to deprecate the `*delete-config*` command in *TopicCommand*, as it is a no-op. Please take a look, and if you hav

[jira] [Resolved] (KAFKA-15857) Introduce LocalLogStartOffset and TieredOffset in OffsetSpec.

[ https://issues.apache.org/jira/browse/KAFKA-15857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15857. --- Resolution: Fixed > Introduce LocalLogStartOffset and TieredOffset in OffsetSpec. >

[jira] [Resolved] (KAFKA-16154) Make broker changes to return an offset for LATEST_TIERED_TIMESTAMP

[ https://issues.apache.org/jira/browse/KAFKA-16154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16154. --- Resolution: Fixed > Make broker changes to return an offset for LATEST_TIERED_TIMESTAMP > --

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

I just trace these code, I think this proposal is clear enough. > Kuan Po Tseng 於 2024年8月5日 凌晨12:45 寫道： > > Thank you ! LGTM ! > > Best regards, > Kuan-Po Tseng > > On 2024/08/04 16:40:12 TengYao Chi wrote: >> Hello Kuan Po >> >> I just reviewed the code, and you are right. >> >> Currently,

Re: [PR] KAFKA-17146 Include note to remove migration znode [kafka-site]

ppatierno commented on code in PR #620: URL: https://github.com/apache/kafka-site/pull/620#discussion_r1703365750 ## 38/ops.html: ## @@ -4105,7 +4105,10 @@ Reverting to ZooKeeper mode During the Migration Using zookeeper-shell.sh, run r

Re: [PR] KAFKA-17146 Include note to remove migration znode [kafka-site]

chia7712 commented on code in PR #620: URL: https://github.com/apache/kafka-site/pull/620#discussion_r1703359268 ## 38/ops.html: ## @@ -4105,7 +4105,10 @@ Reverting to ZooKeeper mode During the Migration Using zookeeper-shell.sh, run rm

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Thank you ! LGTM ! Best regards, Kuan-Po Tseng On 2024/08/04 16:40:12 TengYao Chi wrote: > Hello Kuan Po > > I just reviewed the code, and you are right. > > Currently, Joined#gracePeriod is not in the JoinedInternal. I will slightly > modify the content of the KIP to avoid any misunderstanding

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello Kuan Po I just reviewed the code, and you are right. Currently, Joined#gracePeriod is not in the JoinedInternal. I will slightly modify the content of the KIP to avoid any misunderstandings. Thanks for pointing it out. Best Regards, TengYao Kuan Po Tseng 於 2024年8月5日 週一 上午12:30寫道： > Th

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Thank you for the nice KIP ! About deprecating Joined#gracePeriod, did you mean we should move the Joined#gracePeriod to JoinedInternal class as I didn't see the corresponding method in JoinedInternal you mentioned. Best regards, Kuan-Po Tseng On 2024/08/04 16:13:31 TengYao Chi wrote: > Hello

[DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

Hello everyone, I would like to start a discussion about KIP-1078 . We plan to deprecate the four public APIs in *org.apache.kafka.streams.kstream.Joined* that already have internal

Re: KIP-1077: Deprecate `ForeachProcessor` and move to internal package

I think this proposal is clear, so should move this class to internal package. > TengYao Chi 於 2024年8月4日 下午5:48 寫道： > > Cool, I have read the code at trunk, this class is only used in KStream. > I think this proposal is fair enough. > > Chia-Ping Tsai 於 2024年8月4日 週日 下午3:45寫道： > >> Thanks Kuan

Re: [DISCUSS] KIP-1062: Introduce Pagination for some requests used by Admin API

Hi Omnia, Thanks for this KIP, this is a valuable improvement, and apologies for my late feedback on this. IS1: Without an indication of how many pages or items are left, it is impossible for the client to calculate progress. Having the cursor in the response just indicates whether there are more

Re: KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Cool, I have read the code at trunk, this class is only used in KStream. I think this proposal is fair enough. Chia-Ping Tsai 於 2024年8月4日 週日 下午3:45寫道： > Thanks Kuan-Po for writing KIP-1077. LGTM > > Kuan Po Tseng 於 2024年8月4日 週日 下午2:34寫道： > > > Hello everyone, > > > > In KIP-1077 (https://cwiki.

[jira] [Created] (KAFKA-17261) Support to create a quorum controller which is not in cluster

Chia-Ping Tsai created KAFKA-17261: -- Summary: Support to create a quorum controller which is not in cluster Key: KAFKA-17261 URL: https://issues.apache.org/jira/browse/KAFKA-17261 Project: Kafka

[jira] [Created] (KAFKA-17260) Enhance new test infra

Chia-Ping Tsai created KAFKA-17260: -- Summary: Enhance new test infra Key: KAFKA-17260 URL: https://issues.apache.org/jira/browse/KAFKA-17260 Project: Kafka Issue Type: Improvement

Re: KIP-1077: Deprecate `ForeachProcessor` and move to internal package

Thanks Kuan-Po for writing KIP-1077. LGTM Kuan Po Tseng 於 2024年8月4日 週日 下午2:34寫道： > Hello everyone, > > In KIP-1077 (https://cwiki.apache.org/confluence/x/eA-OEg), we plan to > deprecate ForeachProcessor and move it to an internal package, as it is > intended for internal use only. > > If you hav

[jira] [Created] (KAFKA-17259) Support to override serverProperties and restart cluster in ClusterTestExtensions

PoAn Yang created KAFKA-17259: - Summary: Support to override serverProperties and restart cluster in ClusterTestExtensions Key: KAFKA-17259 URL: https://issues.apache.org/jira/browse/KAFKA-17259 Project: