Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

Hi Colin, Thank you for your feedback! Please find my comments/answers below: *> Nitpick: in the intro paragraph, "Operators of Apache Kafka clusters have literally no information about the clients connected to their clusters" seems a bit too strong. We have some information, right? For example

Re: About Testing Stream Applications Documentation

Hi Bruno, Let me see if it is possible to edit it for me. Regards, Ugur Yeter On Thu, 19 Sep 2019, 00:48 Bruno Cadonna, wrote: > Hi Ugur, > > Your finding looks correct to me. Do you mind fixing this issue? > > Best, > Bruno > > On Tue, Sep 17, 2019 at 12:54 PM uğur wrote: > > > > Hi, > > > >

Build failed in Jenkins: kafka-trunk-jdk11 #821

See Changes: [github] MINOR: Update dependencies for Kafka 2.4 (part 2) (#7333) -- [...truncated 2.63 MB...] org.apache.kafka.streams.TopologyTestDriverTest > shouldRetur

Build failed in Jenkins: kafka-trunk-jdk8 #3910

See Changes: [cmccabe] Add recent versions of Kafka to the matrix of ConnectDistributedTest -- [...truncated 2.44 MB...] kafka.api.SslEndToEndAuthorizationTest > testProd

Jenkins build is back to normal : kafka-trunk-jdk11 #820

See

Re: [VOTE] KIP-479 Add Materialized to Join

Good catch! I meant to propose the name to be "StreamJoin". I have updated the KIP accordingly. As for the name, I originally had "StreamJoined" and updated it after some comments on the KIP. I do feel that the name "StreamJoin" is better in this case since it is used to represent a stream join c

Re: [VOTE] KIP-479 Add Materialized to Join

Hello Bill, The KIP's proposal has the code snippet name as "StreamJoined" but the class name defined is StreamJoin.Which one did you propose? Personally I think StreamJoined with better aligned with other control objects, but if you think otherwise is better I can be convinced too :) Guozhang

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

Bump this thread to see if someone could also review! On Mon, Sep 9, 2019 at 5:00 PM Boyang Chen wrote: > Thank you Jason! Addressed the comments. > > Thank you Guozhang for explaining. I will document the timeout setting > reasoning in the design doc. > > > On Mon, Sep 9, 2019 at 1:49 PM Guozha

Re: [VOTE] KIP-479 Add Materialized to Join

All, since we have updated KIP-479 https://cwiki.apache.org/confluence/display/KAFKA/KIP-479%3A+Add+StreamJoin+config+object+to+Join and seem to have completed the discussion for the updates, I'd like to call for everyone to vote again. Thanks, Bill On Fri, Aug 2, 2019 at 10:46 AM Bill Bejeck wr

Re: [DISCUSS] KIP-479: Add Materialized to Join

Since we seem to have a consensus with the updated KIP, I'll start a re-vote thread. On Tue, Sep 17, 2019 at 9:51 PM John Roesler wrote: > Hi Bill, > > For the record, the current proposal looks good to me also. > > Thanks, > -John > > On Tue, Sep 17, 2019 at 5:06 PM Matthias J. Sax > wrote: >

Re: About Testing Stream Applications Documentation

Hi Ugur, Your finding looks correct to me. Do you mind fixing this issue? Best, Bruno On Tue, Sep 17, 2019 at 12:54 PM uğur wrote: > > Hi, > > I am not sure if it is the right email address to write about this topic, > please correct me if I am wrong. > > As I read documentation of Testing Stre

Re: [DISCUSS] KIP-519: Make SSL context/engine configuration extensible

Hi Clement Here are my thoughts based on my latest re-write attempt and learnings, 1. I think that it will be a great value to keep both classes separate - SslFactory and SslEngineFactory and having method reconfigurableConfigs() in the SslEngineFactory. Here is the reasoning, a. It is kind of

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

Hi Rajini, Thanks for the KIP. I think this will be a great improvement. For NumPartitions, ReplicationFactor, and Configs, we need some reasonable default value in the RPC which can be used for requests that are too old to contain this information. I'd suggest 0, 0, and null, respectively.

[jira] [Resolved] (KAFKA-8922) Failed to get end offsets for topic partitions of global store

[ https://issues.apache.org/jira/browse/KAFKA-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Gupta resolved KAFKA-8922. Resolution: Invalid Closing as the error had nothing to do with streams -- just general broker una

Build failed in Jenkins: kafka-trunk-jdk11 #819

See Changes: [jason] KAFKA-8841; Reduce overhead of ReplicaManager.updateFollowerFetchState -- [...truncated 2.63 MB...] org.apache.kafka.streams.processor.internals.Inte

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

That's fair. We could use the existing error code in the response and pass back something like INVALID_REQUEST. I'm not sure if we want to add an error string field just for this (although they're a good idea in general...) best, Colin On Wed, Sep 18, 2019, at 12:31, Magnus Edenhill wrote: >

Re: [DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

Hi Mickael, Just to give you the context, this is something that's been discussed several times. Check out https://issues.apache.org/jira/browse/KAFKA-5214 and https://issues.apache.org/jira/browse/KAFKA-5723 , as well as this pull request: https://github.com/apache/kafka/pull/3012 I think th

[jira] [Created] (KAFKA-8923) Revisit OnlineReplica state change in reassignments

Stanislav Kozlovski created KAFKA-8923: -- Summary: Revisit OnlineReplica state change in reassignments Key: KAFKA-8923 URL: https://issues.apache.org/jira/browse/KAFKA-8923 Project: Kafka

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

> I think we should force client software names and versions to follow a regular expression and disconnect if they do not. Disconnecting is not really a great error propagation method since it leaves the client oblivious to what went wrong. Instead suggest we return an ApiVersionResponse with an e

Build failed in Jenkins: kafka-trunk-jdk8 #3909

See Changes: [jason] KAFKA-8841; Reduce overhead of ReplicaManager.updateFollowerFetchState -- [...truncated 2.63 MB...] org.apache.kafka.streams.StreamsConfigTest > shou

Re: [VOTE] KIP-475: New Metric to Measure Number of Tasks on a Connector

I'd like to bump the thread to get review on the PR. https://github.com/apache/kafka/pull/6843 Thanks, all! On Wed, Jul 3, 2019 at 9:33 AM Cyrus Vafadari wrote: > Thanks for the input, everyone! I'm marking this KIP as accepted with > 3 binding votes (Gwen, Guozhang, Randall) > 3 nonbinding vot

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

Indeed, I have forgotten to add the action. There will be a new action « —delete-offsets ». Sorry! *Proposed API* kafka-consumer-groups.sh --bootstrap-server —delete-offsets --group --topic : ex: --bootstrap-server localhost:9092 --group my-group --topic topic1 --topic topic2:0,1,2 When partit

Re: [DISCUSS] Streams-Broker compatibility regression in 2.2.1 release

Thanks Ismael and Bill. It seems that nobody objects with the proposal. Hence, I prepared the following PR to update the upgrade notes. - https://github.com/apache/kafka/pull/7363 (trunk and 2.3) - https://github.com/apache/kafka/pull/7364 (2.2) - https://github.com/apache/kafka-site/pull/229

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

On Tue, Sep 17, 2019, at 09:07, David Jacot wrote: > Hi all, > > We haven't included the changes in the command line tool to support the new > API. Therefore, > I would like to amend the current KIP to cover the changes in the > `kafka-consumer-groups` > command line tool. The change is rather sma

Re: [VOTE] KIP-511: Collect and Expose Client's Name and Version in the Brokers

Hi David, Thanks for the KIP! Nitpick: in the intro paragraph, "Operators of Apache Kafka clusters have literally no information about the clients connected to their clusters" seems a bit too strong. We have some information, right? For example, the client ID, where clients are connecting fr

[jira] [Created] (KAFKA-8922) Failed to get end offsets for topic partitions of global store

Raman Gupta created KAFKA-8922: -- Summary: Failed to get end offsets for topic partitions of global store Key: KAFKA-8922 URL: https://issues.apache.org/jira/browse/KAFKA-8922 Project: Kafka Iss

[jira] [Created] (KAFKA-8921) Avoid excessive info logs in the client side for incremental fetch

Zhanxiang (Patrick) Huang created KAFKA-8921: Summary: Avoid excessive info logs in the client side for incremental fetch Key: KAFKA-8921 URL: https://issues.apache.org/jira/browse/KAFKA-8921

[jira] [Resolved] (KAFKA-8913) Document topic based configs & ISR settings for Streams apps

[ https://issues.apache.org/jira/browse/KAFKA-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar resolved KAFKA-8913. --- Resolution: Fixed > Document topic based configs & ISR settings for Streams apps > --

[jira] [Resolved] (KAFKA-8745) DumpLogSegments doesn't show keys, when the message is null

[ https://issues.apache.org/jira/browse/KAFKA-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Cheng resolved KAFKA-8745. Fix Version/s: 2.4.0 Reviewer: Guozhang Wang Resolution: Fixed > DumpLogSegments do

[jira] [Resolved] (KAFKA-8841) Optimize Partition.maybeIncrementLeaderHW

[ https://issues.apache.org/jira/browse/KAFKA-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8841. Resolution: Fixed > Optimize Partition.maybeIncrementLeaderHW > ---

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

+1 (non binding) Thanks for the KIP, I can see this being really useful! On Wed, Sep 18, 2019 at 4:40 PM Kevin Lu wrote: > > Hi All, > > Since we have a bit of support, I'd like to start the vote on KIP-517: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+ob

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

Thanks, Konstantine. I'm looking forward to a vote. On Wed, Sep 18, 2019 at 8:50 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Hi Randall. > > I'd also love to enable MDC by default. > However I agree with your concerns regarding compatibility. Runtime logs > are a form of public

[VOTE] KIP-517: Add consumer metrics to observe user poll behavior

Hi All, Since we have a bit of support, I'd like to start the vote on KIP-517: https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+observe+user+poll+behavior Thanks! Regards, Kevin

Re: [VOTE] KIP-373: Allow users to create delegation tokens for other users

Hi All, Harsha, Ryanne: thanks for the vote! I'd like to bump this again as today is the KIP freeze date and there is still one binding vote needed which I'm hoping to get in order to have this included in 2.4. Thanks, Viktor On Tue, Sep 17, 2019 at 1:18 AM Ryanne Dolan wrote: > +1 non-bindin

Build failed in Jenkins: kafka-trunk-jdk11 #818

See Changes: [matthias] KAFKA-8913: Document topic based configs & ISR settings for Streams apps -- [...truncated 2.40 MB...] kafka.controller.ControllerChannelManagerTe

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

Hi Randall. I'd also love to enable MDC by default. However I agree with your concerns regarding compatibility. Runtime logs are a form of public interface (as I believe has been discussed before) and therefore enabling MDC in the console requires a major version bump. Now, enabling it only for th

Build failed in Jenkins: kafka-trunk-jdk8 #3908

See Changes: [ismael] MINOR: Remove duplicate definition of transactional.id.expiration.ms [bbejeck] remove unused import (#7345) [matthias] KAFKA-8913: Document topic based configs & ISR settings for Streams

[jira] [Created] (KAFKA-8920) Provide a new properties to enable/disable expired-token-cleaner scheduler

Chatchavit Nitipongpun created KAFKA-8920: - Summary: Provide a new properties to enable/disable expired-token-cleaner scheduler Key: KAFKA-8920 URL: https://issues.apache.org/jira/browse/KAFKA-8920