Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure

2019-05-08 Thread Gwen Shapira
+1 (binding) Thank you! I especially like the new metric for tracking the partitions with errors. Its those little things :) On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune wrote: > Hi All! > > I would like to call for a vote on KIP-461 that would improve the behavior > of replica fetcher in case

[jira] [Created] (KAFKA-8343) streams application crashed due to rocksdb

2019-05-08 Thread gaoshu (JIRA)
gaoshu created KAFKA-8343: - Summary: streams application crashed due to rocksdb Key: KAFKA-8343 URL: https://issues.apache.org/jira/browse/KAFKA-8343 Project: Kafka Issue Type: Bug Componen

Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure

2019-05-08 Thread Dhruvil Shah
Thanks for the KIP! +1 (non-binding) On Wed, May 8, 2019 at 10:23 PM Colin McCabe wrote: > +1. Thanks, Aishwarya. > > Colin > > On Wed, May 8, 2019, at 17:50, Jason Gustafson wrote: > > +1. Thanks! > > > > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune > > wrote: > > > > > Hi All! > > > > > > I

Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure

2019-05-08 Thread Colin McCabe
+1. Thanks, Aishwarya. Colin On Wed, May 8, 2019, at 17:50, Jason Gustafson wrote: > +1. Thanks! > > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune > wrote: > > > Hi All! > > > > I would like to call for a vote on KIP-461 that would improve the behavior > > of replica fetcher in case of partit

[VOTE] KIP-455: Create an Administrative API for Replica Reassignment

2019-05-08 Thread Colin McCabe
Hi all, I'd like to start the vote for KIP-455: Create an Administrative API for Replica Reassignment. I think this KIP is important since it will unlock many follow-on improvements to Kafka reassignment (see the "Future work" section, plus a lot of the other discussions we've had recently abo

[jira] [Resolved] (KAFKA-8284) Enable static membership on KStream

2019-05-08 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-8284. Resolution: Fixed > Enable static membership on KStream > --- > >

Jenkins build is back to normal : kafka-trunk-jdk8 #3611

2019-05-08 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk11 #500

2019-05-08 Thread Apache Jenkins Server
See Changes: [wangguoz] MINOR: cleanup policy doc update (#6692) -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H29 (ub

[jira] [Created] (KAFKA-8342) Admin tool to setup Kafka Stream topology (internal) topics

2019-05-08 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8342: -- Summary: Admin tool to setup Kafka Stream topology (internal) topics Key: KAFKA-8342 URL: https://issues.apache.org/jira/browse/KAFKA-8342 Project: Kafka Issue

Re: [DISCUSS] KIP-429 : Smooth Auto-Scaling for Kafka Streams

2019-05-08 Thread Guozhang Wang
Hello all, Thanks for everyone who've shared their feedbacks for this KIP! If there's no further comments I'll start the voting thread by end of tomorrow. Guozhang. On Wed, May 8, 2019 at 6:36 PM Guozhang Wang wrote: > Hello Boyang, > > On Wed, May 1, 2019 at 4:51 PM Boyang Chen wrote: > >>

Re: [DISCUSS] KIP-429 : Smooth Auto-Scaling for Kafka Streams

2019-05-08 Thread Guozhang Wang
Hello Boyang, On Wed, May 1, 2019 at 4:51 PM Boyang Chen wrote: > Hey Guozhang, > > thank you for the great write up. Overall the motivation and changes LGTM, > just some minor comments: > > > 1. In "Consumer Coordinator Algorithm", we could reorder alphabet > points for 3d~3f from ["ready-to

Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure

2019-05-08 Thread Jason Gustafson
+1. Thanks! On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune wrote: > Hi All! > > I would like to call for a vote on KIP-461 that would improve the behavior > of replica fetcher in case of partition failure. The fetcher thread would > just stop monitoring the crashed partition instead of terminatin

Re: [VOTE] KIP-458: Connector Client Config Override Policy

2019-05-08 Thread Magesh Nandakumar
Thanks a lot Chris. So far, the KIP has one non-binding vote and I'm still looking forward to the KIP to be voted by Friday's deadline. On Tue, May 7, 2019 at 10:00 AM Chris Egerton wrote: > Hi Magesh, > > This looks great! Very excited to see these changes finally coming to > Connect. > +1 (non

[VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure

2019-05-08 Thread Aishwarya Gune
Hi All! I would like to call for a vote on KIP-461 that would improve the behavior of replica fetcher in case of partition failure. The fetcher thread would just stop monitoring the crashed partition instead of terminating. Here's a link to the KIP - https://cwiki.apache.org/confluence/display/KA

[jira] [Reopened] (KAFKA-7830) Convert Kafka RPCs to use automatically generated code

2019-05-08 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reopened KAFKA-7830: > Convert Kafka RPCs to use automatically generated code >

[jira] [Resolved] (KAFKA-8196) Replace InitProducerId request/response with automated protocol

2019-05-08 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-8196. Resolution: Fixed > Replace InitProducerId request/response with automated protocol > -

[jira] [Resolved] (KAFKA-7830) Convert Kafka RPCs to use automatically generated code

2019-05-08 Thread Boyang Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-7830. Resolution: Fixed > Convert Kafka RPCs to use automatically generated code > --

Re: [DISCUSS] KIP-461 - Improving replica fetcher behavior in case of partition failures

2019-05-08 Thread Aishwarya Gune
Hi Jun! Yes, we should exclude. When a replica is deleted with StopReplicaRequest, the partition is removed from the set of failed partitions. Will update the KIP to mention it. On Wed, May 8, 2019 at 1:59 PM Jun Rao wrote: > Hi, Aishwarya, > > Thanks for the KIP. Looks good to me. Just one min

Build failed in Jenkins: kafka-trunk-jdk8 #3610

2019-05-08 Thread Apache Jenkins Server
See Changes: [bbejeck] BUGFIX: Add missing recording of close of stand-by task (#6663) -- [...truncated 4.64 MB...] kafka.server.MultipleListenersWithDefaultJaasContextTe

Re: [VOTE] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Chris Egerton
Hi all, I am closing this vote as it has been open for six days now and has achieved lazy majority. Thanks to everyone who voted! Summary: Binding (+3): Randall Hauch, Manikumar Reddy, Rajini Sivaram Non-binding (+2): Magesh Nandakumar, Konstantine Karantasis If you'd like to check out the imple

[jira] [Created] (KAFKA-8341) AdminClient should retry coordinator lookup after NOT_COORDINATOR error

2019-05-08 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-8341: -- Summary: AdminClient should retry coordinator lookup after NOT_COORDINATOR error Key: KAFKA-8341 URL: https://issues.apache.org/jira/browse/KAFKA-8341 Project: Ka

[jira] [Created] (KAFKA-8340) ServiceLoader fails when used from isolated plugin path directory

2019-05-08 Thread Chris Egerton (JIRA)
Chris Egerton created KAFKA-8340: Summary: ServiceLoader fails when used from isolated plugin path directory Key: KAFKA-8340 URL: https://issues.apache.org/jira/browse/KAFKA-8340 Project: Kafka

[jira] [Created] (KAFKA-8339) At-least-once delivery guarantee seemingly not met due to async commit / produce failure race condition

2019-05-08 Thread tdp (JIRA)
tdp created KAFKA-8339: -- Summary: At-least-once delivery guarantee seemingly not met due to async commit / produce failure race condition Key: KAFKA-8339 URL: https://issues.apache.org/jira/browse/KAFKA-8339 Pro

Re: [DISCUSS] KIP-461 - Improving replica fetcher behavior in case of partition failures

2019-05-08 Thread Jun Rao
Hi, Aishwarya, Thanks for the KIP. Looks good to me. Just one minor comment. If a replica is deleted on a broker (through a StopReplicaRequest) while it's in the failed partition set, should we exclude that partition from the set and the FailedPartitionsCount? Jun On Mon, May 6, 2019 at 1:21 PM

[VOTE] 2.2.1 RC0

2019-05-08 Thread Vahid Hashemian
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 2.2.1, which includes many bug fixes for Apache Kafka 2.2. Release notes for the 2.2.1 release: https://home.apache.org/~vahid/kafka-2.2.1-rc0/RELEASE_NOTES.html *** Please download, test

Re: [VOTE] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Rajini Sivaram
Hi Chris, Thanks for the KIP, +1 (binding) Regards, Rajini On Wed, May 8, 2019 at 7:28 PM Manikumar wrote: > Hi Chris, > > +1 (binding). Thanks for the KIP. > > Thanks, > Manikumar > > On Tue, May 7, 2019 at 2:55 AM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Nice and us

Re: [DISCUSS] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Rajini Sivaram
Hi Chris, Thanks for the explanation. Since there are workarounds and we are not making it any worse, this should be fine. Regards, Rajini On Wed, May 8, 2019 at 8:06 PM Chris Egerton wrote: > Hi Rajini, > > That was an initial concern of mine as well but I think we should be fine. > Connect

[jira] [Resolved] (KAFKA-8049) remove KafkaMbean when network close

2019-05-08 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8049. Resolution: Duplicate > remove KafkaMbean when network close >

Re: [DISCUSS] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Chris Egerton
Hi Rajini, That was an initial concern of mine as well but I think we should be fine. Connect REST extensions are already capable of intercepting requests that contain new connector configurations, through POST calls to the /connectors endpoint and PUT calls to /connectors//config. The additional

[jira] [Resolved] (KAFKA-8050) remove KafkaMbean when network close

2019-05-08 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8050. Resolution: Duplicate > remove KafkaMbean when network close >

[jira] [Resolved] (KAFKA-8048) remove KafkaMbean when network close

2019-05-08 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8048. Resolution: Duplicate > remove KafkaMbean when network close >

[jira] [Resolved] (KAFKA-8051) remove KafkaMbean when network close

2019-05-08 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8051. Resolution: Duplicate > remove KafkaMbean when network close >

[jira] [Created] (KAFKA-8338) Improve consumer offset expiration logic to take subscription into account

2019-05-08 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-8338: --- Summary: Improve consumer offset expiration logic to take subscription into account Key: KAFKA-8338 URL: https://issues.apache.org/jira/browse/KAFKA-8338 Project: Kafka

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-08 Thread John Roesler
Hi Daniyar, No worries about the procedural stuff. Prior experience with KIPs is not required :) I was just trying to help you propose this stuff in a way that the others will find easy to review. Thanks for updating the KIP. Thanks to the others for helping out with the syntax. Given these upd

Re: [VOTE] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Manikumar
Hi Chris, +1 (binding). Thanks for the KIP. Thanks, Manikumar On Tue, May 7, 2019 at 2:55 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Nice and useful KIP. Thanks Chris! > > +1 (non-binding) > > Konstantine > > > On Fri, May 3, 2019 at 5:14 PM Randall Hauch wrote: > > > Nice

Re: [DISCUSS] KIP-454: Expansion of the ConnectClusterState interface

2019-05-08 Thread Rajini Sivaram
Hi Chris, Thanks for the KIP, looks good. I have just one question. Can ` ConnectClusterState#connectorConfig()` return any sensitive configs like passwords? Thanks, Rajini On Wed, May 8, 2019 at 1:30 AM Chris Egerton wrote: > Hi all, > > Now that KAFKA-8304 (https://issues.apache.org/jira/b

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-08 Thread Development
Hey, That worked! I certainly lack Java generics knowledge. Thanks for the snippet. I’ll update KIP again. Best, Daniyar Yeralin > On May 8, 2019, at 1:39 PM, Chris Egerton wrote: > > Hi Daniyar, > > I think you may want to tweak your syntax a little: > > public static Serde> List(Serde in

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-08 Thread Chris Egerton
Hi Daniyar, I think you may want to tweak your syntax a little: public static Serde> List(Serde innerSerde) { return new ListSerde(innerSerde); } Does that work? Cheers, Chris On Wed, May 8, 2019 at 10:29 AM Development wrote: > Hi John, > > I updated JIRA and KIP. > > I didn’t know abou

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-08 Thread Sophie Blee-Goldman
Hi Daniyar, Thanks for the KIP! I had to write my own List serde for testing a while back and this definitely would have saved me some time. Regarding the static declaration, I believe you're missing a between "public static" and the return type "Serde>" -- Java should allow this Cheers, Sophie

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-08 Thread Development
Hi John, I updated JIRA and KIP. I didn’t know about the process, and created PR before I knew about KIPs :) As per static declaration, I don’t think Java allows that: Best, Daniyar Yeralin > On May 7, 2019, at 2:22 PM, John Roesler wrote: > > Thanks for that update. Do you mind making cha

Build failed in Jenkins: kafka-trunk-jdk11 #499

2019-05-08 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-7320; Add consumer configuration to disable auto topic creation -- Started by an SCM change [EnvInject] - Loading node environment variables. Bu

Re: [DISCUSS] KIP-461 - Improving replica fetcher behavior in case of partition failures

2019-05-08 Thread Jason Gustafson
Hey Aishwarya, Thanks for the KIP. I'd suggest we move to a vote since this is a straightforward improvement with a large impact. -Jason On Tue, May 7, 2019 at 3:02 PM Aishwarya Gune wrote: > Hi Colin! > > Whenever the thread has all of its partitions marked as failed (i.e. thread > is idle),

Re: [DISCUSS] KIP-461 - Improving replica fetcher behavior in case of partition failures

2019-05-08 Thread Colin McCabe
Thanks-- that makes sense. cheers, Colin On Tue, May 7, 2019, at 15:02, Aishwarya Gune wrote: > Hi Colin! > > Whenever the thread has all of its partitions marked as failed (i.e. thread > is idle), the thread would be shut down. > The errors that are not per-partition would probably retry or beh

[jira] [Resolved] (KAFKA-7320) Provide ability to disable auto topic creation in KafkaConsumer

2019-05-08 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7320. Resolution: Fixed Fix Version/s: 2.3.0 > Provide ability to disable auto topic creat

Build failed in Jenkins: kafka-trunk-jdk11 #498

2019-05-08 Thread Apache Jenkins Server
See Changes: [bbejeck] BUGFIX: Add missing recording of close of stand-by task (#6663) -- Started by an SCM change [EnvInject] - Loading node environment variables. Buildi

Re: apply to be a contributor

2019-05-08 Thread Guozhang Wang
Hello Wei, I've added you to the contributor list. Cheers. Guozhang On Wed, May 8, 2019 at 8:57 AM 魏巍 wrote: > | > Hi, > > I want to contribute to Apache Kafka. > Would you please give methe contributor permission? > My JIRA ID is doubleWei. > | -- -- Guozhang

I want to be apache kafka contributer

2019-05-08 Thread 魏巍
I want to be apache kafka contributer

apply to be a contributor

2019-05-08 Thread 魏巍
| Hi, I want to contribute to Apache Kafka. Would you please give methe contributor permission? My JIRA ID is doubleWei. |

Re: Apply for JIRA contributor permission

2019-05-08 Thread Bill Bejeck
Done. Thanks for contributing! -Bill On Wed, May 8, 2019 at 11:15 AM Kengo Seki wrote: > Hi, > > I just filed KAFKA-8337 and would like to assign it to myself. > Would you add me to the contributors list? > My username is "sekikn". > > Thanks in advance! > > Kengo Seki >

Apply for JIRA contributor permission

2019-05-08 Thread Kengo Seki
Hi, I just filed KAFKA-8337 and would like to assign it to myself. Would you add me to the contributors list? My username is "sekikn". Thanks in advance! Kengo Seki

[jira] [Created] (KAFKA-8337) Fix tests/setup.cfg to work with pytest 4.x

2019-05-08 Thread Kengo Seki (JIRA)
Kengo Seki created KAFKA-8337: - Summary: Fix tests/setup.cfg to work with pytest 4.x Key: KAFKA-8337 URL: https://issues.apache.org/jira/browse/KAFKA-8337 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver

2019-05-08 Thread John Roesler
Hi Jukka, thanks for the reply! I think this is a good summary (the discussion was getting a little unwieldy. I'll reply inline. Also, thanks for clarify about your library vs. this KIP. That makes perfect sense to me. > > 1. Add JavaDoc for KIP > > Is there a good example of KIP where Javadoc is

Build failed in Jenkins: kafka-trunk-jdk8 #3609

2019-05-08 Thread Apache Jenkins Server
See Changes: [cshapi] MINOR: correctly parse version OffsetCommitResponse version < 3 [github] KAFKA-8158: Add EntityType for Kafka RPC fields (#6503) -- [...truncated 4.

Re: Cleaning up command line tools argument parsing a little

2019-05-08 Thread Viktor Somogyi-Vass
Hi Sönke, In KAFKA-1774 I have created a Kafka Shell java tool that unfortunately didn't get much attention so far from the creators of the jira. It works similarly to what Colin mentioned, like "kafka.sh topics create -n my-topic -p 3 -r 3" or has long names like "kafka.sh topics create --name my

Re: Cleaning up command line tools argument parsing a little

2019-05-08 Thread Viktor Somogyi-Vass
Just to add: I wasn't too pushy by raising a KIP for this as so far I had the experience that the community is fine with them or at least people learned to live with the current tools but if there's a need I'd be happy to jump back working on it or helping you if you have time :) On Wed, May 8, 20

[jira] [Created] (KAFKA-8336) Enable dynamic update of client-side SSL factory in brokers

2019-05-08 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-8336: - Summary: Enable dynamic update of client-side SSL factory in brokers Key: KAFKA-8336 URL: https://issues.apache.org/jira/browse/KAFKA-8336 Project: Kafka

Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver

2019-05-08 Thread Jukka Karvanen
Hi, This KIP is relating to add classes to kafka-stream-test-utils. My initial plan was to create new project for these helper classes before I decided to contribute directly to Apache Kafka with this KIP. I have one streams project where I have used these classes, that is why I planned to release

Build failed in Jenkins: kafka-trunk-jdk8 #3608

2019-05-08 Thread Apache Jenkins Server
See Changes: [rhauch] KAFKA-8304: Fix registration of Connect REST extensions (#6651) [wangguoz] KAFKA-8284: enable static membership on KStream (#6673) -- [...truncated

[jira] [Created] (KAFKA-8335) Log cleaner skips Transactional mark and batch record, causing unlimited growth of __consumer_offsets

2019-05-08 Thread Boquan Tang (JIRA)
Boquan Tang created KAFKA-8335: -- Summary: Log cleaner skips Transactional mark and batch record, causing unlimited growth of __consumer_offsets Key: KAFKA-8335 URL: https://issues.apache.org/jira/browse/KAFKA-8335