Hi Jun! Yes, we should exclude. When a replica is deleted with StopReplicaRequest, the partition is removed from the set of failed partitions. Will update the KIP to mention it.
On Wed, May 8, 2019 at 1:59 PM Jun Rao <j...@confluent.io> wrote: > Hi, Aishwarya, > > Thanks for the KIP. Looks good to me. Just one minor comment. If a replica > is deleted on a broker (through a StopReplicaRequest) while it's in the > failed partition set, should we exclude that partition from the set and > the FailedPartitionsCount? > > Jun > > On Mon, May 6, 2019 at 1:21 PM Aishwarya Gune <aishwa...@confluent.io> > wrote: > > > Hey All! > > > > I have created a KIP to improve the behavior of replica fetcher when > > partition failure occurs. Please do have a look at it and let me know > what > > you think. > > KIP 461 - > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure > > > > -- > > Thank you, > > Aishwarya > > > -- Thank you, Aishwarya
