[
https://issues.apache.org/jira/browse/KAFKA-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-4721.
Resolution: Implemented
> KafkaStreams (and possibly others) should inherit Closeable
> ---
Hey Guozhang,
thanks a lot for proposing the KIP so fast! Two high level comments are:
1. In the code we define the function to extract admin client id as
`getShardAdminClientId`. Do we also want to add `shared` keyword in the public
API so that people know the admin client is not per-thread
Hey Matthias,
thanks for taking a look! It would be great to see this pushed in 2.2.
Depending on the tight timeline, I hope to at least get the KIP approved so
that we don't see back and forth again as the KTable API has been constantly
changing. I couldn't guarantee the implementation timelin
Boyang Chen created KAFKA-7816:
--
Summary: Windowed topic should have window size as part of the
metadata
Key: KAFKA-7816
URL: https://issues.apache.org/jira/browse/KAFKA-7816
Project: Kafka
Iss
Do you want to get this into 2.2 release? KIP deadline is 1/24, so quite
soon.
Overall, the KIP is very useful. I can review again in more details if
you aim for 2.2 -- did you address all previous comment about the KIP
already?
-Matthias
On 1/8/19 2:50 PM, Boyang Chen wrote:
> Hey folks,
>
I also want to point out, that Ryanne Dolan commented on the WIP PR
(https://github.com/apache/kafka/pull/6044) about the naming. I asked
him to reply to this thread, but this did no happen yet, thus I want to
point it out myself, because it seems to important.
WindowWithTimestampStore.java
> Ha
Bill,
I left the question about legacy column family out, because as a matter
of fact, we use the default column family atm that cannot be deleted.
Thus, this old column family will always be there.
Nevertheless, as an implementation detail, it might make sense to avoid
accessing both column fami
Thanks for the KIP.
One side comment about rejected alternatives. I would remove the
sentence, because `StreamsMetadata` is part of IQ feature and not
related at all to this change -- thus, it does not seem to be a valid
alternative.
+1 (binding)
-Matthias
On 1/11/19 5:47 AM, Bill Bejeck wrot
Just catching up on this KIP again.
One nit. The KIP says:
> In addition, the generated names have a few disadvantages to guarantee
> topology compatibilities. In fact, adding a new operator, using a
> third-library doing some optimization to remove some operators or upgrading
> to a new Kafka
Thanks for the summary Colin.
One remark from my side: I have my doubts that topic priorities make
sense for Kafka Streams (at least not for the DSL).
Thus, I would suggest to limit this KIP to the consumer only, otherwise,
the scope will be too large and this KIP will drag on even longer. If we
10 matches
Mail list logo
