Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 8, 2015, 6:24 a.m.) Review request for kafka. Bugs: KAFKA-972

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618050#comment-14618050 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-07_23:24:13.patch > MetadataRequest returns stale list of brokers > -

Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Ashish Singh
> On July 8, 2015, 12:52 a.m., Jun Rao wrote: > > Thanks for the patch. Saw the following transient unit test failure. > > > > kafka.integration.TopicMetadataTest > > > testIsrAfterBrokerShutDownAndJoinsBack FAILED > > junit.framework.AssertionFailedError: Topic metadata is not correctly >

Re: Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Ewen Cheslack-Postava
Ah, that makes sense, thanks for finding that. We could alternatively use build/** to avoid everything under build, or include a more complete list via .gitignore instead (although that would have to be done carefully since the pattern matching works differently). Unfortunately grgit is required to

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618034#comment-14618034 ] Joe Stein commented on KAFKA-2310: -- Hey [~jjkoshy] I had suggested to Andrii that it migh

Build failed in Jenkins: KafkaPreCommit #141

2015-07-07 Thread Apache Jenkins Server
See Changes: [jjkoshy] Trivial commit - explicitly exclude build/rat-report.xml from rat check -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu legacy-ubuntu) in workspace

Re: Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Joel Koshy
> explicitly specify an exclude for build/rat/rat-report.xml (btw, I went ahead with a trivial commit for the above - let me know if there are any concerns) On Tue, Jul 07, 2015 at 09:44:27PM -0700, Joel Koshy wrote: > You can reproduce the rat failure by running: ./gradlew clean && > gradlew tes

Jenkins build is back to normal : Kafka-trunk #532

2015-07-07 Thread Apache Jenkins Server
See

Re: Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Joel Koshy
You can reproduce the rat failure by running: ./gradlew clean && gradlew test If you run gradlew test again it does not report any error. build.gradle uses Grgit to expand the gitignore files to exclude. For a clean build, the build directory does not exist (yet). So it is not excluded by rat.

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617949#comment-14617949 ] Gwen Shapira commented on KAFKA-2308: - Actually, looks likely that it is Snappy (even

Build failed in Jenkins: Kafka-trunk #531

2015-07-07 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-2298; Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient; reviewed by Jason Gustafson and Joel Koshy -- Started by an SCM ch

Build failed in Jenkins: KafkaPreCommit #140

2015-07-07 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-2298; Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient; reviewed by Jason Gustafson and Joel Koshy -- Started by an SCM

[jira] [Comment Edited] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617878#comment-14617878 ] Gwen Shapira edited comment on KAFKA-2308 at 7/8/15 2:54 AM: -

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617887#comment-14617887 ] Gwen Shapira commented on KAFKA-2308: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2308: Status: Patch Available (was: Open) > New producer + Snappy face un-compression errors after broker

[jira] [Updated] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2308: Attachment: KAFKA-2308.patch > New producer + Snappy face un-compression errors after broker restart

Review Request 36290: Patch for KAFKA-2308

2015-07-07 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36290/ --- Review request for kafka. Bugs: KAFKA-2308 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617878#comment-14617878 ] Gwen Shapira commented on KAFKA-2308: - Thanks for your comments, [~guozhang]. Closing

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-07 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617849#comment-14617849 ] Aditya Auradkar commented on KAFKA-2205: [~junrao] - Addressed your comments. Can

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-07 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 8, 2015, 2:13 a.m.) Review request for kafka and Joel Koshy. Bu

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-07 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-07_19:12:15.patch > Generalize TopicConfigManager to handle

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-07 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617845#comment-14617845 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard https://reviews.a

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-07 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 8, 2015, 2:12 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-07 Thread Aditya Auradkar
> On July 7, 2015, 2:18 a.m., Jun Rao wrote: > > Thanks for the patch. A few more comments below. > > > > 1. The patch doesn't apply. Could you rebase? > > 2. Also, we need the logic to read all existing client configs. Is that in > > a separate jira? 1. Will do. 2. Hey Jun - I didn't understa

request forwarding in Kafka?

2015-07-07 Thread Qi Xu
Hi Kafka folks, I'm investigating about using Kafka as a data ingress endpoint for our analytic service. In our scenario, Kafka cluster is behind NLB which has a public IP, and the data source service is under another public IP. Basically the data source service cannot access Kafka cluster nodes

Re: Review Request 35791: Patch for KAFKA-2298

2015-07-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review90847 --- Ship it! Ship It! - Joel Koshy On June 24, 2015, 8 p.m., Dong Li

Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90843 --- Thanks for the patch. Saw the following transient unit test failure.

Re: Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Jun Rao
Ewen, We did have at least one successful run ( https://builds.apache.org/job/Kafka-trunk/526/console) after the rat patch. Perhaps you can file an Apache infra ticket to figure out why other runs fail? Thanks, Jun On Tue, Jul 7, 2015 at 11:16 AM, Ewen Cheslack-Postava wrote: > Is there a way

[jira] [Created] (KAFKA-2319) After controlled shutdown: IllegalStateException: Kafka scheduler has not been started

2015-07-07 Thread Jason Rosenberg (JIRA)
Jason Rosenberg created KAFKA-2319: -- Summary: After controlled shutdown: IllegalStateException: Kafka scheduler has not been started Key: KAFKA-2319 URL: https://issues.apache.org/jira/browse/KAFKA-2319

[jira] [Commented] (KAFKA-2231) Deleting a topic fails

2015-07-07 Thread James G. Haberly (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617601#comment-14617601 ] James G. Haberly commented on KAFKA-2231: - I deleted just one topic and tried to s

[jira] [Updated] (KAFKA-2318) replica manager repeatedly tries to fetch from partitions already moved during controlled shutdown

2015-07-07 Thread Jason Rosenberg (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rosenberg updated KAFKA-2318: --- Description: Using version 0.8.2.1. During a controlled shutdown, it seems like the left-hand

[jira] [Commented] (KAFKA-2318) replica manager repeatedly tries to fetch from partitions already moved during controlled shutdown

2015-07-07 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617551#comment-14617551 ] Jiangjie Qin commented on KAFKA-2318: - We introduced a replica fetcher back off time i

Build failed in Jenkins: Kafka-trunk #530

2015-07-07 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2317: follow-up of KAFKA1367; reviewed by Guozhang Wang [wangguoz] KAFKA-2313: javadoc fix for KafkaConsumer deserialization; reviewed by Guozhang Wang -- Started by an

[jira] [Updated] (KAFKA-2313) javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2313: - Resolution: Fixed Status: Resolved (was: Patch Available) > javadoc fix for KafkaConsumer

Build failed in Jenkins: KafkaPreCommit #139

2015-07-07 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2306: add another metric for buffer exhausted; reviewed by Guozhang Wang [wangguoz] KAFKA-2317: follow-up of KAFKA1367; reviewed by Guozhang Wang [wangguoz] KAFKA-2313: javadoc fix for KafkaConsumer deseri

[jira] [Commented] (KAFKA-2313) javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617349#comment-14617349 ] Guozhang Wang commented on KAFKA-2313: -- Thanks for the patch. Committed to trunk. >

[jira] [Updated] (KAFKA-2313) javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2313: - Fix Version/s: 0.8.3 > javadoc fix for KafkaConsumer deserialization > ---

Re: Review Request 36249: javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36249/#review90775 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 8:16 p.m., On

[jira] [Commented] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617328#comment-14617328 ] Ashish K Singh commented on KAFKA-2317: --- Thanks [~guozhang]! > De-register isrChang

[jira] [Updated] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2317: - Fix Version/s: 0.8.3 > De-register isrChangeNotificationListener on controller resignation > -

[jira] [Updated] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2317: - Resolution: Fixed Status: Resolved (was: Patch Available) > De-register isrChangeNotifica

[jira] [Commented] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617322#comment-14617322 ] Guozhang Wang commented on KAFKA-2317: -- Committed to trunk. Thanks. > De-register i

Re: Review Request 36270: Patch for KAFKA-2317

2015-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36270/#review90773 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 6:14 p.m., As

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

2015-07-07 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617319#comment-14617319 ] Ismael Juma commented on KAFKA-2187: Once we transition to the new way, we also need t

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

2015-07-07 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617311#comment-14617311 ] Ismael Juma commented on KAFKA-2187: [~nehanarkhede], I added a section to Patch Submi

Build failed in Jenkins: Kafka-trunk #529

2015-07-07 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2306: add another metric for buffer exhausted; reviewed by Guozhang Wang -- [...truncated 1492 lines...] kafka.log.LogTest > testParseTopicPartitionNameForMissingPartiti

[jira] [Updated] (KAFKA-2313) javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2313: Attachment: KAFKA-2313_2015-07-07_13:16:00.patch > javadoc fix for KafkaConsumer deserialization > -

[jira] [Commented] (KAFKA-2313) javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617297#comment-14617297 ] Onur Karaman commented on KAFKA-2313: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 36249: javadoc fix for KafkaConsumer deserialization

2015-07-07 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36249/ --- (Updated July 7, 2015, 8:16 p.m.) Review request for kafka. Bugs: KAFKA-2313

[jira] [Commented] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617286#comment-14617286 ] ASF GitHub Bot commented on KAFKA-2304: --- Github user sslavic closed the pull request

[GitHub] kafka pull request: KAFKA-2304: Supported enabling JMX in Kafka Va...

2015-07-07 Thread sslavic
Github user sslavic closed the pull request at: https://github.com/apache/kafka/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2231) Deleting a topic fails

2015-07-07 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617277#comment-14617277 ] Flavio Junqueira commented on KAFKA-2231: - bq. It is a test system. 1 ZooKeeper in

[jira] [Commented] (KAFKA-2296) Not able to delete topic on latest kafka

2015-07-07 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617268#comment-14617268 ] Flavio Junqueira commented on KAFKA-2296: - I'm wondering if this is a duplicate of

[jira] [Updated] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-07-07 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated KAFKA-2300: Assignee: Flavio Junqueira > Error in controller log when broker tries to rejoin cluster > -

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2295: - Status: In Progress (was: Patch Available) > Dynamically loaded classes (encoders, etc.) may not

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2306: - Resolution: Fixed Status: Resolved (was: Patch Available) > New producer should emit metr

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617252#comment-14617252 ] Guozhang Wang commented on KAFKA-2306: -- Thanks for the patch. Committed to trunk. >

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90765 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 5:47 p.m., Do

[jira] [Created] (KAFKA-2318) replica manager repeatedly tries to fetch from partitions already moved during controlled shutdown

2015-07-07 Thread Jason Rosenberg (JIRA)
Jason Rosenberg created KAFKA-2318: -- Summary: replica manager repeatedly tries to fetch from partitions already moved during controlled shutdown Key: KAFKA-2318 URL: https://issues.apache.org/jira/browse/KAFKA-23

Re: Add as contributor

2015-07-07 Thread Guozhang Wang
Hi Flavio, Just added you. Cheers, Guozhang On Tue, Jul 7, 2015 at 11:57 AM, Flavio P JUNQUEIRA wrote: > Could any of the kafka gods please add me as a contributor on jira? > > Thank you! > -Flavio > -- -- Guozhang

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617206#comment-14617206 ] Guozhang Wang commented on KAFKA-2308: -- Hi [~gwenshap] thanks for the findings. Yes f

Re: Review Request 36242: Patch for KAFKA-2311

2015-07-07 Thread Guozhang Wang
> On July 7, 2015, 5:31 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 987 > > > > > > This check could even be removed -- if acquire() su

Add as contributor

2015-07-07 Thread Flavio P JUNQUEIRA
Could any of the kafka gods please add me as a contributor on jira? Thank you! -Flavio

Re: Newbie ducktape questions :)

2015-07-07 Thread Geoffrey Anderson
Hi Gwen, Congrats on becoming a committer! I submitted a (ducktape) pull request for the cluster size issue here: https://github.com/confluentinc/ducktape/pull/67 which hopefully makes the error less confusing. Maybe we can punt on the slightly funky Vagrantfile.local setup in the Kafka reposito

Build failed in Jenkins: Kafka-trunk #528

2015-07-07 Thread Apache Jenkins Server
See Changes: [joe.stein] KAFKA-2304 Supported enabling JMX in Kafka Vagrantfile patch by Stevo Slavic reviewed by Ewen Cheslack-Postava -- Started by an SCM change Building remotely on H10 (Ubuntu ub

Re: Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Ewen Cheslack-Postava
Is there a way to run the Jenkins build with more detailed output, e.g. with one of gradle's debug flags? It looks like in the Jenkins environment the exclude rules (which should be ignoring the build/ directory) aren't working like they did for me and the reviewers, but there's not enough useful i

[jira] [Commented] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617121#comment-14617121 ] Ashish K Singh commented on KAFKA-2317: --- [~guozhang] do you mind taking a look? Than

Review Request 36270: Patch for KAFKA-2317

2015-07-07 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36270/ --- Review request for kafka. Bugs: KAFKA-2317 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2317: -- Status: Patch Available (was: Open) > De-register isrChangeNotificationListener on controller r

[jira] [Updated] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2317: -- Attachment: KAFKA-2317.patch > De-register isrChangeNotificationListener on controller resignati

[jira] [Commented] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617117#comment-14617117 ] Ashish K Singh commented on KAFKA-2317: --- Created reviewboard https://reviews.apache.

[jira] [Created] (KAFKA-2317) De-register isrChangeNotificationListener on controller resignation

2015-07-07 Thread Ashish K Singh (JIRA)
Ashish K Singh created KAFKA-2317: - Summary: De-register isrChangeNotificationListener on controller resignation Key: KAFKA-2317 URL: https://issues.apache.org/jira/browse/KAFKA-2317 Project: Kafka

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-07 Thread Ashish Singh
> On July 7, 2015, 5:53 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 898-903 > > > > > > I think we need to add the de-registration functions as other listeners >

[jira] [Updated] (KAFKA-2316) Drop java 1.6 support

2015-07-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2316: -- Summary: Drop java 1.6 support (was: deprecating java 1.6 support) > Drop java

[jira] [Commented] (KAFKA-2308) New producer + Snappy face un-compression errors after broker restart

2015-07-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617096#comment-14617096 ] Gwen Shapira commented on KAFKA-2308: - I kinda know why it happens, a patch will take

[jira] [Commented] (KAFKA-2316) deprecating java 1.6 support

2015-07-07 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617084#comment-14617084 ] Ismael Juma commented on KAFKA-2316: I think it would be more accurate for the title o

Re: Review Request 36265: Patch for KAFKA-2316

2015-07-07 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36265/#review90740 --- Ship it! Ship It! - Ismael Juma On July 7, 2015, 4:53 p.m., Srih

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90734 --- core/src/main/scala/kafka/controller/KafkaController.scala (lines 8

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-07 Thread Dong Lin
> On July 7, 2015, 5:28 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 408 > > > > > > Missed one more point here: I think it is better to use >

[jira] [Updated] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-07 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2306: Attachment: KAFKA-2306_2015-07-07_10:47:10.patch > New producer should emit metrics for buffer exhaustion >

[jira] [Commented] (KAFKA-2306) New producer should emit metrics for buffer exhaustion

2015-07-07 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617057#comment-14617057 ] Dong Lin commented on KAFKA-2306: - Updated reviewboard https://reviews.apache.org/r/36034/

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-07 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 7, 2015, 5:47 p.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-07 Thread Ashish Singh
> On July 7, 2015, 4:43 p.m., Jun Rao wrote: > > +1. Will fix the following during commit. Thanks Jun! - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90717

Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Ashish Singh
> On July 7, 2015, 4:50 p.m., Jun Rao wrote: > > Thanks for the latest patch. Looks good. Could you rebase? Done. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90721 -

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-07_10:42:41.patch > MetadataRequest returns stale list of brokers > -

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-07 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617047#comment-14617047 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard https://reviews.apache.org

Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 7, 2015, 5:42 p.m.) Review request for kafka. Bugs: KAFKA-972

Build failed in Jenkins: KafkaPreCommit #138

2015-07-07 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1367; Broker topic metadata not kept in sync with ZooKeeper; patched by Ashish Singh; reviewed by Jun Rao [joe.stein] KAFKA-2304 Supported enabling JMX in Kafka Vagrantfile patch by Stevo Slavic reviewed by

Re: Review Request 36034: Patch for KAFKA-2306

2015-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90730 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 35677: Patch for KAFKA-2288

2015-07-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35677/#review90725 --- Ship it! Thanks for the patch. +1. You can commit after addressing

[jira] [Updated] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-2304: - Resolution: Fixed Status: Resolved (was: Patch Available) pushed to trunk, thanks for the patch a

Build failed in Jenkins: Kafka-trunk #527

2015-07-07 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2314: proper MirrorMaker's message handler help message; reviewed by Guozhang Wang [junrao] kafka-1367; Broker topic metadata not kept in sync with ZooKeeper; patched by Ashish Singh; reviewed by Jun Rao ---

[jira] [Comment Edited] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616979#comment-14616979 ] Joe Stein edited comment on KAFKA-2304 at 7/7/15 5:01 PM: -- Thanks

[jira] [Commented] (KAFKA-2316) deprecating java 1.6 support

2015-07-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616974#comment-14616974 ] Sriharsha Chintalapani commented on KAFKA-2316: --- Created reviewboard https:/

[jira] [Updated] (KAFKA-2316) deprecating java 1.6 support

2015-07-07 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2316: -- Status: Patch Available (was: Open) > deprecating java 1.6 support > --

[jira] [Updated] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-2304: - Affects Version/s: (was: 0.8.3) Reviewer: Ewen Cheslack-Postava > Support enabling JMX in

Re: EOL JDK 1.6 for Kafka

2015-07-07 Thread Sriharsha Chintalapani
Thanks for  votes. Here is the JIRA with patch  https://issues.apache.org/jira/browse/KAFKA-2316 . --  Harsha On July 2, 2015 at 8:16:56 AM, Grant Henke (ghe...@cloudera.com) wrote: +1 On Wed, Jul 1, 2015 at 6:29 PM, Neha Narkhede wrote: > +1. It's about time. > > On Wed, Jul 1, 2015

[jira] [Commented] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616979#comment-14616979 ] Joe Stein commented on KAFKA-2304: -- Thanks [~ewencp] for the review, will take a look lat

[jira] [Updated] (KAFKA-2304) Support enabling JMX in Kafka Vagrantfile

2015-07-07 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-2304: - Fix Version/s: 0.8.3 > Support enabling JMX in Kafka Vagrantfile > ---

  1   2   >